[wp-trac] [WordPress Trac] #27869: Theme install return wrong install_url on network admin

[WordPress Trac]

#27869: Theme install return wrong install_url on network admin
--------------------------------+------------------------
 Reporter:  hirizh              |       Owner:
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  3.9.1
Component:  Networks and Sites  |     Version:  3.9
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:  multisite
--------------------------------+------------------------
Changes (by nacin):

 * component:  Themes => Networks and Sites


Comment:

 Well, that could have broken in far worse ways. :-)

 I think there is a simpler patch for this. [attachment:27869.diff].

 network_admin_url() should be used in theme-install.php too (where it is
 changed in [attachment:27869.patch]. self_admin_url() is appropriate for
 pages that work both inside and outside the network admin even when in
 multisite (like the plugins list table), while network_admin_url() is good
 for a page that is network-admin-only in multisite. We probably use
 self_admin_url() in a few places where network_admin_url() is more
 appropriate, but you only really notice it in odd situations like this,
 where admin-ajax.php doesn't have context.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27869#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform