[wp-trac] [WordPress Trac] #11009: screenshots of plugins from wordpress.org load over http instead of https when FORCE_SSL_ADMIN is enabled

WordPress Trac noreply at wordpress.org
Sat Oct 5 14:20:45 UTC 2013


#11009: screenshots of plugins from wordpress.org load over http instead of https
when FORCE_SSL_ADMIN is enabled
--------------------------------+---------------------
 Reporter:  brantgurga          |       Owner:  nacin
     Type:  defect (bug)        |      Status:  closed
 Priority:  normal              |   Milestone:  3.7
Component:  WordPress.org site  |     Version:  2.9
 Severity:  normal              |  Resolution:  fixed
 Keywords:  dev-feedback        |
--------------------------------+---------------------

Comment (by nacin):

 Replying to [comment:11 johnbillion]:
 > Rather than sending the SSL status to the API and the API returning SSL
 or not screenshot URLs as appropriate, shouldn't the API return both SSL
 and non-SSL screenshot URLs each time in two separate fields (eg.
 `screenshots` and `screenshots_ssl`? Then the site would decide which to
 use based on `is_SSL()`.

 It's inelegant how we return a block of content here, rather than an array
 of screenshot data, which is why I opted for just tweaking the content.
 [attachment:11009.diff] is what the patch would look like.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/11009#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list