[wp-trac] [WordPress Trac] #26220: Twenty Fourteen: Light accent color makes search icon almost invisible
WordPress Trac
noreply at wordpress.org
Sat Nov 30 00:14:29 UTC 2013
#26220: Twenty Fourteen: Light accent color makes search icon almost invisible
---------------------------+--------------------
Reporter: thomasguillot | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.8
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: |
---------------------------+--------------------
Comment (by celloexpressions):
I'm fine with going the route of re-defined color schemes, as long as they
change more than just the accent color and have an appropriate UI (we'd
need to build something visual that shows the colors instead of just
naming them in a standard `<select>`, see the new admin color scheme
selector for inspiration). One alternative worth mentioning is to reduce
the color picker to a hue picker, which would allow a wide rage of colors
but maintain the necessary contrast.
But do we really have time to address this before the hard (no commits)
freeze in 6 days? I'm not sure if we're still planning on shipping Twenty
Fourteen with 3.8, looking at our
[http://core.trac.wordpress.org/query?status=accepted&status=assigned&status=new&status=reopened&status=reviewing&component=Bundled+Theme&summary=%5ETwenty+Fourteen&group=milestone&col=id&col=summary&col=component&col=status&col=type&col=priority&col=milestone&order=priority
21 open tickets], but if we are, we may need to just extract the accent
color entirely to a plugin.
I'll attach a patch that removes the accent color feature. I've already
started putting together a plugin that has that functionality and the
ability to change the sidebar/header/footer color, with automatic
inversion of the text color when the background color becomes too light
(let me know if anyone wants to collaborate). We would want to market
this, and a plugin that restores the social links feature, if that
happens, to Twenty Fourteen users (maybe on the Codex page?), to help them
understand the concept of using plugins instead of (or in addition to)
child themes for smaller customizations.
If we do end up taking more time to polish Twenty Fourteen, I'd love to
further develop both the color schemes idea and a smarter version of the
color picker idea, potentially both in plugins first. Then, we could
evaluate both and see which is the better candidate for inclusion in
Twenty Fourteen, based on functionality and code weight/complexity. Since
Twenty Fourteen is a more complex default theme in general, I think it
deserves a more complex built-in customization solution, but I agree that
it should prevent users from creating critically low-contrast (or no-
contrast) choices.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/26220#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list