[wp-trac] [WordPress Trac] #25946: Twenty Fourteen: General code cleanup

[WordPress Trac]

#25946: Twenty Fourteen: General code cleanup
---------------------------+--------------------
 Reporter:  obenland       |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  3.8
Component:  Bundled Theme  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+--------------------

Comment (by kovshenin):

 Sorry for hi-jacking the thread like this. I'm looking at
 `twentyfourteen_paging_nav` and there's some pretty interesting stuff
 there: html_entity_decode, wp_parse_str, WP_Rewrite -- definitely
 something I wouldn't expect a default theme to do, and also `page` is the
 default base, but that can easily be changed, so instead of hard-coding
 it, we should use `$wp_rewrite->pagination_base`.

 However, given all that magic going on there, I think we should remove it
 all and write our own simple pagination function for Twenty Fourteen. One
 that simply uses `get_pagenum_link()`. Another option would be to play
 nice and add support for WP-PageNavi, like many themes do. A third option
 would be to write a patch for a better `paginate_links()`. Thoughts?

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25946#comment:25>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software