[wp-trac] [WordPress Trac] #26233: Twenty Fourteen: prefix the Featured_Content class and options
WordPress Trac
noreply at wordpress.org
Tue Nov 26 17:51:09 UTC 2013
#26233: Twenty Fourteen: prefix the Featured_Content class and options
-----------------------------+--------------------
Reporter: kovshenin | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.8
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch close |
-----------------------------+--------------------
Comment (by DrewAPicture):
Replying to [comment:5 obenland]:
> The class should not be in Twenty Fourteen in the first place - the
theme should only have to care about the display of featured content, not
how it's managed. Bringing it in was a compromise to enable support for a
slider that is smarter than using sticky posts. Using post tags is far
from ideal, but it's the next best thing.
This sounds like an excellent argument in favor of ''not'' bundling it
with the theme. If it's a plugin, great, ship it as a plugin. If it's part
of the theme, ship it as part of the theme, but prefix it as such.
In my opinion, this isn't the same thing as bundling a library or similar.
This is plugin functionality in a default theme, which seems weird to me.
It also sends kind of an odd message to send to the theme community,
because, really, that's what default themes do. They're supposed to be the
shining examples of how to do it the right way. Is this compromise doing
it the right way?
--
Ticket URL: <http://core.trac.wordpress.org/ticket/26233#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list