[wp-trac] [WordPress Trac] #26233: Twenty Fourteen: prefix the Featured_Content class and options
WordPress Trac
noreply at wordpress.org
Mon Nov 25 13:58:58 UTC 2013
#26233: Twenty Fourteen: prefix the Featured_Content class and options
---------------------------+--------------------
Reporter: kovshenin | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.8
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: |
---------------------------+--------------------
Comment (by kovshenin):
First pass in [attachment:26233.diff].
The `featured_content_layout` setting in the customizer should also
probably be prefixed, regardless of the fact that it's a theme mod and not
an option, because if a plugin declares a setting with the same name
(could be an option, not a theme mod) there will still be a conflict
because of how the customizer uses ids.
Also, since the option names have been changed (and are no longer
compatible with other plugins) we can decide whether we want
twentyfourteen-featured-content or twentyfourteen_featured_content,
because right now we use - for options and _ for the theme mod and other
places. I assume the - was for plugins compat.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/26233#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list