[wp-trac] [WordPress Trac] #26200: Twenty Fourteen: Drop Down Menu icons
WordPress Trac
noreply at wordpress.org
Mon Nov 25 04:32:39 UTC 2013
#26200: Twenty Fourteen: Drop Down Menu icons
---------------------------+------------------------------
Reporter: binarymoon | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: |
---------------------------+------------------------------
Comment (by celloexpressions):
Replying to [comment:4 binarymoon]:
> The ".primary-navigation ul ul a" bit is there so that all menu items
stretch to full width (which is only visible when there's an item being
hovered). Could use box-sizing instead so that the padding gets absorbed?
Or could just remove - but does mean there's a gap in some situations
(when there's sub sub menus).
Oh, I see the gap now. I had ended up with max-width there instead of min-
width, so it was messing up the layout. Leave that in.
> Have tidied up the css - hopefully that's all that's needed in terms of
css coding standards? Gonna add a patch in a sec.
I think you got everything except "tabs, not spaces" for indentation.
There's also a space at the end of each line that should be removed (I'm
guessing your text editor added those). Patches should also be made
relative to the WordPress root.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/26200#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list