[wp-trac] [WordPress Trac] #25906: Twenty Fourteen: adjust fixed header margin for MP6 merge

[WordPress Trac]

#25906: Twenty Fourteen: adjust fixed header margin for MP6 merge
------------------------------+------------------
 Reporter:  celloexpressions  |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  3.8
Component:  Bundled Theme     |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |
------------------------------+------------------

Comment (by celloexpressions):

 I think this is getting blown way out of proportion.

 While this is a problem in general, for Twenty Fourteen only we're talking
 about a '''4px gap''', only for users who are logged in (or the rare cases
 when a site shows the admin bar to logged-out users), and '''only for
 older versions of WordPress'''. Considering that the vast majority of
 users will get Twenty Fourteen by updating to 3.8, I don't see much of a
 concern there, since this is a very minor bug (would be interesting to see
 stats on default themes installed on older versions of WordPress; after
 Twenty Thirteen didn't support it, do users expect any, let alone almost-
 complete compatibility?). And, the versions that we are theoretically
 supporting (back to 3.6) will have only been in the wild for a few months
 when 3.8 comes out; due to the shorter cycles I would expect a bigger
 concern with users that don't update and want to install Twenty Fourteen
 for 3.5 (which I believe we don't support) than 3.6 or 3.7.

 So I'd like to add a fourth option:
 4. Leave a small gap below the admin bar and above the Twenty Fourteen
 fixed header for users who install Twenty Fourteen on older versions of
 WordPress.

 For the other options, I'd say:
 1. Let's not set a precedent of doing this. And WP toolbar is more useful
 for logged-in users.
 2. Only for logged-in users/if the toolbar is showing, if we must. Please
 don't remove functionality because of a very minor back-compat concern for
 something that will probably rarely be used in an older WP environment.
 It's just a little 4px gap.
 3. Would solve the issue for Twenty Fourteen and everyone else, but
 doesn't really address the long-term problem (are we stuck with a 28px
 toolbar forever?). The mobile breakpoint where it jumps even bigger is
 more of a concern anyway, since themes need to add extra breakpoints to
 match WordPress'.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25906#comment:25>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software