[wp-trac] [WordPress Trac] #26188: Twenty Fourteen: Improve the Basic Child Theming Experience
WordPress Trac
noreply at wordpress.org
Sun Nov 24 10:48:59 UTC 2013
#26188: Twenty Fourteen: Improve the Basic Child Theming Experience
------------------------------+------------------------------
Reporter: celloexpressions | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: |
------------------------------+------------------------------
Comment (by celloexpressions):
I found three issues in the header/sidebar/footer for color changes:
- unneeded selector on the header nav
- site description is set to overlap the shadow on the header. We should
probably give it some more padding/margin; it's only not an issue for us
by default because the background is pure black (`#000`), ''anything''
else and it'll show up.
- it is almost impossible to figure out how the sidebar's background color
is set. Took me forever, and I'm pretty familiar with Twenty Fourteen and
using tools to find where style rules are set. If Chrome hadn't recently
added pseudo-elements to the document tree in their inspector, I wouldn't
have found it. On top of the fact that we're using a pseudo-element, the
rule is burried '''3500 lines''' into our main css file. I think this will
be one of the most common things people will want to change, and the
solution is simple if you know it. We either need a good way of
documenting this, or to use a different, more cumbersome method for
setting the sidebar background color (I do really like how this is being
done, haven't seen this approach before, but it's unexpected).
See patches and screenshots above for the first two. The third one is
certainly fixable, but will be less eloquent. We need to decide if we'd
rather have a solution that's beautiful code or easy to customize for
coloring the left sidebar background.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/26188#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list