[wp-trac] [WordPress Trac] #26029: jshint shouldn't throw errors: wp-admin/js/wp-fullscreen.js

[WordPress Trac]

#26029: jshint shouldn't throw errors: wp-admin/js/wp-fullscreen.js
--------------------------+------------------------------
 Reporter:  dougwollison  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Build Tools   |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by mattwiebe):

 @dougwollison your patches seem to have used basic jshint rather than
 `grunt jshint:core --file=wp-fullscreen.js` as instructed in the
 [http://make.wordpress.org/core/2013/11/13/finding-fixing-javascript-
 errors-with-jshint/ make/core post]. The grunt version ignores `eqeqeq`
 and `curly` options for now, since there were too many of those errors to
 get in for this round.

 I've attached a patch that ignores `eqeqeq` and `curly` errors. Also note
 that the file settles on `tinymce` rather than `tinyMCE` as the preferred
 global namespace in accordance with
 [http://www.tinymce.com/wiki.php/API3:tinymce.api.3.x their docs].

--
Ticket URL: <http://core.trac.wordpress.org/ticket/26029#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software