[wp-trac] [WordPress Trac] #14028: Maintenance mode nag persists after successful upgrade

[WordPress Trac]

#14028: Maintenance mode nag persists after successful upgrade
-----------------------------+------------------
 Reporter:  mrmist           |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  3.8
Component:  Upgrade/Install  |     Version:  3.0
 Severity:  normal           |  Resolution:
 Keywords:                   |
-----------------------------+------------------
Changes (by dd32):

 * keywords:  has-patch =>


Comment:

 Replying to [comment:11 Viper007Bond]:
 > My WordPress 3.7 install just tired to upgrade itself to 3.7.1 but
 failed as I don't have my files writable.
 >
 > Rather than making them writable I just went back to managing it via
 SVN. I deleted all my Core files, did a checkout, and now I'm running
 3.7.1.

 It looks like this was caused by this point by Sergey:
 > * Noticed that $comparison doesn't actually affect anything. See #25887.

 That ultimately meant any early-failures (ie. prior to copying files, as
 your error would've been) the nag would get shown when it shouldn't have.

 Looking at [attachment:14028.3.diff] further, we can't go with that, it'll
 cause a checksum API request every pageload, and md5_file() every file
 every page load.

 With #25887 fixed, the instances of getting the non-dismissible message
 would be limited to:
 * .maintanence file exists, or
 * Background Update attempted, failed DURING copying files, and, user
 updates via SVN/FTP instead. (we do a files_are_writable() check before we
 copy)

--
Ticket URL: <http://core.trac.wordpress.org/ticket/14028#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software