[wp-trac] [WordPress Trac] #25930: Twenty Fourteen: Search Bar Widget style is very dark
WordPress Trac
noreply at wordpress.org
Tue Nov 12 22:25:51 UTC 2013
#25930: Twenty Fourteen: Search Bar Widget style is very dark
---------------------------+--------------------
Reporter: RDall | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.8
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch |
---------------------------+--------------------
Comment (by RDall):
In some of the [https://developer.mozilla.org/en-US/docs/Web/CSS/:-moz-
placeholder documentation I looked up on placeholder] the colour was
either a hex code or a color. I never saw the use of the rgba in any of
the examples.
What was happening was the placeholder couldn't read the rgba style.
In conversation with iamtakashi on IRC I said I wanted to keep to his
colours implemented but this caused confusion as that is what I was over
writing in my patch.
I had used the hex instead of the rgba because the rgba wasn't highlighted
properly in my code editor. see screenshot
http://cl.ly/image/3G302O3F1W3W. So I automatically switch to Hex without
even thinking about the actual issue.
This second patch translates the rgba to a hex colour so the placeholder
can properly have iamtakashi previous style applied but in a hex format
that can be read by the placeholder.
Also I did increase the opacity of the border around the search bar as I
though it was a little lost as well.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25930#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list