[wp-trac] [WordPress Trac] #25817: PHP Fatal error on background update: $wp_filesystem is not an object

[WordPress Trac]

#25817: PHP Fatal error on background update: $wp_filesystem is not an object
-----------------------------+--------------------
 Reporter:  markjaquith      |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  high             |   Milestone:  3.7.2
Component:  Upgrade/Install  |     Version:  3.7
 Severity:  major            |  Resolution:
 Keywords:  has-patch        |
-----------------------------+--------------------

Comment (by dd32):

 Replying to [comment:3 SergeyBiryukov]:
 > Replying to [comment:2 dd32]:
 > > However, `WP_Automatic_Updater` doesn't expect a false return either
 and may fail further down the stack somewhere in the notify emails/etc. as
 they expect `true` or `WP_Error`.
 >
 > [attachment:25817.2.patch] makes sure `Core_Upgrader::upgrade()` returns
 `WP_Error` if `fs_connect()` failed.

 That just makes it differ from Plugin_Upgrader & Theme_Upgrader though,
 both of which return false in these events too, and is arguably correct
 for them to do so.

 We should just make sure that Core_Upgrader returns the false without
 fataling, and that Automatic_Updater can handle a false return value from
 Core_Upgrader, Plugin_Upgrader, or Theme_Upgrader.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25817#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software