[wp-trac] [WordPress Trac] #22435: Export API

WordPress Trac noreply at wordpress.org
Tue Nov 5 15:54:11 UTC 2013


#22435: Export API
------------------------------------+------------------------------
 Reporter:  nbachiyski              |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Export                  |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+------------------------------

Comment (by dllh):

 I've added export.2.diff, which incorporates nbachiyski's feedback re
 maintaining caller control. Basically:

 1. The HTTP writer now handles the die() statements when errors are
 caught.
 2. The returner writer returns WP_Error objects when an exception is
 caught.
 3. The base writer returns WP_Error objects when an exception is caught.
 4. The file writer re-throws any caught exceptions so that they can be
 handled further up the stack.

 The patch also incorporates the echo/output buffering issue that
 nbachiyski highlighted and linked to a github commit for.

 Based on westi's feedback, I'm leaving the tax loop stuff in for now.

 I've tested these changes both with the web exporter and with a script
 that calls wp_export() at the command line, and so far so good. I'd
 gratefully receive further suggestions for improvements.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/22435#comment:38>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list