[wp-trac] [WordPress Trac] #23685: Explicitly globalize version variables

[WordPress Trac]

#23685: Explicitly globalize version variables
----------------------------------------+-----------------------------
 Reporter:  nbachiyski                  |       Owner:  wonderboymusic
     Type:  defect (bug)                |      Status:  closed
 Priority:  normal                      |   Milestone:  3.8
Component:  Unit Tests                  |     Version:  3.6
 Severity:  normal                      |  Resolution:  fixed
 Keywords:  has-patch 3.7-early commit  |
----------------------------------------+-----------------------------

Comment (by dd32):

 > In [26008]

 That commit applied both patches here, where it was only one or the other
 that was intended on being applied I think.

 Adding the globals to `version.php` will mean that if a plugin is
 overwriting the `$wp_version` variable (to prevent the version being
 displayed or something) we'll then re-overwrite it. That's OK to me, but
 is worth noting.

 Since we always include `version.php` within the update checks, this
 should still mean we use an untainted version variable though.

 Also, SergeyBiryukov's comment regarding `$wpdb` is still valid, but
 should probably be pushed to another ticket.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/23685#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software