[wp-trac] [WordPress Trac] #25819: "ms_files_rewriting" site option is not created during upgrades

[WordPress Trac]

#25819: "ms_files_rewriting" site option is not created during upgrades
-----------------------------+------------------------------
 Reporter:  gradyetc         |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:  3.5
 Severity:  minor            |  Resolution:
 Keywords:                   |
-----------------------------+------------------------------

Comment (by gradyetc):

 The call to `update_site_option( 'ms_files_rewriting', '1' )` in
 `upgrade_network()` is failing due to that filter.

 In most cases the "ms_files_rewriting" site option will not exist when
 running the upgrade.  The default value added by that filter causes the
 check within `update_site_option` that would normally add it to fail:

 {{{
 if ( false === $oldvalue )
         return add_site_option( $option, $value );
 }}}

 The end result is it continues, attempting to UPDATE a non-existent
 meta_key within wp_sitemeta.

 {{{
 UPDATE `wp_sitemeta` SET `meta_value` = '1' WHERE `site_id` = 1 AND
 `meta_key` = 'ms_files_rewriting'
 }}}

 A fix is attached in 25819.patch.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25819#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software