[wp-trac] [WordPress Trac] #23216: Create "WP Heartbeat" API

[WordPress Trac]

#23216: Create "WP Heartbeat" API
--------------------------------------+-----------------------
 Reporter:  azaozz                    |       Owner:
     Type:  task (blessed)            |      Status:  reopened
 Priority:  normal                    |   Milestone:  3.6
Component:  Administration            |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  autosave-redo needs-docs  |
--------------------------------------+-----------------------

Comment (by adamsilverstein):

 Replying to [comment:101 carldanley]:
 > Great point! Glad you worked that in; got my standards mixed up for a
 second: http://contribute.jquery.org/style-guide/js/#quotes.

 yes, its easy get mixed up, but posting to trac is a sure way to get
 corrected :) (i know from experience)

 to azaozz's credit, i think the suggestion to always use curly brackets
 for conditionals in JS was added sometime after he wrote the bulk of that
 code. I might be wrong, but I'm pretty sure it used to read more like the
 PHP spec which  suggests omitting them for brevity,
 http://make.wordpress.org/core/handbook/coding-standards/php/#brace-
 style).

 I agree its better to use them (and Douglas Crockford explains why).

 after installing your patch (i went pack to your version to be sure it
 wasn't my quote change), i am getting the following error in the JS
 console, and my heart has stopped beating:

 {{{
 TypeError: _Settings.hasActiveConnection is not a function
 [Break On This Error]

 if ( _Settings.hasActiveConnection() === false ) {

 heartb...1-24717 (line 376)

 }}}

--
Ticket URL: <http://core.trac.wordpress.org/ticket/23216#comment:102>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software