[wp-trac] [WordPress Trac] #23284: Wrong parameter order for stripos in wp-includes/functions.php

WordPress Trac noreply at wordpress.org
Thu Jan 24 18:07:20 UTC 2013


#23284: Wrong parameter order for stripos in wp-includes/functions.php
--------------------------+--------------------
 Reporter:  Kalindor      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.5.1
Component:  General       |     Version:  3.5
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------
Changes (by kurtpayne):

 * cc: kurtpayne (added)
 * keywords:   => has-patch


Comment:

 I can replicate these results.

 Simply put: we do not need to know a URL's protocol to add a query
 argument.  We just care about question marks and equals signs.

 Both patches look sane and pass the unit tests.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23284#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list