[wp-trac] [WordPress Trac] #25459: Provide more meaningful links in Edit Post/Page
WordPress Trac
noreply at wordpress.org
Tue Dec 10 14:44:45 UTC 2013
#25459: Provide more meaningful links in Edit Post/Page
-----------------------------------------------+---------------------------
Reporter: grahamarmfield | Owner:
Type: enhancement | Status: new
Priority: low | Milestone: Future
Component: Accessibility | Release
Severity: minor | Version: 3.6.1
Keywords: i18n-change has-patch 2nd-opinion | Resolution:
-----------------------------------------------+---------------------------
Comment (by GaryJ):
neil_pie, I don't think the class name filter serves any benefit here -
there's ~146 occurrences of "screen-reader-text" across all files in WP,
so it's fairly well established and understood. Since the WP admin CSS
requires a consistent class name, I can't see any reason to make it
filterable, even if the intention was to push all instances of "screen-
reader-text" through a new function (which wouldn't necessarily be great
anyway).
The function name seems tricky to nail down - either quite verbose, or
unpredictably abbreviated.
How about basing it on something that, as developers, we already know,
such as the `img` `alt` attribute (which arguably has some parity to what
is being covered here). i.e.:
{{{
// Easy function name to remember
function alt( $display_text, $screen_reader_text ) {...}
// or
// Reversed arguments, so that you think of "alt text" e.g. "alt" first,
then "text" after.
function alt_text( $screen_reader_text, $display_text ) {...}
}}}
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25459#comment:45>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list