[wp-trac] [WordPress Trac] #22856: Twenty Twelve upgrade issues

[WordPress Trac]

#22856: Twenty Twelve upgrade issues
-----------------------------+--------------------
 Reporter:  nacin            |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  3.5.1
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:                   |
-----------------------------+--------------------

Comment (by nacin):

 WP_Theme works exactly how get_themes() did in classifying an empty
 directory — containing neither files for a theme, nor other themes — as a
 broken theme. This wasn't a change in behavior in 3.4. Also, WP_Theme
 isn't actually checking that the directory is empty — only that it is
 missing both index.php and style.css. It could have every other file, for
 all we know.

 I'm fine with considering such a change for 3.6. For 3.5.1, though, what
 should we do? [23179] looks like a good change for 3.6 only.

 For 3.5.1, it seems like we have two options:
  1. Detect an empty directory and delete it, clearing the path for Twenty
 Twelve to be installed.
  2. Detect an empty directory and install the actual Twenty Twelve over
 it.

 Option 1 is something we'd do in update-core.php for the foreseeable
 future. If we were do to option 2, it's probably something we'll do up to
 3.6.0 only (either through 3.5.x, or including 3.6.0). Then in 3.6, we can
 rectify the WP_Theme/WP_Upgrader discrepancy.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22856#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software