[wp-trac] [WordPress Trac] #22856: Twenty Twelve upgrade issues

[WordPress Trac]

#22856: Twenty Twelve upgrade issues
-----------------------------+--------------------
 Reporter:  nacin            |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  3.5.1
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:                   |
-----------------------------+--------------------

Comment (by dd32):

 As it turns out, an empty twentytwelve directory does not prevent
 WP_Upgrader from installing the theme properly, so no changes are needed
 there.

 However, !WordPress classifies an empty theme directory as being a theme
 which exists, but is broken. As a result, the current theme install
 listing page says there's an update available for TwentyTwelve.
 However, as far as WP_Upgrader is concerned, an empty theme directory is
 not an installed theme, and as a result, can't perform an upgrade on an
 empty directory.

 Now, I might be biased, but in the battle of WP_Upgrader vs WP_Theme, I'm
 inclined to go with WP_Upgrader. Attached is a patch which makes WP_Theme
 aware of empty theme directories, and doesn't claim that the theme exists.
 @nacin review?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22856#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software