[wp-trac] [WordPress Trac] #21206: Replace Farbtastic color picker with ???...
WordPress Trac
wp-trac at lists.automattic.com
Sat Aug 25 19:31:22 UTC 2012
#21206: Replace Farbtastic color picker with ???...
-----------------------------------+------------------
Reporter: lessbloat | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch ux-feedback |
-----------------------------------+------------------
Comment (by mattwiebe):
Great work on the improved UI @lessbloat - I'll look through your latest
patch and see if there's anything more for me to contribute to it. I have
some accessibility enhancements, but you may have beaten me to the punch.
Definitely need to fix the bug in Iris where it doesn't really allow the
text input to be blank.
Replying to [comment:32 downstairsdev]:
> Note @mattwiebe:
>
> The colorpicker is set up with:
> $('#link-color').wpColorPicker();
>
> But to change the color, it's:
> $("#link-color").iris("option", "color", newDefault )
>
> Seems like that should be normalized to always use "wpColorPicker" or
"iris".
Yeah. So, `iris` is the the more general picker component, whereas
`wpColorPicker` is the WP-specific color control. One thing I noted
earlier was that it would make sense to focus on `wpColorPicker` so that
we could more seamlessly swap in something other than Iris in the future
should it look to serve our needs better. Logic would then dictate that
all interactions with Iris be abstracted through `wpColorPicker`. So, I
guess I should make that work. :)
--
Ticket URL: <http://core.trac.wordpress.org/ticket/21206#comment:34>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list