[wp-trac] [WordPress Trac] #15600: shortcode_unautop returns emtpy string

WordPress Trac wp-trac at lists.automattic.com
Sat May 7 10:32:17 UTC 2011


#15600: shortcode_unautop returns emtpy string
-------------------------------------------------+-------------------------
 Reporter:  mdbitz                               |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  high                                 |   Milestone:  Future
Component:  Formatting                           |  Release
 Severity:  major                                |     Version:  3.0.1
 Keywords:  needs-testing has-patch needs-unit-  |  Resolution:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by mdawaffe):

 Thanks for pointing me at the test cases.

 15600.3.diff now passes the same tests as r17834-core.

 I tested with
 {{{
 php wp-test.php -t
 WPTestShortcodeOutput1,WPTestShortcodeOutputParagraph,TestShortcode,TestShortcodeStripping
 }}}

 Still a significant speedup.

 {{{
 $ ./shortcodes-tests.sh 15600.3.diff
 Reverted 'wp-includes/formatting.php'
 Reverted 'wp-includes/shortcodes.php'
 shortcode_unautop() Tests: original
 SHORT TIME: 0.0092761516571045
 LONG  TIME: 1.3933248519897
 SHORT BACKTRACE REQUIREMENT: 232
 LONG  BACKTRACE REQUIREMENT: 135670

 do_shortcode() Tests: original
 SHORT TIME: 0.029265403747559
 LONG  TIME: 2.1743712425232
 SHORT BACKTRACE REQUIREMENT: 420
 LONG  BACKTRACE REQUIREMENT: 135858

 patching file wp-includes/shortcodes.php
 patching file wp-includes/formatting.php
 shortcode_unautop() Tests: patched
 SHORT TIME: 0.0078203678131104
 LONG  TIME: 0.38498711585999
 SHORT BACKTRACE REQUIREMENT: 42
 LONG  BACKTRACE REQUIREMENT: 46

 do_shortcode() Tests: patched
 SHORT TIME: 0.024780035018921
 LONG  TIME: 0.39810061454773
 SHORT BACKTRACE REQUIREMENT: 47
 LONG  BACKTRACE REQUIREMENT: 51

 DIFFS:
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15600#comment:20>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list