[wp-trac] [WordPress Trac] #17816: WordPress in dev environments should update /wp-content/* again

[WordPress Trac]

#17816: WordPress in dev environments should update /wp-content/* again
------------------------------------------------+------------------
 Reporter:  ocean90                             |       Owner:
     Type:  defect (bug)                        |      Status:  new
 Priority:  normal                              |   Milestone:  3.2
Component:  Upgrade/Install                     |     Version:  3.2
 Severity:  normal                              |  Resolution:
 Keywords:  dev-feedback 2nd-opinion has-patch  |
------------------------------------------------+------------------

Comment (by dd32):

 > I think we need to have an IRC conversation

 Quite agree.

 > Don't see why we're removing the exists checks.

 Quite simply, They shouldn't've been there in the first place, an error on
 my part.. That being said, by having them there, it prevents overwriting
 of the files if they've been copied into place already, so if someone
 installs TwentyEleven on 3.1, and upgrades to 3.2, they won't get the
 updated copy of the theme. etc..

 It might be better to not remove them, and simple change it to
 {{{
 if ( !$development_upgrade && $wp_filesystem->exists($dest . $filename) )
     continue;
 }}}

 If we cant rely upon the development response, i'd call a development
 upgrade to be anything where, the previous, or new version, contains a
 dash in the version string.. not the most reliable, but certainly
 currently compatible.. (Need to check if debian and friends hammer their
 own suffixes in though)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17816#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software