[wp-trac] [WordPress Trac] #16024: Conditional Comments for JS

WordPress Trac wp-trac at lists.automattic.com
Sat Jun 25 04:47:12 UTC 2011


#16024: Conditional Comments for JS
---------------------------------+-----------------------------
 Reporter:  filosofo             |       Owner:
     Type:  enhancement          |      Status:  new
 Priority:  normal               |   Milestone:  Future Release
Component:  Template             |     Version:  3.1
 Severity:  normal               |  Resolution:
 Keywords:  has-patch 3.3-early  |
---------------------------------+-----------------------------
Changes (by aaroncampbell):

 * keywords:  has-patch 3.2-early => has-patch 3.3-early


Comment:

 I ran against this same thing wanting to use an html5.js file much like
 Twenty Eleven does.  The only drawback is that the conditional option is
 ignored is do_concat is true.  We have two options here.  One is to not
 concatenate scripts that have a condition, the second is to just say that
 concatenation doesn't support conditionals.  If we do that latter I'd move
 the logic into the else so it's only run if do_concat is false.

 I'll try to add a couple patches here...one for each way so we can test
 them out an see what works best.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16024#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list