[wp-trac] [WordPress Trac] #17777: Simplifying some Twenty-Eleven strings for i18n

[WordPress Trac]

#17777: Simplifying some Twenty-Eleven strings for i18n
---------------------------+-------------------------
 Reporter:  xibe           |       Owner:  nbachiyski
     Type:  enhancement    |      Status:  assigned
 Priority:  normal         |   Milestone:  3.2
Component:  Bundled Theme  |     Version:  3.2
 Severity:  normal         |  Resolution:
 Keywords:                 |
---------------------------+-------------------------

Comment (by dd32):

 Those replacement strings look a lot better, easier for translators, and
 still allows the theme to have so many classes.

 However, the .sep class isn't even used by the theme in the body, It
 wraping Posted on seems useless to me, I'm not sure it's even really
 needed in the rest of these strings, like you said, target the entire
 string, style the individuals.

 > functions.php

 My suggestion (If removing some of the sep classes from some strings can
 be done for simplification)
 {{{
 Posted on %1$s <span class=\"by-author\"> by %2$s</span>
 }}}

 It retains a span in there(see below), but is vastly more simple than it's
 predecessor.

 > and I don't see much point in by-author.

 Funny you should mention that, I was just about to suggest adding it to
 another string (and removing a then duplicate string), As you've spotted,
 it's to hide the author on single author sites, unfortunately, it's only
 actually applied in one of 3 or 4 strings.

 These 2 strings are almost identical, I'd be willing to suggest the first
 one should be replaced by the 2nd one:
  1. {{{This entry was posted in %1$s. Bookmark the <a href="%3$s"
 title="Permalink to %4$s" rel="bookmark">permalink</a>.}}} Used in
 content-featured.php, ie. only for the "Featured Post" on the showcase
 template
  2. {{{This entry was posted in %1$s by <a href="%6$s">%5$s</a>. Bookmark
 the <a href="%3$s" title="Permalink to %4$s"
 rel="bookmark">permalink</a>.}}}  Used in content-single.php - ie. for
 singular views of posts and Custom Post Types.

 Or, if the theme is to keep the by-author class, it should probably be
 changed to:
  * {{{This entry was posted in %1$s<span class="by-author"> by <a
 href="%6$s">%5$s</a></span>. Bookmark the <a href="%3$s" title="Permalink
 to %4$s" rel="bookmark">permalink</a>.}}}

 We also need another string for custom post types as well (As mentioned in
 #17748) as Custom Post Types don't have categories (normally)
  * {{{<span class="by-author">This entry was posted by <a
 href="%6$s">%5$s</a></span>. Bookmark the <a href="%3$s" title="Permalink
 to %4$s" rel="bookmark">permalink</a>.}}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17777#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software