[wp-trac] [WordPress Trac] #16406: Admin bar localization

WordPress Trac wp-trac at lists.automattic.com
Fri Jun 10 22:44:46 UTC 2011


#16406: Admin bar localization
-------------------------------------+------------------
 Reporter:  pavelevap                |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  3.2
Component:  I18N                     |     Version:  3.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------
Changes (by nacin):

 * keywords:  has-patch => has-patch needs-testing


Comment:

 Okay, I came up with something. New patch works around the issues I had
 described.

 New name_admin_bar labels are defined specifically for posts and pages.
 They are specifically not used as defaults.

 Instead, name_admin_bar defaults to singular_name if present (which in
 turn defaults to name or ->label if present), and defaults to object->name
 (the internal slug) directly if not.

 This is unique from other areas of core. If you don't specify any labels
 for a post type, you'll literally get "Posts" and "Post" (or "Pages" and
 "Page") everywhere. That doesn't work if they all appear in the same menu.

 I would think that any post type of show_ui = true and show_in_menu = true
 (could even be a public = true check there) would also have labels.

 Suggest commit, except that there's been no testing on this. Can someone
 please kick the tires?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16406#comment:16>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list