[wp-trac] [WordPress Trac] #17694: DRY: code to display update counts is redundant and buggy
WordPress Trac
wp-trac at lists.automattic.com
Sun Jun 5 21:01:32 UTC 2011
#17694: DRY: code to display update counts is redundant and buggy
-----------------------------+------------------------------
Reporter: mitchoyoshitaka | Owner: mitchoyoshitaka
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Administration | Version: 3.2
Severity: normal | Resolution:
Keywords: has-patch |
-----------------------------+------------------------------
Comment (by duck_):
Nice.
Would `function_exists( 'get_core_updates' )` be more appropriate that
`is_admin()` to make it more obvious what's being checked for? We're not
not displaying the core update on the frontend because it's not the admin,
but because it would fatal error.
And just spotted this, not introduced by the patch, but why "n Themes
Updates"? Note the plural "Themes" unlike "n Plugin Updates".
--
Ticket URL: <http://core.trac.wordpress.org/ticket/17694#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list