[wp-trac] [WordPress Trac] #17682: Browser nag PHP Notice if no user agent is set
WordPress Trac
wp-trac at lists.automattic.com
Sat Jun 4 15:35:14 UTC 2011
#17682: Browser nag PHP Notice if no user agent is set
------------------------------+------------------
Reporter: duck_ | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.2
Component: Warnings/Notices | Version: 3.2
Severity: normal | Resolution:
Keywords: has-patch |
------------------------------+------------------
Comment (by duck_):
Replying to [comment:1 ryan]:
> wp_check_browser_version() returns false in one spot and now void in two
spots. Should those all be returning false? The three calls core makes
to wp_check_browser_version() could stand to check for false.
Agreed. Standardised on returning false. Added in checks for truthy-ness
of the returned value too even though it's not entirely necessary.
Also added @return docs, added spacing in inline response documentation
and added standard .0 to 3.2.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/17682#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list