[wp-trac] [WordPress Trac] #17680: Using "update automatically" can destroy a theme in a Windows environment

[WordPress Trac]

#17680: Using "update automatically" can destroy a theme in a Windows environment
-----------------------------+-----------------------------
 Reporter:  blurback         |      Owner:
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Upgrade/Install  |    Version:
 Severity:  major            |   Keywords:
-----------------------------+-----------------------------
 If there are any locked files or files in use, Update Automatically
 destroys the theme.

 I've experienced this three different ways:
  1. The machine is really slow to delete the original theme dir, when the
 update is moved into the themes dir, an error occurs: "Could not create
 directory".  The theme is now gone.
  1. If there are any locked files in the outdated theme (e.g. SVN), all
 the files except the locked one will be deleted.  Upgrader bails and
 you're left with a broken/empty theme.
  1. If any of the files are in use, all files inside the theme will be
 deleted but the file system will throw an error.  The updater bails with
 an empty theme directory.

 Steps to duplicate:
  1. On a Win hosted install, open the twentyten theme directory
  1. Edit stylesheet, change version to 1.0
  1. Open screenshot.png in paint
  1. In the wp-admin, upgrade the theme
  1. Sad times (screenshot attached)

 Proposed solution is to try to rename the old theme first.  Provides two
 benefits:
  1. Have a backup of original theme if something breaks mid-way
  2. Never left with a broken site

 Note: all the more reasons why one should not use Windows :/ but I have no
 choice.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17680>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software