[wp-trac] [WordPress Trac] #17559: Deprecated query_string doesn't support array arguments

WordPress Trac wp-trac at lists.automattic.com
Fri Jun 3 09:25:46 UTC 2011


#17559: Deprecated query_string doesn't support array arguments
--------------------------+--------------------
 Reporter:  nacin         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.1.4
Component:  Query         |     Version:
 Severity:  critical      |  Resolution:
 Keywords:                |
--------------------------+--------------------
Changes (by westi):

 * cc: westi (added)


Comment:

 I think the patch is too clever.

 We should have wrappers for do_action and apply_filters which we call for
 deprecated actions/filters.

 e.g. {{{do_deprecated_action}}} and {{{do_deprecated_filter}}}

 Inside these functions we put all of the has_action and reporting logic
 and don't change the way the code works.

 I think this is much cleaner than littering the code with has_action ...
 do_action fragments.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17559#comment:19>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list