[wp-trac] [WordPress Trac] #11598: code improvements in wp_:dashboard_plugins_output()
WordPress Trac
wp-trac at lists.automattic.com
Mon May 31 15:00:51 UTC 2010
#11598: code improvements in wp_:dashboard_plugins_output()
-------------------------+--------------------------------------------------
Reporter: hakre | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.1
Component: General | Version: 2.9
Severity: normal | Keywords: has-patch
-------------------------+--------------------------------------------------
Changes (by hakre):
* keywords: needs-patch => has-patch
Comment:
* Changed the patch according to dd32 feedback regarding the do/while
clause.
* Used in_array() to check for installed slugs instead of the
''reset/foreach combo''[sic!] that is currently in there. Let me know if
that's ok or not (that was with substr() compare but I assumed that this
implicated problems as well).
* Description filter is put next to the other filters.
* Removed unnecessary isset() check after the while(true) loop.
* Added comments
* Formatted the code according to the styleguide
I have this running on my testbed against current trunk with no probs.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/11598#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list