[wp-trac] [WordPress Trac] #12860: Stripslashes_deep doesn't handle arrays of objects well.

WordPress Trac wp-trac at lists.automattic.com
Sat May 22 07:41:59 UTC 2010


#12860: Stripslashes_deep doesn't handle arrays of objects well.
--------------------------+-------------------------------------------------
 Reporter:  Otto42        |        Owner:        
     Type:  defect (bug)  |       Status:  closed
 Priority:  normal        |    Milestone:  3.0   
Component:  Formatting    |      Version:  3.0   
 Severity:  normal        |   Resolution:  fixed 
 Keywords:                |  
--------------------------+-------------------------------------------------
Changes (by westi):

  * status:  reopened => closed
  * resolution:  => fixed


Comment:

 Replying to [comment:12 nacin]:
 > Generally we see failures in stripslashes_deep for WP_Error objects that
 aren't properly checked for earlier and end up getting passed in.
 Wondering if we should account for that.

 We could do - but what would we do - return another WP_Error / wp_die.

 I think we have to take a pragmatic approach and expect plugin devs to
 check things for WP_Error and not have lots of checks all over the place
 in utility functions for it.

 I think we can safely close this down now as I've not seen any fallout
 from the change.

 We can revisit it in the future if necessary but education may be a better
 solution.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12860#comment:13>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list