[wp-trac] [WordPress Trac] #8461: MediaUpload: "Select Files" Flash button doesn't resize for translation

[WordPress Trac]

#8461: MediaUpload: "Select Files" Flash button doesn't resize for translation
------------------------------+---------------------------------------------
 Reporter:  xibe              |        Owner:                
     Type:  defect (bug)      |       Status:  reopened      
 Priority:  normal            |    Milestone:  Future Release
Component:  Upload            |      Version:  2.7           
 Severity:  normal            |   Resolution:                
 Keywords:  i18n needs-patch  |  
------------------------------+---------------------------------------------

Comment(by hakre):

 Just checked the code, my assumption was right that this is set by
 parameters and it's not hard-coded in the swf.

 Here is the according HTML code taken out of the current version's output
 for the flash upload:

 {{{
 <object id="SWFUpload_0" type="application/x-shockwave-flash" data="/wp-
 includes/js/swfupload/swfupload.swf?preventswfcaching=1274426323139"
 width="132" height="23" class="swfupload">
   <param name="wmode" value="window">
   <param name="movie" value="/wp-
 includes/js/swfupload/swfupload.swf?preventswfcaching=1274426323139">
   <param name="quality" value="high">
   <param name="menu" value="false">
   <param name="allowScriptAccess" value="always">
   <param name="flashvars" value="//Flashvars//">
 </object>
 }}}

 Flashvars are the following (decoded):

 {{{
 SWFUpload_0
 uploadURL=http://.../wp-admin/async-upload.php
 useQueryString=false
 requeueOnError=false
 httpSuccess=
 assumeSuccessTimeout=0
 params=post_id=1243
 auth_cookie=xxxxx%7C1275122458%7C835901edd192d0fb64d5e0cf3df1c2fb
 logged_in_cookie=xxxxx%7C1275122458%7C9ddb9cfe5dd5c7c23846b50237577b45
 &amp;
 _wpnonce=f4f9391e98
 type=image
 tab=type
 short=1
 filePostName=async-upload
 fileTypes=*.jpg;*.jpeg;*.png;*.gif;*.pdf;*.doc;*.ppt;*.odt;*.pptx;*.docx
 fileTypesDescription=All Files
 fileSizeLimit=1536000000b
 fileUploadLimit=0
 fileQueueLimit=0
 debugEnabled=false
 buttonImageURL=http://..../wp-includes/images/upload.png
 buttonWidth=132
 buttonHeight=23
 buttonText=<span class="button">Select Files</span>
 buttonTextTopPadding=3
 buttonTextLeftPadding=0
 buttonTextStyle=.button { text-align: center; font-weight: bold; font-
 family:"Lucida Grande",Verdana,Arial,"Bitstream Vera Sans",sans-serif;
 font-size: 11px; text-shadow: 0 1px 0 #FFFFFF; color:#464646; }
 buttonAction=-110
 buttonDisabled=false
 buttonCursor=-1
 }}}

 To solve this problem, an idea would be to offer sizes (this 132 width and
 maybe something bigger like 198 that offers more space - isn't there this
 1.5 rule in translation?).

 RTL considerations might apply as well, but I only write it here, that has
 not been raised in this ticket. I do not know if flash supports RTL text.

 At least the problem with size should be easy to solve.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/8461#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software