[wp-trac] [WordPress Trac] #13418: Smaller Bits of Code Improvement

[WordPress Trac]

#13418: Smaller Bits of Code Improvement
--------------------------+-------------------------------------------------
 Reporter:  hakre         |       Owner:            
     Type:  defect (bug)  |      Status:  new       
 Priority:  normal        |   Milestone:  Unassigned
Component:  General       |     Version:  3.0       
 Severity:  normal        |    Keywords:  has-patch 
--------------------------+-------------------------------------------------

Comment(by Denis-de-Bernardy):

 I don't mean to stir a knife in a healing wound, but I'm still in awe at
 how much of a confrontation went on in #13317; just to get a couple of
 minor bits of code into WP... In many ways, I got the impression of
 watching a house wife telling her husband to get lost because the latter
 was try to show her how to do a household chore in a slightly more
 productive manner.

 That "we've more important things to do at the moment" is, I think,
 unsatisfying. When in alpha, the argument is that we're adding features
 and fixing critical bugs that crept into the last release; when in
 beta/RC, the argument becomes that we're fixing important bugs in order to
 meet an artificial deadline. In the end, it's never time to take care of
 small bugs and improvements; and yet, there are so many to look into...
 OK, I'll stop; I'm beating a dead horse.

 Still, 13418.patch doesn't change a thing as far as the logic is
 concerned. It merely rewrites a messy looking code block into something
 that looks tidy. I've no idea what should keep it from getting checked in.

 Both of these tickets, in my opinion, break down to two yes|no questions:
 does it change any logic? If not, commit. If so, does the change that
 crept in make any sense (e.g. does it make sense to drop negative page
 numbers or font sizes)? If so, commit; if not, ask. End of story.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13418#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software