[wp-trac] [WordPress Trac] #13357: I18n for taxonomy labels

[WordPress Trac]

#13357: I18n for taxonomy labels
--------------------------+-------------------------------------------------
 Reporter:  nbachiyski    |       Owner:  nbachiyski      
     Type:  defect (bug)  |      Status:  assigned        
 Priority:  normal        |   Milestone:  3.0             
Component:  i18n          |     Version:                  
 Severity:  blocker       |    Keywords:  has-patch commit
--------------------------+-------------------------------------------------
Changes (by nacin):

  * keywords:  has-patch dev-feedback => has-patch commit
  * status:  accepted => assigned


Comment:

 Looks good overall.

 I would call $ptype->label->parent_item something like parent_page_colon
 instead, just to better match the string and also to pair it with
 parent_item_colon on the taxonomy side.

 Also, and I imagine this may be the same for post types in this patch, we
 need to ensure that label and singular_label still work. If those are set,
 they need to be used inside the labels object. I imagine that
 singular_label should inherit a value from label as long as the latter is
 set.

 For taxonomies especially, label has existed since 2.5. we added
 singular_label to both, so if we want to eliminate that now (like I did
 with the capabilities, added now), then we should do so. Otherwise, you
 know as well as I do that we won't end up removing these in 3.1 :-)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13357#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software