[wp-trac] [WordPress Trac] #12542: Fix title and h1 elements for Twenty Ten theme

WordPress Trac wp-trac at lists.automattic.com
Mon Mar 29 21:53:08 UTC 2010


#12542: Fix title and h1 elements for Twenty Ten theme
--------------------------+-------------------------------------------------
 Reporter:  mikeschinkel  |        Owner:  iammattthomas
     Type:  defect (bug)  |       Status:  reopened     
 Priority:  normal        |    Milestone:  3.0          
Component:  Themes        |      Version:  3.0          
 Severity:  normal        |   Resolution:               
 Keywords:  has-patch     |  
--------------------------+-------------------------------------------------

Comment(by mikeschinkel):

 Replying to [comment:17 iammattthomas]:
 > Editing themes is ''great.'' As Ian mentioned, hiding the page title in
 a child theme would be incredibly simple.

 You and I are addressing different contexts here.  A designer definitely
 wants to edit a theme.  A user just wants it to work and to be able to
 upgrade to new versions w/o having to re-apply edits.

 Replying to [comment:18 iandstewart]:
 > If you're already making a child theme and editing CSS there (good
 practice!) the simplest solution would be to add the following to your
 child stylesheet:
 >
 > {{{
 > .home .entry-title {display:none;}
 > }}}

 You ''especially'' don't want to hide a heading tag, see what follows:

 From: http://www.mattcutts.com/blog/notifying-webmasters-of-penalties/

 "''Stuey, if display:none is used to hide text, that can cause issues''."

 From: http://railsforum.com/viewtopic.php?id=9657

 "''Matt Cutts from Google has talked about this on his blog and basically
 he says you shouldn't use display:none; to hide content as it is
 considered a form of cloaking as you are showing the user one thing and
 the search engine bot another''."

 From: http://www.mattcutts.com/blog/seo-mistakes-unwise-comments/

 "''I don’t recommend that people use CSS to hide text, and I don’t
 recommend that they document it, either.''"

 Ironically on this same page there is this comment:

 ''Ed September 24, 2008 at 5:19 am
 Here’s my question and concern.
 I use '''Wordpress''' for my website. The newest version has added
 captions to the images and displays the caption. The caption is the same
 text used in the ALT tag as well, so simply not adding it is not an
 option. This new caption messes up my design, so I need it to go away.

 Because this is built in and uses a specific class, '''I am forced to use
 the display:none code in CSS to remove it''', yet the text for the caption
 is still shown, albeit not in H1 tags. However, it is a repetition of the
 ALT tag for the image.''

 > Or, alternately, if you're creating a child theme, adding your own
 custom page template just for the front page. The latter having the added
 bonus of being ''super-cool''.

 I have done that, but only to get rid of the heading. It's painful to see
 all that duplicated code in my front-page heading, code I fear will be
 deprecated by the next refresh of TwentyTen.

 Replying to [comment:16 jane]:
 > Mike, come on. He said: "My feeling is that the power users and theme
 tweakers who edit Twenty Ten '''to craft a new site theme for
 themselves''' can simply add this to the list of other edits they make."
 You then replied: "Editing themes is bad (if it can be avoided.) You edit
 a theme, you own it; no upgrades for you mister!" Since he was, in fact,
 talking about people making their own new themes using 2010 as a base, not
 keeping 2010 as the theme and just overwriting things they don't like, I
 don't think your reply was appropriate.

 Inappropriate?  You're killing me!  I was trying to lighten the discussion
 (i.e. I was joking) but still get the point across. I guess in my germanic
 way it didn't come across.

 > We don't want everyone to just use the default theme, we want them to
 take it and do cool things with it.

 True, but why force them to do duplicate so much code?

 '''''Would it really be so awful to add a few hooks into the theme to
 allow people to address this themselves?'''''

 I'm dying here.  I've come up with three (3) different solutions: 1.)
 change it, 2.) providing admin options and/or 3.) adding in hooks.  None
 of these work for you?

 > The default theme is not meant to be all things to all people. We had a
 huge debate about this long ago and decided the default theme absolutely
 should not try to do address all use cases.

 Agreed.  I'm arguing this is a very common use case for almost any site
 with a static front page. Hardly an outlier.

 The TwentyTen theme is *really* good; but it's 90%. I'm asking to take it
 to the last 10%.

 > It should be a simple BLOG theme, that's what was decided. If at some
 point we decide to pursue something like "core themes" and have a default
 specifically for CMS  or magazine use, etc, then it's a different ball
 game, but 2010 is supposed to be a blog theme, not a big old CMS theme. On
 purpose. If someone wants to use it as a base for a more CMS-oriented
 theme, awesome. That's not the task at hand, though. We need to stick to
 scope on this.

 Sigh. I give up. :-(

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12542#comment:19>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list