[wp-trac] [WordPress Trac] #12519: wp_unregister_GLOBALS violates with specs
WordPress Trac
wp-trac at lists.automattic.com
Sat Mar 6 08:31:57 UTC 2010
#12519: wp_unregister_GLOBALS violates with specs
------------------------------+---------------------------------------------
Reporter: hakre | Owner: dd32
Type: defect (bug) | Status: closed
Priority: lowest | Milestone: 3.0
Component: General | Version: 3.0
Severity: trivial | Resolution: fixed
Keywords: has-patch tested |
------------------------------+---------------------------------------------
Comment(by hakre):
I'm against making exceptions. The function is well named regardless of
it's case. All contributors should be treated equal.
This function is the only exception that I could find in the whole
codebase (!), I see it problematic to show other developers that certain
personal styles of certain developers are preferred for not obvious
reason.
Background info: Function was moved in load.php in r12732. Originally it
was introduce in wp-settings.php as {{{unregister_GLOBALS()}}} in r2784
and renamed in r4203 to it's current name {{{wp_unregister_GLOBALS()}}} to
prevent name collisions with various functions called
{{{unregister_globals()}}} in many other projects.
Changing the case of the function as I suggested has not negative inpact,
only positive.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/12519#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list