[wp-trac] [WordPress Trac] #11771: stripslashes_from_options() prevents plugins from storing a site name with a slash?

WordPress Trac wp-trac at lists.automattic.com
Sat Mar 6 01:41:00 UTC 2010


#11771: stripslashes_from_options() prevents plugins from storing a site name with
a slash?
-------------------------------+--------------------------------------------
 Reporter:  Denis-de-Bernardy  |        Owner:          
     Type:  defect (bug)       |       Status:  reopened
 Priority:  normal             |    Milestone:  3.0     
Component:  Multisite          |      Version:  3.0     
 Severity:  critical           |   Resolution:          
 Keywords:  blocker            |  
-------------------------------+--------------------------------------------

Comment(by Denis-de-Bernardy):

 Replying to [comment:6 wpmuguru]:
 > Here is the original MU ticket: http://trac.mu.wordpress.org/ticket/974.
 The patch noted on the ticket addressed the issue as far as ms-options.php
 & ms-edit.php is concerned. The stripslashes_from options function was
 added so that on upgrade any residual ones would be removed.

 As far as SVN blame is concerned, it got introduced here:

 http://trac.mu.wordpress.org/changeset/2005

 If you WPMU truly was inserting extra slashes at one point, either:

  - we decide it's old enough (I take it that 9 months is old, for a well-
 maintained WPMU site?), and the rare users who might have (unknowingly?)
 run into it have upgraded by now, so it's safe to remove it entirely; or
  - we want to keep it around for the same, rare, old-time WPMU users, in
 which case it should be conditionally applied -- if and only if db_version
 is below a certain number, etc.

 Either way, this should not be left into WP as is.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11771#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list