[wp-trac] [WordPress Trac] #12130: Add Donate URI plugin header
WordPress Trac
wp-trac at lists.automattic.com
Mon Mar 1 22:10:34 UTC 2010
#12130: Add Donate URI plugin header
------------------------------+---------------------------------------------
Reporter: Otto42 | Owner: westi
Type: enhancement | Status: reopened
Priority: low | Milestone: 3.0
Component: Plugins | Version:
Severity: trivial | Resolution:
Keywords: has-patch commit |
------------------------------+---------------------------------------------
Comment(by Denis-de-Bernardy):
k... I've massaged it a bit more. in 12130.4.diff:
- added an extra argument to get_file_data(), allowing to set the max
amount of file read (1kb is probably way more than needed, and the same
holds for themes)
- there's a hook in get_file_data that allows to override the size.
namely to zero, in which case it bails and returns the default headers.
can we say everyone is now happy with the approach? if so, @otto - be so
kind to give it a whirl, including the parts you don't like/agree with.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/12130#comment:38>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list