[wp-trac] Re: [WordPress Trac] #8568: Plugin activation hook should not be run when scraping errors.

[WordPress Trac]

#8568: Plugin activation hook should not be run when scraping errors.
------------------------------------------------------+---------------------
 Reporter:  sambauers                                 |        Owner:  anonymous
     Type:  defect (bug)                              |       Status:  new      
 Priority:  normal                                    |    Milestone:  2.7.1    
Component:  Administration                            |      Version:  2.7      
 Severity:  normal                                    |   Resolution:           
 Keywords:  has-patch dev-feedback reporter-feedback  |  
------------------------------------------------------+---------------------
Comment (by hakre):

 It is a recommended practise to place Upgrade, Cleanup, Install-Checks
 etc. _in_ the Activation Hook [http://funcdoc.wordpress.com/2008/01/08
 /writing-plugins-activation-and-deactivation/ 1].

 The Request in Question is 'error_scrape'. I can not find a clear
 description what this means and for what the code is intended for.

 As long as it remains unclear wether or not the plugin shouldn't be
 actived through 'error_scrape', the code should remain as it is and an
 additional Hook should not be called.

 Anyway, I adopt the criticism in this patch partly: It is simply unclear
 what should happen here. Is the Plugin Activated anyway afterwards or is
 this a Test _only_?

 What about creating an additional Testdrive Process that is run only on
 Activation?

-- 
Ticket URL: <http://trac.wordpress.org/ticket/8568#comment:7>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software