[wp-trac] Re: [WordPress Trac] #8973: Function get_page_of_comment() returns incorrect page numbers -- fix included

WordPress Trac wp-trac at lists.automattic.com
Thu Jan 29 16:27:57 GMT 2009


#8973: Function get_page_of_comment() returns incorrect page numbers -- fix
included
------------------------------+---------------------------------------------
 Reporter:  GregMulhauser     |        Owner:          
     Type:  defect (bug)      |       Status:  reopened
 Priority:  normal            |    Milestone:  2.8     
Component:  Comments          |      Version:  2.7     
 Severity:  normal            |   Resolution:          
 Keywords:  comments, paging  |  
------------------------------+---------------------------------------------
Comment (by GregMulhauser):

 I think ryan and mrmist are both right.

 Related to this (not sure whether this merits a separate submission?), I
 think it would be helpful if those functions which call on
 get_page_of_comments could get an indication back as to whether a value of
 1 indicates the same page of comments as that included at the post's
 permalink or whether it indicates a completely different page of comments
 (as will happen when there is more than one page, and comments are
 displayed in reverse order).

 As the function operates at the moment, folks with reverse-ordered
 comments wind up with a lot of extraneous "comment-page-1" URLs for
 individual comments when they could just have links to the main post
 instead.

 All the best,
 Greg

-- 
Ticket URL: <http://trac.wordpress.org/ticket/8973#comment:7>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list