[wp-trac] Re: [WordPress Trac] #8568: Plugin activation hook should
not be run when scraping errors.
WordPress Trac
wp-trac at lists.automattic.com
Tue Jan 20 21:13:06 GMT 2009
#8568: Plugin activation hook should not be run when scraping errors.
------------------------------------------------------+---------------------
Reporter: sambauers | Owner: anonymous
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.7.1
Component: Administration | Version: 2.7
Severity: normal | Resolution:
Keywords: has-patch dev-feedback reporter-feedback |
------------------------------------------------------+---------------------
Comment (by Denis-de-Bernardy):
I disagree.
Suppose a plugin creates a table or adds a field on activate, and removes
it on deactivate. Then the wp error checking code will run activate, and
activate will run once again upon getting "truly" activated. For this
reason, if activate gets run, deactivate should get run as well.
Then, picture a plugin with a fatal error in the deactivation code.
clearly that area of the code should be tested as well.
--
Ticket URL: <http://trac.wordpress.org/ticket/8568#comment:6>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list