[wp-trac] [WordPress Trac] #8851: invalid XHTML markup in get_search_form function in general-template.php

WordPress Trac wp-trac at lists.automattic.com
Tue Jan 13 22:25:47 GMT 2009


#8851: invalid XHTML markup in get_search_form function in general-template.php
--------------------------+-------------------------------------------------
 Reporter:  jcraig90210   |       Owner:  anonymous
     Type:  defect (bug)  |      Status:  new      
 Priority:  normal        |   Milestone:  2.8      
Component:  General       |     Version:           
 Severity:  normal        |    Keywords:           
--------------------------+-------------------------------------------------
 '''Old function:'''

 function get_search_form() {
         do_action( 'get_search_form' );

         if ( '' != locate_template(array('searchform.php'), true) )
                 return;

         $form = '<form method="get" id="searchform" action="' .
 get_option('home') . '/" >
         <label class="hidden" for="s">' . __('Search') . '</label>
         <div><input type="text" value="' .
 attribute_escape(apply_filters('the_search_query', get_search_query())) .
 '" name="s" id="s" />
         <input type="submit" id="searchsubmit"
 value="'.attribute_escape(__('Search')).'" />
         </div>
         </form>';

         echo apply_filters('get_search_form', $form);
 }


 '''New Function:'''

 function get_search_form() {
         do_action( 'get_search_form' );

         if ( '' != locate_template(array('searchform.php'), true) )
                 return;

         $form = '<form method="get" id="searchform" action="' .
 get_option('home') . '/" >
         <div><label class="hidden" for="s">' . __('Search') . '</label>
         <input type="text" value="' .
 attribute_escape(apply_filters('the_search_query', get_search_query())) .
 '" name="s" id="s" />
         <input type="submit" id="searchsubmit"
 value="'.attribute_escape(__('Search')).'" />
         </div>
         </form>';

         echo apply_filters('get_search_form', $form);
 }

-- 
Ticket URL: <http://trac.wordpress.org/ticket/8851>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list