[wp-trac] Re: [WordPress Trac] #9243: wp_enqueue_script shouldn't convert source URL ampersands to character entities

WordPress Trac wp-trac at lists.automattic.com
Sat Feb 28 00:29:27 GMT 2009


#9243: wp_enqueue_script shouldn't convert source URL ampersands to character
entities
--------------------------+-------------------------------------------------
 Reporter:  filosofo      |       Owner:  ryan                                 
     Type:  defect (bug)  |      Status:  new                                  
 Priority:  normal        |   Milestone:  Unassigned                           
Component:  General       |     Version:  2.8                                  
 Severity:  normal        |    Keywords:  wp_enqueue_script clean_url has-patch
--------------------------+-------------------------------------------------

Comment(by sivel):

 I do not think this should be done.  Not encoding the ampersands will
 break xhtml validation and I have tested that it does indeed works as
 expected while encoded.

 From my email to wp-hackers:

 Okay, I put together a quick plugin to prove to myself that either the
 use of & does work or does not work.  In short I found that it
 *does* work.

 I'll even provide my plugin code so that anyone else who wants can test
 it.

 The code can be found at http://gist.github.com/71796.txt

 Save this as a .php file and place in your plugins directory.  Once
 activated navigate to your blog and you should see a javascript alert
 that either says 'IT WORKED!' or 'IT DIDN'T WORK!" followed by some
 extra data.  It won't do the alert in the admin as I figured it might
 be annoying to try to deal with the alert while activating and
 deactivating.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9243#comment:1>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list