From wp-trac at lists.automattic.com Thu Nov 1 01:06:31 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 01:06:50 2007
Subject: [wp-trac] [WordPress Trac] #5299: JS/AJAX form validation
Message-ID: <046.999fc440967d0a830ebc6e91a0b42aa0@lists.automattic.com>
#5299: JS/AJAX form validation
----------------------+-----------------------------------------------------
Reporter: mdawaffe | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Keywords:
----------------------+-----------------------------------------------------
Due to the new jQuery list manipulation code, there are a few forms in WP
that, when submitted with no data (e.g. with a stray click or return),
respond with "AJAX is teh b0rked".
That's a error message not meant to be seen by users :)
Currently, the jQuery wp-lists JS offers a few hooks where custom, per-
form JS can be written to do arbitrary form validation and to prevent bad
submissions. But repeating for each form "don't bother to submit if the
form is empty. Display feedback as necessary instead" is obnoxious.
Also, WP can already do arbitrary form validation using the WP_Error class
(witness the Add User form), but could be touched up a bit to give better
feedback.
Proposed :
1. Via JS: If a form element is empty and has some ancestor element with
class "required", that ancestor element gets a new "invalid" class and the
form is not submitted. Rationale: We know right away something is wrong,
so we give feedback without having to send a request to the server.
2. Via AJAX: If a WP_Error object is returned in the AJAX response (via
the WP_Ajax_Response class), match up the error codes with the form
elements and give a new "invalid" class to the first ancestor element with
class "form-field" for each of those matching form elements. Also
display the error messages as we currently do. Rationale: Since we can't
know client side that the data is valid (without writing a lot of extra
JS), we submit via AJAX and give feedback based on any WP_Error objects.
Example :
{{{
}}}
If a user tries to submit an empty form, the first TR will immediately
gets the "invalid" class and the form is not submitted. Why? It has the
"required" class and one of it's descendants is an empty form element.
If the user enters a "Shirley" into the name field and "young" in the age
field and submits, suppose a WP_Error object is returned:
{{{
object(wp_error)(2) {
["errors"]=>
array(1) {
["age"]=>
array(1) {
[0]=>
string(31) "You must give your age in years"
}
}
["error_data"]=>
array(0) {
}
}
}}}
The TR with the age field in it is given the "invalid class" and the error
message is shown. Why? Because the returned WP_Error object contains an
error with code "age".
So we'd have 3 methods of form validation.
1. Current hooks in wp-lists JS that allow submission to be
canceled/relegated to traditional (non-AJAX) request.
2. Looking for blank inputs in elements with the "required" class.
3. Interpreting WP_Error objects sent back in the AJAX response.
Attached :
1. Implements proposal.
2. Uses method 1 (current hooks) to prevent submission of blank on-the-
fly AJAX category adding to posts on the Write screen.
3. Uses methods 2 (required) and 3 (WP_Error) in concert to validate
other AJAX based forms: Category adding from Manage -> Categories and
Blogroll -> Categories, User adding from Users.
To Test :
1. Hit enter in a blank Add New User form. Name, email, password should
turn red.
2. Enter " " as name, " " as email, "1" as password 1, "2" as password 2
in Add New User form. Submit. Fields should turn red, and detailed
explanations are given.
3. Hit enter in blank ajax-cat form on Write -> Post screen. Nothing
should happen.
4. Enter "{{{,,}}}" (three blank categories) into ajax-cat form. Submit.
Request is actually submitted, but nothing will happen server side (good),
and nothing will happen after response comes through (good).
5. Submit blank Add New Category form (Manage -> Categories). Name
should turn red.
6. Enter " " as name in Add New Category form. Submit. Name should turn
red, should get error message.
7. Repeat 5, 6 for Blogroll -> Categories form.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 02:11:28 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 02:11:35 2007
Subject: [wp-trac] Re: [WordPress Trac] #5300: User registration time not
being saved
In-Reply-To: <046.18c6385c95dfbc9a96b98cc5a1c8f77d@lists.automattic.com>
References: <046.18c6385c95dfbc9a96b98cc5a1c8f77d@lists.automattic.com>
Message-ID: <055.77c70a5bcd24027cf90a1e9ebc8d4aff@lists.automattic.com>
#5300: User registration time not being saved
------------------------------+---------------------------------------------
Reporter: mdawaffe | Owner: mdawaffe
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch commit |
------------------------------+---------------------------------------------
Changes (by mdawaffe):
* keywords: => has-patch commit
* owner: anonymous => mdawaffe
* status: new => assigned
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 02:47:38 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 02:47:45 2007
Subject: [wp-trac] Re: [WordPress Trac] #5298: https atom service document
doesn't point to https collections
In-Reply-To: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
References: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
Message-ID: <052.675c522388764424292a6337a42dd239@lists.automattic.com>
#5298: https atom service document doesn't point to https collections
---------------------+------------------------------------------------------
Reporter: rubys | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
---------------------+------------------------------------------------------
Changes (by josephscott):
* cc: josephscott (added)
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 03:36:03 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 03:36:09 2007
Subject: [wp-trac] Re: [WordPress Trac] #5298: https atom service document
doesn't point to https collections
In-Reply-To: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
References: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
Message-ID: <052.b95dd7267ccdcd20c6995c62037c9399@lists.automattic.com>
#5298: https atom service document doesn't point to https collections
-----------------------+----------------------------------------------------
Reporter: rubys | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: has-patch |
-----------------------+----------------------------------------------------
Changes (by foolswisdom):
* keywords: => has-patch
* version: => 2.3.1
* milestone: 2.5 => 2.4
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 03:37:07 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 03:37:14 2007
Subject: [wp-trac] Re: [WordPress Trac] #5296: "Login" used in place of "Log
In" (Grammar error)
In-Reply-To: <042.d2b6e8fa3876080cd875e6449d711dbb@lists.automattic.com>
References: <042.d2b6e8fa3876080cd875e6449d711dbb@lists.automattic.com>
Message-ID: <051.f49c5780bb818c972f60bd9f6216580d@lists.automattic.com>
#5296: "Login" used in place of "Log In" (Grammar error)
-------------------------+--------------------------------------------------
Reporter: doug | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.5
Component: Template | Version:
Severity: minor | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by Viper007Bond):
http://dictionary.reference.com/search?q=login
A perfectly valid usage of the word.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 04:43:25 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 04:43:30 2007
Subject: [wp-trac] Re: [WordPress Trac] #5296: "Login" used in place of "Log
In" (Grammar error)
In-Reply-To: <042.d2b6e8fa3876080cd875e6449d711dbb@lists.automattic.com>
References: <042.d2b6e8fa3876080cd875e6449d711dbb@lists.automattic.com>
Message-ID: <051.426adacaf0697b58e47357731f9b69be@lists.automattic.com>
#5296: "Login" used in place of "Log In" (Grammar error)
-------------------------+--------------------------------------------------
Reporter: doug | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: Template | Version: 2.3
Severity: minor | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by Viper007Bond):
I disagree. I think it is correct how it is now. "Login" isn't a
mispelling of "log in", it's a completely different word and being
properly used in this case IMO.
Okay, so may not be the King's English or Oxford English or whatever (it's
debatable), but in terms of the Internet, I think it's correct how it is
and I'm strongly opposed to changing it.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 04:55:24 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 04:55:30 2007
Subject: [wp-trac] Re: [WordPress Trac] #5296: "Login" used in place of "Log
In" (Grammar error)
In-Reply-To: <042.d2b6e8fa3876080cd875e6449d711dbb@lists.automattic.com>
References: <042.d2b6e8fa3876080cd875e6449d711dbb@lists.automattic.com>
Message-ID: <051.fa5d009b885a81b92cdb4deab31d8a02@lists.automattic.com>
#5296: "Login" used in place of "Log In" (Grammar error)
-------------------------+--------------------------------------------------
Reporter: doug | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: Template | Version: 2.3
Severity: minor | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by foolswisdom):
No point in arguing with you then.
http://www.nytimes.com/
https://www.paypal.com/
http://www.basecamphq.com/
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 05:08:59 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 05:09:04 2007
Subject: [wp-trac] Re: [WordPress Trac] #5296: "Login" used in place of "Log
In" (Grammar error)
In-Reply-To: <042.d2b6e8fa3876080cd875e6449d711dbb@lists.automattic.com>
References: <042.d2b6e8fa3876080cd875e6449d711dbb@lists.automattic.com>
Message-ID: <051.a9e363c8e904043e9f55c1b0a1cd8ead@lists.automattic.com>
#5296: "Login" used in place of "Log In" (Grammar error)
-------------------------+--------------------------------------------------
Reporter: doug | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: Template | Version: 2.3
Severity: minor | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by Viper007Bond):
Hmm. Then why does PayPal have "Account login"?
Don't get me wrong, I get what you guys are saying, but it just seems
"wrong". It would make sense for the button on the form to say "log in" as
that's what you are doing -- logging in, but the link on the homepage is
taking you to the "login form" and clicking it isn't logging you in.
Or at least that's what make sense to my non-English teacher self.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 05:16:56 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 05:17:01 2007
Subject: [wp-trac] [WordPress Trac] #5301: WordPress can "leak" if a
username is valid
Message-ID: <050.869abd700cbf812902cbafd7590ddff0@lists.automattic.com>
#5301: WordPress can "leak" if a username is valid
----------------------------+-----------------------------------------------
Reporter: Viper007Bond | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.3.2
Component: Administration | Version: 2.3
Severity: normal | Keywords: has-patch
----------------------------+-----------------------------------------------
When you enter a valid username but an invalid password, WordPress lets
you know the username is valid by complaining that only the password is
invalid.
Attached patch combines the two error messages so that if either the
username or the password is wrong, it says the same error message which
gives less away.
Makes it harder for a hacker to gain access to a blog.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 05:21:56 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 05:22:01 2007
Subject: [wp-trac] Re: [WordPress Trac] #5301: WordPress can "leak" if a
username is valid
In-Reply-To: <050.869abd700cbf812902cbafd7590ddff0@lists.automattic.com>
References: <050.869abd700cbf812902cbafd7590ddff0@lists.automattic.com>
Message-ID: <059.11318d9c72b31561a4c840ec4f873bcd@lists.automattic.com>
#5301: WordPress can "leak" if a username is valid
----------------------------+-----------------------------------------------
Reporter: Viper007Bond | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.3.2
Component: Administration | Version: 2.3
Severity: normal | Resolution:
Keywords: has-patch |
----------------------------+-----------------------------------------------
Comment (by Viper007Bond):
Oh, props to http://dougal.gunters.org/blog/2007/10/30/securing-wordpress
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 05:35:36 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 05:35:43 2007
Subject: [wp-trac] Re: [WordPress Trac] #5300: User registration time not
being saved
In-Reply-To: <046.18c6385c95dfbc9a96b98cc5a1c8f77d@lists.automattic.com>
References: <046.18c6385c95dfbc9a96b98cc5a1c8f77d@lists.automattic.com>
Message-ID: <055.8b47fc4dc41e2fea7975927743cf915d@lists.automattic.com>
#5300: User registration time not being saved
------------------------------+---------------------------------------------
Reporter: mdawaffe | Owner: mdawaffe
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch commit |
------------------------------+---------------------------------------------
Comment (by ryan):
Lines 150 and 151 of admin-ajax.php have a syntax error. 150 is missing a
semi-colon and 151 seems out-of-place. I removed 151 and put a semi on
150 and everything worked as described. Big ++.
We need to return WP_Error from more of the functions used in admin-
ajax.php. Some of them still return 0 for back compat reasons. We could
add an arg to them that allows the caller to request WP_Error return.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 05:38:22 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 05:38:29 2007
Subject: [wp-trac] Re: [WordPress Trac] #5299: JS/AJAX form validation
In-Reply-To: <046.999fc440967d0a830ebc6e91a0b42aa0@lists.automattic.com>
References: <046.999fc440967d0a830ebc6e91a0b42aa0@lists.automattic.com>
Message-ID: <055.e0d46c7ccb1ee500049ad5c0d7fa1c85@lists.automattic.com>
#5299: JS/AJAX form validation
----------------------+-----------------------------------------------------
Reporter: mdawaffe | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
----------------------+-----------------------------------------------------
Comment (by ryan):
Lines 150 and 151 of admin-ajax.php have a syntax error. 150 is missing a
semi-colon and 151 seems out-of-place. I removed 151 and put a semi on 150
and everything worked as described. Big ++.
We need to return WP_Error from more of the functions used in admin-
ajax.php. Some of them still return 0 for back compat reasons. We could
add an arg to them that allows the caller to request WP_Error return.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 05:43:24 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 05:43:31 2007
Subject: [wp-trac] Re: [WordPress Trac] #5301: WordPress can "leak" if a
username is valid
In-Reply-To: <050.869abd700cbf812902cbafd7590ddff0@lists.automattic.com>
References: <050.869abd700cbf812902cbafd7590ddff0@lists.automattic.com>
Message-ID: <059.842321307597adda40ad86c6b646b35e@lists.automattic.com>
#5301: WordPress can "leak" if a username is valid
----------------------------+-----------------------------------------------
Reporter: Viper007Bond | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: Administration | Version: 2.3.1
Severity: normal | Resolution:
Keywords: has-patch |
----------------------------+-----------------------------------------------
Changes (by foolswisdom):
* version: 2.3 => 2.3.1
* milestone: 2.3.2 => 2.5
Comment:
False security? #3708 , #4290 .
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 05:44:48 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 05:44:57 2007
Subject: [wp-trac] Re: [WordPress Trac] #5299: JS/AJAX form validation
In-Reply-To: <046.999fc440967d0a830ebc6e91a0b42aa0@lists.automattic.com>
References: <046.999fc440967d0a830ebc6e91a0b42aa0@lists.automattic.com>
Message-ID: <055.1f4450640b1f89ac272deea0132a5d3d@lists.automattic.com>
#5299: JS/AJAX form validation
-----------------------------------+----------------------------------------
Reporter: mdawaffe | Owner: mdawaffe
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion |
-----------------------------------+----------------------------------------
Changes (by mdawaffe):
* keywords: => has-patch 2nd-opinion
* owner: anonymous => mdawaffe
* status: new => assigned
Comment:
5299b.diff
1. Fixes syntax error on line 150.
2. Line 151 is kept. It skips the addition of a category if it's name is
{{{''}}}.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 05:49:33 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 05:49:44 2007
Subject: [wp-trac] Re: [WordPress Trac] #5299: JS/AJAX form validation
In-Reply-To: <046.999fc440967d0a830ebc6e91a0b42aa0@lists.automattic.com>
References: <046.999fc440967d0a830ebc6e91a0b42aa0@lists.automattic.com>
Message-ID: <055.0df590f68599823e73176442e8cbf5a9@lists.automattic.com>
#5299: JS/AJAX form validation
-----------------------------------+----------------------------------------
Reporter: mdawaffe | Owner: mdawaffe
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion |
-----------------------------------+----------------------------------------
Comment (by mdawaffe):
While they're up for grabs, what do people think about the class names?
{{{
invalid = some input in this box is no good
form-field = this box contains some inputs (that might end up being
invalid)
required = this box contains required inputs
}}}
Should we standardize them?
{{{
form-invalid
form-field
form-required
input-invalid
input-field / input-holder
input-required
}}}
I guess I like the {{{form-}}} prefixed variants the best.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 05:51:23 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 05:51:28 2007
Subject: [wp-trac] Re: [WordPress Trac] #5299: JS/AJAX form validation
In-Reply-To: <046.999fc440967d0a830ebc6e91a0b42aa0@lists.automattic.com>
References: <046.999fc440967d0a830ebc6e91a0b42aa0@lists.automattic.com>
Message-ID: <055.d4d7eded6449dbcaa79c840f147ab09f@lists.automattic.com>
#5299: JS/AJAX form validation
-----------------------------------+----------------------------------------
Reporter: mdawaffe | Owner: mdawaffe
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion |
-----------------------------------+----------------------------------------
Comment (by ryan):
Prefixed ones sound good to me.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 05:55:09 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 05:55:15 2007
Subject: [wp-trac] Re: [WordPress Trac] #5301: WordPress can "leak" if a
username is valid
In-Reply-To: <050.869abd700cbf812902cbafd7590ddff0@lists.automattic.com>
References: <050.869abd700cbf812902cbafd7590ddff0@lists.automattic.com>
Message-ID: <059.7f4010b14e24e3d06ad5be8ed0d8e1f7@lists.automattic.com>
#5301: WordPress can "leak" if a username is valid
----------------------------+-----------------------------------------------
Reporter: Viper007Bond | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: Administration | Version: 2.3.1
Severity: normal | Resolution:
Keywords: has-patch |
----------------------------+-----------------------------------------------
Comment (by Viper007Bond):
Son of a... I knew I shoulda searched. That's what I get for being lazy.
As mentioned in #3708, a username can still be found via alternate methods
in some cases.
But yeah, it doesn't stop things in the end, but why provide a username
validator when we don't have to? This patch obviously won't stop a
determined hacker, but just may make their life slightly harder in some
cases.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 06:08:13 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 06:08:18 2007
Subject: [wp-trac] Re: [WordPress Trac] #5299: JS/AJAX form validation
In-Reply-To: <046.999fc440967d0a830ebc6e91a0b42aa0@lists.automattic.com>
References: <046.999fc440967d0a830ebc6e91a0b42aa0@lists.automattic.com>
Message-ID: <055.572978423b4fd9bffb3deaf421e6b5ab@lists.automattic.com>
#5299: JS/AJAX form validation
-----------------------------------+----------------------------------------
Reporter: mdawaffe | Owner: mdawaffe
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion |
-----------------------------------+----------------------------------------
Comment (by mdawaffe):
5299c.diff
1. {{{form-}}} prefixed classes.
2. Fix line 151 for realies. Thanks rboren :)
3. Bug in on the fly link category addition.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 06:55:57 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 06:56:04 2007
Subject: [wp-trac] [WordPress Trac] #5302: upload breaks
Message-ID: <045.d1aa516b04e2f4cdb3261d972b202c9e@lists.automattic.com>
#5302: upload breaks
---------------------+------------------------------------------------------
Reporter: pizzamx | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version: 2.4
Severity: normal | Keywords: upload sql
---------------------+------------------------------------------------------
Upload function breaks when creating a new post or editing an existing
post. The file *did* get uploaded, and the problem occurs when trying to
modify the database:
{{{
WordPress database error: [You have an error in your SQL syntax; check the
manual that corresponds to your MySQL server version for the right syntax
to use near
'WHERE ID = '3' LIMIT 1' at line 1]
UPDATE wp2_posts SET WHERE ID = '3' LIMIT 1
}}}
ps., tested on a fresh copy checked out from trunk
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 07:22:36 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 07:25:06 2007
Subject: [wp-trac] [WordPress Trac] #5303: "Manage > Pages" becomes very
slow with hundreds of pages
Message-ID: <047.a53bb4764248dfb894898e1eb6836e14@lists.automattic.com>
#5303: "Manage > Pages" becomes very slow with hundreds of pages
-----------------------+----------------------------------------------------
Reporter: MartijnD | Owner: anonymous
Type: task | Status: new
Priority: low | Milestone: 2.5
Component: General | Version:
Severity: normal | Keywords:
-----------------------+----------------------------------------------------
Apologies if this has been mentioned before, I couldn't find a relevant
related bug.
I am currently building a prototype blog / content site that has several
hundreds of "Pages"; and things have slown down a lot. With just over 250
pages, generation of "Manage > Pages" takes over 30 seconds, which causes
PHP time out errors on the server.
Some profiling shows that most time is spend in:
\wp-admin\includes\template.php
166: function page_rows()
The code for hierarchal display is very inefficient, as it loops over and
over the full set of posts to check if a post and a parent are related.
180: if ( $hierarchy && ($post->post_parent != $parent) )
181: continue;
Forcing $hierachy to false reduces the page creation time to 7-8 seconds.
Still not great, it should be possible to do this in < 2 seconds.
Please take this as suggestion for improvement.
If I have time, I will look into finding a more efficient piece of code --
for now I still have a couple more pages to add ;-)
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 07:58:17 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 07:58:24 2007
Subject: [wp-trac] Re: [WordPress Trac] #5276: Allow wp-config.php to be
used without including wp-settings.php
In-Reply-To: <048.87bfd68531c072d8e2ddfa929c5d04ae@lists.automattic.com>
References: <048.87bfd68531c072d8e2ddfa929c5d04ae@lists.automattic.com>
Message-ID: <057.3f17cc119d588200f9f9f574622617c6@lists.automattic.com>
#5276: Allow wp-config.php to be used without including wp-settings.php
--------------------------------------+-------------------------------------
Reporter: mastermind | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.4
Severity: normal | Resolution:
Keywords: wp-config.php standalone |
--------------------------------------+-------------------------------------
Comment (by DD32):
> we can't change wp-config.php easily.
Very true, However, Luckely at present its a require_once statement.
I'll suggest another method, add {{{ require_once( dirname(__FILE__) .
'/wp-settings.php'); }}} to wp-blog-header.php and remove it from the
default sample wp-config.php.
If users still have the line in their wp-config.php, then it'll still work
as expected, However, it'll mean that users can make their wp-config.php a
stand alone file if a plugin requires it. (Who knows, If it was mentioned
in a announcement, come a few releases down the track, it might be safe to
assume that its no longer included).
It means it wont be useful in the immediate future, but overtime it'll
become available.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 08:02:24 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 08:02:28 2007
Subject: [wp-trac] Re: [WordPress Trac] #5276: Allow wp-config.php to be
used without including wp-settings.php
In-Reply-To: <048.87bfd68531c072d8e2ddfa929c5d04ae@lists.automattic.com>
References: <048.87bfd68531c072d8e2ddfa929c5d04ae@lists.automattic.com>
Message-ID: <057.e18099cf435f73f203df197839bbec32@lists.automattic.com>
#5276: Allow wp-config.php to be used without including wp-settings.php
--------------------------------------+-------------------------------------
Reporter: mastermind | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.4
Severity: normal | Resolution:
Keywords: wp-config.php standalone |
--------------------------------------+-------------------------------------
Comment (by DD32):
Hm, Just noticed removing that line from wp-config breaks other parts of
WP.
What should WP be including to kick-start itself? {{{wp-config.php}}} or
{{{wp-blog-header.php}}} ?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 08:13:05 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 08:13:10 2007
Subject: [wp-trac] Re: [WordPress Trac] #5218: SAVEQUERIES: log calling
function name
In-Reply-To: <048.658e870a76381bb7f849fb8c96e4f26a@lists.automattic.com>
References: <048.658e870a76381bb7f849fb8c96e4f26a@lists.automattic.com>
Message-ID: <057.8598e8677658aa934a44a1442e088e36@lists.automattic.com>
#5218: SAVEQUERIES: log calling function name
-------------------------+--------------------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+--------------------------------------------------
Comment (by DD32):
Another place which this would be useful is the SQL Errors, It'd be nice
for the SQL error messages to include the function which is running the
failing SQL.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 08:16:19 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 08:16:25 2007
Subject: [wp-trac] Re: [WordPress Trac] #5261: Array issues in plugins.php
In-Reply-To: <050.881ca25f5bcc91a94d201933b40a7a86@lists.automattic.com>
References: <050.881ca25f5bcc91a94d201933b40a7a86@lists.automattic.com>
Message-ID: <059.6d3358741f38492f2454ea239a7bb7c1@lists.automattic.com>
#5261: Array issues in plugins.php
--------------------------+-------------------------------------------------
Reporter: aroundmyroom | Owner: anonymous
Type: defect | Status: new
Priority: high | Milestone: 2.3.2
Component: General | Version: 2.3
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+-------------------------------------------------
Comment (by aroundmyroom):
Version 2.3.1-RC1 is indeed removing the array issue everywhere
after applying the patch in the plugin.php
I will update my test wordpress with the latest version tonight and check
again.
Replying to [ticket:5261 aroundmyroom]:
> version 2.1.3 is working without any problem, but with the release of
version 2.2.2 there was introduced a bug called: ARRAY bug
> at the support forums you can read this issue from other people as well
> http://wordpress.org/support/topic/118367/page/2
> the solution for 2.2.2. was given by user SEVENETH posting some code to
be changed in the plugin.php
>
> Trying to upgrade from 2.1.3 to 2.3 causes for me a lot of array issues
inside the dashboard and options including the loss of all categories
>
> During my testing for 2.3 and now 2.3.1 I see the same issue
>
> if tracking my test weblog at http://www.aroudmyroom.com/test you also
can see that there does exist an array category made by the system itself
>
> The server is running
> PHP Version 4.3.9
> Apache/2.0.52 (CentOS
>
> in the support forums it seems that the ticket for the array issue was
too easily closed and too easily refered to an necessary update for PHP
and/or ZEND
>
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 08:27:25 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 08:27:31 2007
Subject: [wp-trac] Re: [WordPress Trac] #5302: upload breaks
In-Reply-To: <045.d1aa516b04e2f4cdb3261d972b202c9e@lists.automattic.com>
References: <045.d1aa516b04e2f4cdb3261d972b202c9e@lists.automattic.com>
Message-ID: <054.a3049803c2ea6d290d751ca7ea8976f5@lists.automattic.com>
#5302: upload breaks
----------------------------------+-----------------------------------------
Reporter: pizzamx | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version: 2.4
Severity: normal | Resolution:
Keywords: upload sql has-patch |
----------------------------------+-----------------------------------------
Changes (by DD32):
* keywords: upload sql => upload sql has-patch
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 08:38:13 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 08:38:18 2007
Subject: [wp-trac] [WordPress Trac] #5304: Cannot upload images that are not
Gif/jpeg/png
Message-ID: <042.a730459ee82a73937b32553beabbdfd6@lists.automattic.com>
#5304: Cannot upload images that are not Gif/jpeg/png
----------------------------+-----------------------------------------------
Reporter: DD32 | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: Administration | Version: 2.4
Severity: normal | Keywords:
----------------------------+-----------------------------------------------
An error is raised when uploading non gif/jpeg/png files if PHP reconises
the image type.
An example of this is a BMP file.
wp_create_thumbnail Assumes that the filetype is of the given types, and
fails otherwise.
I've attached a patch which aborts creating the thumbnail if its not a
supported type, But a better patch would be to change the function to use
the IMAGETYPE_XXX constants(Instead of 1,2,3) and to support the full
range of image formats.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 08:48:12 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 08:48:17 2007
Subject: [wp-trac] Re: [WordPress Trac] #5284: Editing & Posting Comments
Causes Errors
In-Reply-To: <043.918501dd08ae32d1a8dcfe924a670c83@lists.automattic.com>
References: <043.918501dd08ae32d1a8dcfe924a670c83@lists.automattic.com>
Message-ID: <052.a3f9e5641a3ab290b44bf455cb9baa62@lists.automattic.com>
#5284: Editing & Posting Comments Causes Errors
---------------------+------------------------------------------------------
Reporter: asiah | Owner: anonymous
Type: defect | Status: closed
Priority: normal | Milestone:
Component: General | Version:
Severity: normal | Resolution: wontfix
Keywords: |
---------------------+------------------------------------------------------
Changes (by Nazgul):
* milestone: 2.5 =>
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 08:48:22 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 08:48:27 2007
Subject: [wp-trac] Re: [WordPress Trac] #5297: Unexpected behavior with
plugins and global variables
In-Reply-To: <048.bc1947e49af00cbffb8a7e06677ef076@lists.automattic.com>
References: <048.bc1947e49af00cbffb8a7e06677ef076@lists.automattic.com>
Message-ID: <057.6a5cfd8809e851354ad6b09dcf1a0874@lists.automattic.com>
#5297: Unexpected behavior with plugins and global variables
----------------------------+-----------------------------------------------
Reporter: PaulButler | Owner: anonymous
Type: defect | Status: closed
Priority: normal | Milestone:
Component: Administration | Version:
Severity: normal | Resolution: invalid
Keywords: |
----------------------------+-----------------------------------------------
Changes (by Nazgul):
* milestone: 2.5 =>
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 08:48:35 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 08:48:40 2007
Subject: [wp-trac] Re: [WordPress Trac] #5289: wp_list_authors doesnt work
with echo=false
In-Reply-To: <045.393a85cad41bc886231d4fdd453cba32@lists.automattic.com>
References: <045.393a85cad41bc886231d4fdd453cba32@lists.automattic.com>
Message-ID: <054.00a0583e9efc4a881904b632465d55b1@lists.automattic.com>
#5289: wp_list_authors doesnt work with echo=false
----------------------+-----------------------------------------------------
Reporter: fgubert | Owner: anonymous
Type: defect | Status: closed
Priority: normal | Milestone:
Component: Template | Version: 2.3.1
Severity: normal | Resolution: invalid
Keywords: |
----------------------+-----------------------------------------------------
Changes (by Nazgul):
* milestone: 2.3.2 =>
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 12:11:36 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 12:11:41 2007
Subject: [wp-trac] Re: [WordPress Trac] #5261: Array issues in plugins.php
In-Reply-To: <050.881ca25f5bcc91a94d201933b40a7a86@lists.automattic.com>
References: <050.881ca25f5bcc91a94d201933b40a7a86@lists.automattic.com>
Message-ID: <059.e1bed2796f4ad23732d413bd5daab33b@lists.automattic.com>
#5261: Array issues in plugins.php
--------------------------+-------------------------------------------------
Reporter: aroundmyroom | Owner: anonymous
Type: defect | Status: new
Priority: high | Milestone: 2.3.2
Component: General | Version: 2.3
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+-------------------------------------------------
Comment (by darkdragon):
Which patch did you use? Mine or the one in the forum?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 12:14:56 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 12:15:04 2007
Subject: [wp-trac] Re: [WordPress Trac] #3686: index page gives 404 when
using non-default permalinks
In-Reply-To: <044.0c764cc373876ee1b2b89bf320cd3e9e@lists.automattic.com>
References: <044.0c764cc373876ee1b2b89bf320cd3e9e@lists.automattic.com>
Message-ID: <053.f0b3f1654e5a658b099636e4f373fb18@lists.automattic.com>
#3686: index page gives 404 when using non-default permalinks
----------------------------------------+-----------------------------------
Reporter: jamesw | Owner: markjaquith
Type: defect | Status: new
Priority: low | Milestone: 2.4
Component: General | Version: 2.1
Severity: normal | Resolution:
Keywords: permalinks pages 404 error |
----------------------------------------+-----------------------------------
Comment (by jamesw):
If it helps anyone diagnose what's wrong, I've set up a PHPInfo page that
should allow those a bit better skilled to see what my potential problem
might be.
http://www.mameworld.net/agemame/test.php
I haven't tried the workaround listed above, as I'm reluctant to change
permalink structures, particularly since I already have issues with
canonical redirects. I'm not posting a ticket for that, though, because
it's probably down to my REQUEST_URI being screwed up.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 13:04:46 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 13:04:51 2007
Subject: [wp-trac] Re: [WordPress Trac] #5296: "Login" used in place of "Log
In" (Grammar error)
In-Reply-To: <042.d2b6e8fa3876080cd875e6449d711dbb@lists.automattic.com>
References: <042.d2b6e8fa3876080cd875e6449d711dbb@lists.automattic.com>
Message-ID: <051.bf17ecdc79b9644dfd1991612ae33bca@lists.automattic.com>
#5296: "Login" used in place of "Log In" (Grammar error)
-------------------------+--------------------------------------------------
Reporter: doug | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: Template | Version: 2.3
Severity: minor | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by doug):
I'm not talking about Oxford English, just English. :) As you say, "log
in" and "login" are different words (whether used on the Internet or not),
and I think it's important to use the right one.
Replying to [comment:8 Viper007Bond]:
> It would make sense for the button on the form to say "log in" as that's
what you are doing -- logging in, but the link on the homepage is taking
you to the "login form" and clicking it isn't logging you in.
I'm glad you agree the button on the login form should say "Log In"
because it is indeed performing an action and thus requires a verb.
As for the link on the homepage, it's less clear, but I would argue that a
typical user sees this and thinks "I need to click here to log in," not "I
need to click here because this takes me to the login form, which will let
me log in." It's a subtle difference, but users tend to think in actions,
not objects. You (or the application) would tell someone: "Log in [to do
more stuff]" not "go the login form."
And again, this is the approach the WordPress forums take.
Thanks for considering.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 14:04:04 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 14:04:11 2007
Subject: [wp-trac] Re: [WordPress Trac] #5301: WordPress can "leak" if a
username is valid
In-Reply-To: <050.869abd700cbf812902cbafd7590ddff0@lists.automattic.com>
References: <050.869abd700cbf812902cbafd7590ddff0@lists.automattic.com>
Message-ID: <059.ba016590698fb16516d8a5266b477194@lists.automattic.com>
#5301: WordPress can "leak" if a username is valid
---------------------------------+------------------------------------------
Reporter: Viper007Bond | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: Administration | Version: 2.3.1
Severity: normal | Resolution:
Keywords: has-patch, security |
---------------------------------+------------------------------------------
Changes (by dougal):
* keywords: has-patch => has-patch, security
Comment:
Thanks for putting this ticket in. I was going to do it myself, but just
hadn't found the time yet.
Disclosing whether the username or password was incorrect like this is a
definite security no-no. This is oooold security-fu. Security-by-
obscurity? In a sense. But when you give somebody a definite part of the
key, it just makes the rest that much easier. Any security knowledge base
out there will tell you not to give this type of info away. Look back over
the old changelogs for SSH sometime.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 14:23:55 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 14:24:00 2007
Subject: [wp-trac] Re: [WordPress Trac] #5261: Array issues in plugins.php
In-Reply-To: <050.881ca25f5bcc91a94d201933b40a7a86@lists.automattic.com>
References: <050.881ca25f5bcc91a94d201933b40a7a86@lists.automattic.com>
Message-ID: <059.c44b02448d9e93c37244886d004be095@lists.automattic.com>
#5261: Array issues in plugins.php
--------------------------+-------------------------------------------------
Reporter: aroundmyroom | Owner: anonymous
Type: defect | Status: new
Priority: high | Milestone: 2.3.2
Component: General | Version: 2.3
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+-------------------------------------------------
Comment (by aroundmyroom):
Darkdragon:
I used your patch and for 2.3.1RC1 it was working indeed, the forum fix I
only used in 2.2.2
now just copied all 2.3.1 sources over the 2.1.3RC1 location & using same
config: re-applied the patch onto the new plugin.php
But now the ARRAY is again appearing in the Pages (see
http://www.aroundmyroom.com/test -> right side column
and in the admin menu you can see it clearly selecting ie. categories, for
a new category everywhere we see 'ARRAY'
like: Presentation
Current Theme
Array Array by Array
Array
All of this theme?s files are located in Array.
or when selecting users: Authors & Users you do not see anything ..
at the profile
Yahoo IM:
ARRAY
Jabber / Google Talk:
ARRAY
So the patched worked for 2.1.3RC1 but for 2.1.3 a no go
in my plugin.php it is around line 104
$r = isset($GLOBALS['wp_filter'][$tag][$priority][$function_to_remove]);
$GLOBALS['wp_filter'][$tag][$priority][$function_to_remove] =
array();
unset($GLOBALS['wp_filter'][$tag][$priority][$function_to_remove]);
unset($GLOBALS['merged_filters'][$tag]);
}
this is not working in 2.3.1 but did in 2.3.1RC1
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 14:25:32 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 14:25:38 2007
Subject: [wp-trac] Re: [WordPress Trac] #5261: Array issues in plugins.php
In-Reply-To: <050.881ca25f5bcc91a94d201933b40a7a86@lists.automattic.com>
References: <050.881ca25f5bcc91a94d201933b40a7a86@lists.automattic.com>
Message-ID: <059.9ee473a7dd41dab6b04ebbd37d41957d@lists.automattic.com>
#5261: Array issues in plugins.php
--------------------------+-------------------------------------------------
Reporter: aroundmyroom | Owner: anonymous
Type: defect | Status: new
Priority: high | Milestone: 2.3.2
Component: General | Version: 2.3
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+-------------------------------------------------
Comment (by aroundmyroom):
erratum:
" So the patched worked for 2.1.3RC1 but for 2.1.3 a no go "
must be
.... 2.3.1RC but for 2.3.1 a no go ..
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 15:36:45 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 15:36:49 2007
Subject: [wp-trac] Re: [WordPress Trac] #5274: Automatic pingback comments
created for blog post that link to blog pages on the local blog
In-Reply-To: <045.09f89e864ed1402f80aff24632e0ae93@lists.automattic.com>
References: <045.09f89e864ed1402f80aff24632e0ae93@lists.automattic.com>
Message-ID: <054.979abb8e53f53134c843342378de009d@lists.automattic.com>
#5274: Automatic pingback comments created for blog post that link to blog pages
on the local blog
---------------------+------------------------------------------------------
Reporter: Skywing | Owner: anonymous
Type: defect | Status: closed
Priority: normal | Milestone:
Component: General | Version: 2.3.1
Severity: normal | Resolution: invalid
Keywords: |
---------------------+------------------------------------------------------
Changes (by westi):
* milestone: 2.5 =>
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 15:36:40 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 15:39:19 2007
Subject: [wp-trac] Re: [WordPress Trac] #5274: Automatic pingback comments
created for blog post that link to blog pages on the local blog
In-Reply-To: <045.09f89e864ed1402f80aff24632e0ae93@lists.automattic.com>
References: <045.09f89e864ed1402f80aff24632e0ae93@lists.automattic.com>
Message-ID: <054.a26668c4db31536657c7eda66ce625e8@lists.automattic.com>
#5274: Automatic pingback comments created for blog post that link to blog pages
on the local blog
---------------------+------------------------------------------------------
Reporter: Skywing | Owner: anonymous
Type: defect | Status: closed
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: normal | Resolution: invalid
Keywords: |
---------------------+------------------------------------------------------
Changes (by westi):
* status: new => closed
* resolution: => invalid
Comment:
This is by design.
Pages support comments fine if your theme disables them.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 15:48:07 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 15:48:12 2007
Subject: [wp-trac] Re: [WordPress Trac] #4545: Slashing consistency
In-Reply-To: <049.c5627490e8fabb49d8403fd187a48f43@lists.automattic.com>
References: <049.c5627490e8fabb49d8403fd187a48f43@lists.automattic.com>
Message-ID: <058.98bd4d026ecbfdbcfb5a21a04a928595@lists.automattic.com>
#4545: Slashing consistency
-------------------------+--------------------------------------------------
Reporter: markjaquith | Owner: anonymous
Type: task | Status: new
Priority: normal | Milestone: 2.4
Component: Security | Version: 2.3
Severity: normal | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by pishmishy):
I'm not sure that this ticket is worth keeping open when #4553 appears to
be addressing this issue. Resolve as duplicate?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 16:13:20 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 16:13:26 2007
Subject: [wp-trac] Re: [WordPress Trac] #2756: Reduce memory usage when many
pages and users are present
In-Reply-To: <042.e3fc5e924e68e1ac4e38f6fa4ea3aed4@lists.automattic.com>
References: <042.e3fc5e924e68e1ac4e38f6fa4ea3aed4@lists.automattic.com>
Message-ID: <051.1285ffe188b32ef71ffdafaf94144967@lists.automattic.com>
#2756: Reduce memory usage when many pages and users are present
--------------------------------+-------------------------------------------
Reporter: ryan | Owner: anonymous
Type: enhancement | Status: closed
Priority: normal | Milestone: 2.1
Component: Administration | Version: 2.0.2
Severity: normal | Resolution: fixed
Keywords: performance memory |
--------------------------------+-------------------------------------------
Changes (by foolswisdom):
* status: new => closed
* resolution: => fixed
* milestone: 2.5 => 2.1
Comment:
Lets call this done, and create a new bug with some details -- I wonder if
anyone knows what this is about anymore anyway.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 16:14:22 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 16:14:27 2007
Subject: [wp-trac] Re: [WordPress Trac] #5303: "Manage > Pages" becomes very
slow with hundreds of pages
In-Reply-To: <047.a53bb4764248dfb894898e1eb6836e14@lists.automattic.com>
References: <047.a53bb4764248dfb894898e1eb6836e14@lists.automattic.com>
Message-ID: <056.b50624be84824f4fe208ad25858138ff@lists.automattic.com>
#5303: "Manage > Pages" becomes very slow with hundreds of pages
-----------------------+----------------------------------------------------
Reporter: MartijnD | Owner: anonymous
Type: task | Status: new
Priority: low | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
-----------------------+----------------------------------------------------
Comment (by ryan):
Yes, that code is awful. Improvements are definitely welcome.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 16:16:51 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 16:16:56 2007
Subject: [wp-trac] Re: [WordPress Trac] #5303: "Manage > Pages" becomes very
slow with hundreds of pages
In-Reply-To: <047.a53bb4764248dfb894898e1eb6836e14@lists.automattic.com>
References: <047.a53bb4764248dfb894898e1eb6836e14@lists.automattic.com>
Message-ID: <056.cdd5cbbdbdcd86632fc18bce4c056ccd@lists.automattic.com>
#5303: "Manage > Pages" becomes very slow with hundreds of pages
-----------------------+----------------------------------------------------
Reporter: MartijnD | Owner: anonymous
Type: task | Status: new
Priority: low | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
-----------------------+----------------------------------------------------
Comment (by foolswisdom):
Relates to #5303?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 16:20:51 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 16:20:57 2007
Subject: [wp-trac] Re: [WordPress Trac] #5304: Cannot upload images that are
not Gif/jpeg/png
In-Reply-To: <042.a730459ee82a73937b32553beabbdfd6@lists.automattic.com>
References: <042.a730459ee82a73937b32553beabbdfd6@lists.automattic.com>
Message-ID: <051.90bc55a9ff7f6b70dd7cba4d1cb0ac66@lists.automattic.com>
#5304: Cannot upload images that are not Gif/jpeg/png
------------------------------------------+---------------------------------
Reporter: DD32 | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: Administration | Version: 2.4
Severity: normal | Resolution:
Keywords: has-patch developer-feedback |
------------------------------------------+---------------------------------
Changes (by foolswisdom):
* keywords: => has-patch developer-feedback
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 16:26:22 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 16:26:28 2007
Subject: [wp-trac] Re: [WordPress Trac] #5301: WordPress can "leak" if a
username is valid
In-Reply-To: <050.869abd700cbf812902cbafd7590ddff0@lists.automattic.com>
References: <050.869abd700cbf812902cbafd7590ddff0@lists.automattic.com>
Message-ID: <059.7baf0738ecf9f7c72b797c4ce30a9644@lists.automattic.com>
#5301: WordPress can "leak" if a username is valid
---------------------------------+------------------------------------------
Reporter: Viper007Bond | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: Administration | Version: 2.3.1
Severity: normal | Resolution:
Keywords: has-patch, security |
---------------------------------+------------------------------------------
Comment (by foolswisdom):
The loss of usability has no benefit if this information can be attained
trivially other ways.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 16:37:44 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 16:37:50 2007
Subject: [wp-trac] Re: [WordPress Trac] #5303: "Manage > Pages" becomes very
slow with hundreds of pages
In-Reply-To: <047.a53bb4764248dfb894898e1eb6836e14@lists.automattic.com>
References: <047.a53bb4764248dfb894898e1eb6836e14@lists.automattic.com>
Message-ID: <056.a20a1705a183a9b3e428a063488853f6@lists.automattic.com>
#5303: "Manage > Pages" becomes very slow with hundreds of pages
-----------------------+----------------------------------------------------
Reporter: MartijnD | Owner: anonymous
Type: task | Status: new
Priority: low | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
-----------------------+----------------------------------------------------
Comment (by foolswisdom):
Gah, relates to 3614?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 16:37:54 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 16:37:59 2007
Subject: [wp-trac] Re: [WordPress Trac] #3614: Scaling issue with hundreds
of pages
In-Reply-To: <049.c1ed6899e94a2d178a80c197a0cbca6b@lists.automattic.com>
References: <049.c1ed6899e94a2d178a80c197a0cbca6b@lists.automattic.com>
Message-ID: <058.ea902873e570aee0b8d7e7cf98ff2c0e@lists.automattic.com>
#3614: Scaling issue with hundreds of pages
--------------------------+-------------------------------------------------
Reporter: markjaquith | Owner: anonymous
Type: defect | Status: new
Priority: high | Milestone: 2.4
Component: Optimization | Version: 2.0.7
Severity: critical | Resolution:
Keywords: needs-patch |
--------------------------+-------------------------------------------------
Comment (by foolswisdom):
Relates to #5303?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 17:11:19 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 17:11:25 2007
Subject: [wp-trac] Re: [WordPress Trac] #4115: getCategoryList should not
include Blogroll in list of categories
In-Reply-To: <048.abd5b8c8ab2922fb2e6fb99f1bc39b3d@lists.automattic.com>
References: <048.abd5b8c8ab2922fb2e6fb99f1bc39b3d@lists.automattic.com>
Message-ID: <057.586bb22a9a5d6d7e653fc042c82db45b@lists.automattic.com>
#4115: getCategoryList should not include Blogroll in list of categories
-------------------------+--------------------------------------------------
Reporter: redsweater | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: XML-RPC | Version: 2.2
Severity: normal | Resolution:
Keywords: needs-patch |
-------------------------+--------------------------------------------------
Changes (by redsweater):
* summary: getCategoryList should exclude empty categories by default =>
getCategoryList should not include Blogroll in
list of categories
Comment:
I'm changing the Summary from:
getCategoryList should exclude empty categories by default
to:
getCategoryList should not include Blogroll in list of categories
That better emphasizes my core concern here. I thought when I first
reported this that it might get better traction if I stated the problem as
more of a "consistency problem." But what I really want is to get that
dang "Blogroll" item out of the category list, because it confuses my
users (and ultimately causes users to resent WordPress's behavior).
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 17:12:47 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 17:12:53 2007
Subject: [wp-trac] Re: [WordPress Trac] #5303: "Manage > Pages" becomes very
slow with hundreds of pages
In-Reply-To: <047.a53bb4764248dfb894898e1eb6836e14@lists.automattic.com>
References: <047.a53bb4764248dfb894898e1eb6836e14@lists.automattic.com>
Message-ID: <056.9bec05046996a91c5dc6cbe6d7c9be31@lists.automattic.com>
#5303: "Manage > Pages" becomes very slow with hundreds of pages
-----------------------+----------------------------------------------------
Reporter: MartijnD | Owner: anonymous
Type: task | Status: new
Priority: low | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
-----------------------+----------------------------------------------------
Changes (by besonen):
* cc: davidb@panix.com (added)
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 17:42:23 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 17:42:32 2007
Subject: [wp-trac] Re: [WordPress Trac] #5007: Email notifications fail on
hosted sites that check sender address
In-Reply-To: <046.09634736e941d3d69c41a4793e947266@lists.automattic.com>
References: <046.09634736e941d3d69c41a4793e947266@lists.automattic.com>
Message-ID: <055.157862d89f027292d0a6309ee4e679c1@lists.automattic.com>
#5007: Email notifications fail on hosted sites that check sender address
------------------------+---------------------------------------------------
Reporter: jlwarlow | Owner: anonymous
Type: defect | Status: reopened
Priority: low | Milestone: 2.3.2
Component: General | Version: 2.2.2
Severity: minor | Resolution:
Keywords: regression |
------------------------+---------------------------------------------------
Comment (by mattyrob):
> Who would have known, turns out this is bad mojo, and doesn't play nice
with other configurations, causing regressions #5273 and 5294 . Seems that
in some environments if you are smart enough to set the Sender, you are
dumb to be a spammer, and so they run it through "callout verification".
That's bad news - seems we're damned if we do set Sender and we're damend
if we don't depending on the server config :-(
I think we should set it to be honest as it's consistent and valid. Any
host dropping email that sets Sender is being overly strict IMO.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 18:25:38 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 18:25:42 2007
Subject: [wp-trac] Re: [WordPress Trac] #5007: Email notifications fail on
hosted sites that check sender address
In-Reply-To: <046.09634736e941d3d69c41a4793e947266@lists.automattic.com>
References: <046.09634736e941d3d69c41a4793e947266@lists.automattic.com>
Message-ID: <055.54bc36fd71c76f0dde840f64eadead22@lists.automattic.com>
#5007: Email notifications fail on hosted sites that check sender address
------------------------+---------------------------------------------------
Reporter: jlwarlow | Owner: anonymous
Type: defect | Status: reopened
Priority: low | Milestone: 2.3.2
Component: General | Version: 2.2.2
Severity: minor | Resolution:
Keywords: regression |
------------------------+---------------------------------------------------
Comment (by lloydbudd):
Replying to [comment:9 mattyrob]:
> consistent and valid.
That's the problem, for most members it isn't valid. wordpress@[domain]
doesn't exist.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 19:19:06 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 19:19:12 2007
Subject: [wp-trac] Re: [WordPress Trac] #5007: Email notifications fail on
hosted sites that check sender address
In-Reply-To: <046.09634736e941d3d69c41a4793e947266@lists.automattic.com>
References: <046.09634736e941d3d69c41a4793e947266@lists.automattic.com>
Message-ID: <055.100b18d33f87bc56a7954915c45975f6@lists.automattic.com>
#5007: Email notifications fail on hosted sites that check sender address
------------------------+---------------------------------------------------
Reporter: jlwarlow | Owner: anonymous
Type: defect | Status: reopened
Priority: low | Milestone: 2.3.2
Component: General | Version: 2.2.2
Severity: minor | Resolution:
Keywords: regression |
------------------------+---------------------------------------------------
Comment (by westi):
I guess the solution is going to be:
* Revert the change
* For those people that need Sender set I will make available a simple
plugin which sets it - a reverse of the one available on here
http://trac.wordpress.org/attachment/ticket/5273/no-sender.php
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 20:17:23 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 20:17:30 2007
Subject: [wp-trac] Re: [WordPress Trac] #5007: Email notifications fail on
hosted sites that check sender address
In-Reply-To: <046.09634736e941d3d69c41a4793e947266@lists.automattic.com>
References: <046.09634736e941d3d69c41a4793e947266@lists.automattic.com>
Message-ID: <055.fa0e6b1d09ba89a7f05cdaaef39ee2c3@lists.automattic.com>
#5007: Email notifications fail on hosted sites that check sender address
------------------------+---------------------------------------------------
Reporter: jlwarlow | Owner: anonymous
Type: defect | Status: reopened
Priority: low | Milestone: 2.3.2
Component: General | Version: 2.2.2
Severity: minor | Resolution:
Keywords: regression |
------------------------+---------------------------------------------------
Comment (by lloydbudd):
westi, sounds good. A longer term project may be to evaluate using the
admin email address or helping set and ensuring a valid email is used
(maybe using this same "callout verification" technique, hehe) -- its own
ticket, for another day.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 21:27:54 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 21:28:02 2007
Subject: [wp-trac] [WordPress Trac] #5305: permalinks broken when article
name is numeric
Message-ID: <045.015dba03a5b592cfc89fb519871f734a@lists.automattic.com>
#5305: permalinks broken when article name is numeric
---------------------+------------------------------------------------------
Reporter: thomask | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.3.2
Component: General | Version: 2.3.1
Severity: major | Keywords: permalinks, number
---------------------+------------------------------------------------------
if you create numeric-only post name, the generated slug is this number -
this conflicts with article ID, so it returns different article or 404
page, never the article. It can be then solved by generating manual slug
with some char in it, but i think it would be better to include some char
in that case, e.g. underscore, like _123
Also if someone will try to solve this, it would be nice to solve other
problem - if post slug is begining with the slug of the category, than the
category page returns that post, not the category
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 21:44:10 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 21:44:16 2007
Subject: [wp-trac] Re: [WordPress Trac] #5305: permalinks broken when
article name is numeric
In-Reply-To: <045.015dba03a5b592cfc89fb519871f734a@lists.automattic.com>
References: <045.015dba03a5b592cfc89fb519871f734a@lists.automattic.com>
Message-ID: <054.a7ff0608b44dbdda3e30f63d5400b3a3@lists.automattic.com>
#5305: permalinks broken when article name is numeric
--------------------------------+-------------------------------------------
Reporter: thomask | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.3.2
Component: General | Version: 2.3.1
Severity: major | Resolution:
Keywords: permalinks, number |
--------------------------------+-------------------------------------------
Comment (by lloydbudd):
thomask, can you include your Permalink Structure? And provide specific
examples? This could help duplicate the problem.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 21:57:10 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 21:57:14 2007
Subject: [wp-trac] Re: [WordPress Trac] #4528: post_modified not set for
first save of draft
In-Reply-To: <049.fea049ec0c8610913e464dce9b1195cc@lists.automattic.com>
References: <049.fea049ec0c8610913e464dce9b1195cc@lists.automattic.com>
Message-ID: <058.6a546c98217bfb3dbdf363df50513d3e@lists.automattic.com>
#4528: post_modified not set for first save of draft
----------------------------+-----------------------------------------------
Reporter: markjaquith | Owner: markjaquith
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: Administration | Version: 2.3
Severity: normal | Resolution:
Keywords: |
----------------------------+-----------------------------------------------
Changes (by brh):
* cc: brh@numbera.com (added)
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 22:12:49 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 22:12:52 2007
Subject: [wp-trac] Re: [WordPress Trac] #5007: Email notifications fail on
hosted sites that check sender address
In-Reply-To: <046.09634736e941d3d69c41a4793e947266@lists.automattic.com>
References: <046.09634736e941d3d69c41a4793e947266@lists.automattic.com>
Message-ID: <055.5becd86bf8a39afa16131aa3a8342950@lists.automattic.com>
#5007: Email notifications fail on hosted sites that check sender address
------------------------+---------------------------------------------------
Reporter: jlwarlow | Owner: anonymous
Type: defect | Status: reopened
Priority: low | Milestone: 2.3.2
Component: General | Version: 2.2.2
Severity: minor | Resolution:
Keywords: regression |
------------------------+---------------------------------------------------
Comment (by westi):
Replying to [comment:12 lloydbudd]:
> westi, sounds good. A longer term project may be to evaluate using the
admin email address or helping set and ensuring a valid email is used
(maybe using this same "callout verification" technique, hehe) -- its own
ticket, for another day.
I'm pretty sure we used to use the admin address at one point - I can't
remember exactly why it changed to the current method.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 1 23:30:02 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 1 23:30:12 2007
Subject: [wp-trac] [WordPress Trac] #5306: Canonical redirect conflicts with
hosting provider's redirect
Message-ID: <044.b9be7501a00dacd084274b5f3bd46d79@lists.automattic.com>
#5306: Canonical redirect conflicts with hosting provider's redirect
-------------------------+--------------------------------------------------
Reporter: vocaro | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3
Severity: normal | Keywords:
-------------------------+--------------------------------------------------
WordPress 2.3 includes a new canonical redirect feature. It is designed to
deal with such problems as Google seeing `yoursite.com` and
`www.yoursite.com` as two different entities.
Some hosting providers offer a similar redirect feature. With DreamHost,
for example, you can configure your domain so that the web server
redirects any request for `www.yoursite.com` to `yoursite.com` (i.e., it
removes the `www` prefix).
When both of these features are enabled at the same time, they conflict
with each other. You will experience HTTP errors such as:
Too many HTTP redirects
or:
Firefox has detected that the server is redirecting the request for this
address in a way that will never complete.
To fix this problem, you must go to the WordPress admin page and switch to
the Options > General section. For the WordPress address and Blog address
entries, remove the `www` prefix from both URLs.
The canonical redirect feature should be changed so that this problem
doesn't occur. For example, canonical redirection could be disabled by
default, or perhaps there is some way for WordPress to detect the `www`
prefix removal by the web server and then automatically remove `www` from
the URL entries in the WordPress settings. At the very least, there should
be a documentation note on this problem and how to fix it.
This ticket is related to #5089 and #5017.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 2 10:12:01 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 2 10:12:08 2007
Subject: [wp-trac] Re: [WordPress Trac] #5306: Canonical redirect conflicts
with hosting provider's redirect
In-Reply-To: <044.b9be7501a00dacd084274b5f3bd46d79@lists.automattic.com>
References: <044.b9be7501a00dacd084274b5f3bd46d79@lists.automattic.com>
Message-ID: <053.b8a8c39ba3745d848579f14020a99652@lists.automattic.com>
#5306: Canonical redirect conflicts with hosting provider's redirect
-------------------------------+--------------------------------------------
Reporter: vocaro | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3
Severity: normal | Resolution:
Keywords: reporter-feedback |
-------------------------------+--------------------------------------------
Changes (by westi):
* keywords: => reporter-feedback
Comment:
Can you confirm what you have set in the WordPress Address and Blog
Address sections of the options screen.
It sounds like you have them misconfigured.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 2 10:14:03 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 2 10:14:10 2007
Subject: [wp-trac] Re: [WordPress Trac] #5298: https atom service document
doesn't point to https collections
In-Reply-To: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
References: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
Message-ID: <052.2d1f4419bc11b20c3bc8d9dabbbe2ecf@lists.automattic.com>
#5298: https atom service document doesn't point to https collections
-----------------------+----------------------------------------------------
Reporter: rubys | Owner: westi
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: has-patch |
-----------------------+----------------------------------------------------
Changes (by westi):
* owner: anonymous => westi
* status: new => assigned
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 2 10:17:18 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 2 10:17:25 2007
Subject: [wp-trac] Re: [WordPress Trac] #5295: wp-links-opml.php will not
display a single link category
In-Reply-To: <044.65c208aa9e0295645685056bc9be0cb6@lists.automattic.com>
References: <044.65c208aa9e0295645685056bc9be0cb6@lists.automattic.com>
Message-ID: <053.e9f9e590b0a51bfb630c33e18933ad0c@lists.automattic.com>
#5295: wp-links-opml.php will not display a single link category
---------------------+------------------------------------------------------
Reporter: vrypan | Owner: westi
Type: defect | Status: assigned
Priority: normal | Milestone: 2.3.2
Component: General | Version: 2.3.1
Severity: major | Resolution:
Keywords: opml |
---------------------+------------------------------------------------------
Changes (by westi):
* owner: anonymous => westi
* status: new => assigned
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 2 10:21:43 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 2 10:21:49 2007
Subject: [wp-trac] Re: [WordPress Trac] #5287: Setup table names inside wpdb
In-Reply-To: <042.da84756ea2414992e580e5855b8966f4@lists.automattic.com>
References: <042.da84756ea2414992e580e5855b8966f4@lists.automattic.com>
Message-ID: <051.20bde50fcca8ac256212aec506741597@lists.automattic.com>
#5287: Setup table names inside wpdb
---------------------+------------------------------------------------------
Reporter: ryan | Owner: ryan
Type: defect | Status: closed
Priority: normal | Milestone: 2.4
Component: General | Version: 2.4
Severity: normal | Resolution: fixed
Keywords: wpdb |
---------------------+------------------------------------------------------
Comment (by westi):
Don't we need to use the function too?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 2 11:15:44 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 2 11:15:49 2007
Subject: [wp-trac] Re: [WordPress Trac] #4755: WordPress should use code
from the modified kses at Sourceforge.net
In-Reply-To: <047.3f2c13bc7857929ceb6b636206ce0069@lists.automattic.com>
References: <047.3f2c13bc7857929ceb6b636206ce0069@lists.automattic.com>
Message-ID: <056.6e40c5d81e8963d15f02c6bb82d36d18@lists.automattic.com>
#4755: WordPress should use code from the modified kses at Sourceforge.net
--------------------------+-------------------------------------------------
Reporter: alpha2zee | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: Optimization | Version:
Severity: normal | Resolution:
Keywords: |
--------------------------+-------------------------------------------------
Comment (by alpha2zee):
This kses mod has evolved into
[http://www.bioinformatics.org/phplabware/internal_utilities/htmLawed/index.php
htmLawed].
* highly and easily customizable
* ~45 kb single-file, non-OOP code with peak basal memory usage of ~0.5 MB
* improved tag balancing, entity checks and conversions
* remains kses-compatible
* NEW: transformation of deprecated tags/attributes
* NEW: anti-email/link spam measures
* NEW: absolute/relative URL conversions
* NEW: filtering/conversion of bad characters introduced by Microsoft
Word, etc.
* etc... see
[http://www.bioinformatics.org/phplabware/internal_utilities/htmLawed/htmLawed_README.htm
htmLawed documentation]
A testing script is in the
[http://bioinformatics.org/phplabware/downloads/htmLawed.zip download];
htmLawed can also be
[http://www.bioinformatics.org/phplabware/internal_utilities/htmLawed/htmLawedTest.php
tried online].
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 2 11:15:54 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 2 11:15:59 2007
Subject: [wp-trac]
[WordPress Trac] #5307: Partially back out changeset 5273,
ticket 5181
Message-ID: <043.b9d3324220a43283ac4f7575844c9189@lists.automattic.com>
#5307: Partially back out changeset 5273, ticket 5181
---------------------+------------------------------------------------------
Reporter: rubys | Owner: westi
Type: defect | Status: new
Priority: high | Milestone: 2.4
Component: General | Version: 2.4
Severity: major | Keywords: has-patch
---------------------+------------------------------------------------------
2.4-bleeding has been deployed on wordpress.com which exposes a problem
with the patch associated with [http://trac.wordpress.org/ticket/5181
ticket 5181]. This ticket partially backs that change out until a proper
fix can be made.
The root issue is that the app support and the rest of wp produce feeds
differently, and in the process interpret the database differently. The
app support will put HTML in $post->post_content, but the rest of
wordpress assumes that the post_content contains text which, after passed
through various filters, produces html. This is a subtle difference which
doesn't show up immediately, but the simple presence of blank lines will
cause the two to produce noticeably different results.
For app to function properly, there needs to be a way to "unfilter"
(x)html, i.e., a way to reverse engineer what text would produce the
equivalent of a given (x)html result after filtering. But to that proper
fix will take time, so meanwhile the 2.3 functionality should be restored
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 2 14:58:23 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 2 14:58:31 2007
Subject: [wp-trac] [WordPress Trac] #5308: continued cookie error after
upgrade to 2.3.1
Message-ID: <052.3fcc8555e8279abfcbc42cd6050736c0@lists.automattic.com>
#5308: continued cookie error after upgrade to 2.3.1
----------------------------+-----------------------------------------------
Reporter: openlycreative | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: normal | Keywords: cookie error
----------------------------+-----------------------------------------------
After upgrading to WP 2.3 I (like everyone else) was experiencing the
"cookie error" every time I logged into my site. When WP 2.3.1 was
released I assumed that the new upgrade would fix the cookie errors, but
it hasn't. Not matter on what computer or with what browser I try it with
I always get the cookie error.
I wasn't sure if any of the patches would work on 2.3.1 so I haven't tried
them. I did however, try to see if my wp_config.php file had spacing
issues and it didn't.
I'm not sure what the next step is to fix this issue. Can I get some help?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 2 17:21:36 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 2 17:21:44 2007
Subject: [wp-trac] Re: [WordPress Trac] #5196: Support "minor edits" in Atom
In-Reply-To: <043.83e5b6d4482dab476da4762820682a15@lists.automattic.com>
References: <043.83e5b6d4482dab476da4762820682a15@lists.automattic.com>
Message-ID: <052.4e91190bb66093f239647a04c2c37ca2@lists.automattic.com>
#5196: Support "minor edits" in Atom
-------------------------+--------------------------------------------------
Reporter: rubys | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by rubys):
[http://ascher.ca/blog/2007/11/01/marsedit-wordpress-planet-and-minor-
updates/ MarsEdit, Wordpress, Planet, and minor updates]
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 2 17:23:54 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 2 17:24:00 2007
Subject: [wp-trac] [WordPress Trac] #5309: 'Insert/edit image' dialog
changes empty fields to default values
Message-ID: <050.53707c0c3ba758b7438f2e8ad82fbb23@lists.automattic.com>
#5309: 'Insert/edit image' dialog changes empty fields to default values
--------------------------+-------------------------------------------------
Reporter: hermanschaap | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: normal | Keywords:
--------------------------+-------------------------------------------------
I first add a picture by uploading it and then clicking 'Send to editor'.
Then I click the picture and click the 'Insert/edit image' button. In the
dialog, the size is not filled out. I change the image description and
click Update. Now, the picture is set to a size of 1x1.
I see two solutions:
1) Add the size (and perhaps some of the other fields) to the image tag
when sending it to the editor.
2) Change the 'Insert/edit image' dialog, so it ignores empty fields.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 2 21:34:24 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 2 21:34:31 2007
Subject: [wp-trac] [WordPress Trac] #5310: XMLRPC interface should expose
mechanism for listing and deleting media resources
Message-ID: <048.0bbebe99e47858b4857b9fb9ab498fe1@lists.automattic.com>
#5310: XMLRPC interface should expose mechanism for listing and deleting media
resources
-------------------------+--------------------------------------------------
Reporter: redsweater | Owner: josephscott
Type: enhancement | Status: new
Priority: normal | Milestone: 2.5
Component: XML-RPC | Version: 2.3.1
Severity: normal | Keywords:
-------------------------+--------------------------------------------------
Right now the XMLRPC interface supports the "newMediaObject" mechanism
that is part of the MetaWeblog API, but lacks any method for inspecting or
otherwise manipulating media objects.
I think to support a richer remote client experience, the XLMRPC interface
should support at least a method for listing the media objects that have
been previously uploaded (similar to what appears in the "Browse" tab of
the wp-admin post editor), and for deleting a media asset that is present.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 2 22:01:32 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 2 22:01:38 2007
Subject: [wp-trac] Re: [WordPress Trac] #5310: XMLRPC interface should expose
mechanism for listing and deleting media resources
In-Reply-To: <048.0bbebe99e47858b4857b9fb9ab498fe1@lists.automattic.com>
References: <048.0bbebe99e47858b4857b9fb9ab498fe1@lists.automattic.com>
Message-ID: <057.254c84a02676b920897b943b7ed6a725@lists.automattic.com>
#5310: XMLRPC interface should expose mechanism for listing and deleting media
resources
-------------------------+--------------------------------------------------
Reporter: redsweater | Owner: josephscott
Type: enhancement | Status: new
Priority: normal | Milestone: 2.5
Component: XML-RPC | Version: 2.3.1
Severity: normal | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Changes (by josephscott):
* cc: josephscott (added)
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 2 22:29:43 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 2 22:29:49 2007
Subject: [wp-trac] Re: [WordPress Trac] #4616: is_email isn't rfc2822
conformant
In-Reply-To: <044.f364717657cdc0423a4a301f8ed20c40@lists.automattic.com>
References: <044.f364717657cdc0423a4a301f8ed20c40@lists.automattic.com>
Message-ID: <053.8ffc5f02ef484fcbdc15e4bd7d12dede@lists.automattic.com>
#4616: is_email isn't rfc2822 conformant
-----------------------+----------------------------------------------------
Reporter: hendry | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-----------------------+----------------------------------------------------
Comment (by Bobcat):
OK, here's a proposal of what we should accept:
1. Allow local@example.com, where local can contain alphanumeric
characters plus ! # $ % * / ? | !^ { } ` ~ & ' + - = _ .
2. As a design goal, check for the restrictions on the placement of the .
character.
3. Do not allow the form of email address where the local part is a
quoted string. i.e., double quotes would not be allowed.
4. Blog by Email will accept two forms for the From or Reply-To lines:
either a plain email address all by itself as defined above, or a name in
quotes (which is ignored) followed by an email address enclosed in angle
brackets.
5. Only one address in the From or Reply-To lines will be used.
This should handle almost all of the address formats in use.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 04:32:16 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sat Nov 3 04:32:22 2007
Subject: [wp-trac] Re: [WordPress Trac] #5290: Adding the_author_role()
template tag
In-Reply-To: <048.e8129b10d0016cb1cd4bd42f39a2c11e@lists.automattic.com>
References: <048.e8129b10d0016cb1cd4bd42f39a2c11e@lists.automattic.com>
Message-ID: <057.67b256bdc88b6a11891790bd83681cc7@lists.automattic.com>
#5290: Adding the_author_role() template tag
----------------------------------+-----------------------------------------
Reporter: Kafkaesqui | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: Template | Version: 2.4
Severity: normal | Resolution:
Keywords: author role template |
----------------------------------+-----------------------------------------
Comment (by Kafkaesqui):
Just uploaded a diff with a better version of get_the_author_role().
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 06:11:46 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sat Nov 3 06:11:54 2007
Subject: [wp-trac] [WordPress Trac] #5311: HTTP-header X-Pingback when
pingbacks are turned off
Message-ID: <041.283215f2bd5b49f41341a2009770ed88@lists.automattic.com>
#5311: HTTP-header X-Pingback when pingbacks are turned off
---------------------+------------------------------------------------------
Reporter: ose | Owner: anonymous
Type: defect | Status: new
Priority: low | Milestone: 2.4
Component: General | Version: 2.3.1
Severity: minor | Keywords: http pingback security
---------------------+------------------------------------------------------
When switching off pingbacks under options/discussion, wordpress still
sends an X-Pingback http header back to the browser.
This has two disadvantages:
- It causes unnecessary traffic by other servers trying to ping wordpress
- It reveals more information then necessary (essentially reveals that a
server is running wordpress even if the web master tries to hide that fact
in other places for security reasons).
Expected behavior: When pingbacks are disables, wordpress should not send
the X-Pingback header to the browser.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 08:09:27 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sat Nov 3 08:09:33 2007
Subject: [wp-trac] Re: [WordPress Trac] #5261: Array issues in plugins.php
In-Reply-To: <050.881ca25f5bcc91a94d201933b40a7a86@lists.automattic.com>
References: <050.881ca25f5bcc91a94d201933b40a7a86@lists.automattic.com>
Message-ID: <059.178f83a396449c2821d352284985d951@lists.automattic.com>
#5261: Array issues in plugins.php
--------------------------+-------------------------------------------------
Reporter: aroundmyroom | Owner: anonymous
Type: defect | Status: closed
Priority: high | Milestone: 2.3.2
Component: General | Version: 2.3
Severity: normal | Resolution: worksforme
Keywords: has-patch |
--------------------------+-------------------------------------------------
Changes (by aroundmyroom):
* cc: darkdragon (added)
* status: new => closed
* resolution: => worksforme
Comment:
update:
after the failing 2.3.1 again I re-applied the forum patch:
$r = isset($GLOBALS['wp_filter'][$tag][$priority][$function_to_remove]);
$wp_filter[$tag][$priority][serialize($function_to_remove)] = array();
unset( $wp_filter[$tag][$priority][serialize($function_to_remove)] );
unset($GLOBALS['merged_filters'][$tag]);
if( true === $r) {
unset($GLOBALS['wp_filter'][$tag][$priority][$function_to_remove]);
unset($GLOBALS['merged_filters'][$tag]);
}
return $r;
}
and the array issue disappeared everywhere from main page as in dashboard
options
users menu is working again, profile is ok etc..
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 08:14:26 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sat Nov 3 08:14:32 2007
Subject: [wp-trac] [WordPress Trac] #5312: wp-admin/includes/image.php
overhaul
Message-ID: <042.2a6c41c0ab9c94ebab9b68d4ec8ba7f6@lists.automattic.com>
#5312: wp-admin/includes/image.php overhaul
----------------------------+-----------------------------------------------
Reporter: DD32 | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: Administration | Version: 2.4
Severity: normal | Keywords: has-patch
----------------------------+-----------------------------------------------
This ticket relates to #4151, #4709 and #5304
I've cleaned the file up to reduce duplicated code, Added PHPDoc comments,
and included mentioned tickets within the cleanup.
Notes:[[BR]]
* {{{function get_udims()}}} duplicated {{{wp_shrink_dimensions()}}},
Switched it to use {{{wp_shrink_dimensions()}}} instead.[[BR]]
* It appears that {{{get_udims()}}} is not used anywhere else in WP.[[BR]]
* depreciated 3rd param($effect) to {{{wp_create_thumbnail()}}} as it isnt
used within the function.[[BR]]
* IMAGETYPE_XXX introduced with PHP 4.3.0 it appears, Added to
compat.php.[[BR]]
* The inline documentation may not be the best, And doesnt include Long
descriptions for most of the functions.[[BR]]
* Most functions should return a WP_Error object instead on error, For
most compatibilit current patch follows previous error handling route.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 22:35:49 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 00:00:17 2007
Subject: [wp-trac] Re: [WordPress Trac] #5313: iframe being injected
In-Reply-To: <048.ac94f7f48af8279f20a6da93eefc0f87@lists.automattic.com>
References: <048.ac94f7f48af8279f20a6da93eefc0f87@lists.automattic.com>
Message-ID: <057.c72f6916406e72f6cc0214dec623e4c1@lists.automattic.com>
#5313: iframe being injected
------------------------+---------------------------------------------------
Reporter: Columcille | Owner: anonymous
Type: defect | Status: new
Priority: high | Milestone: 2.5
Component: Security | Version: 2.3.1
Severity: major | Resolution:
Keywords: |
------------------------+---------------------------------------------------
Changes (by Columcille):
* component: General => Security
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 09:54:11 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 00:26:27 2007
Subject: [wp-trac] Re: [WordPress Trac] #5276: Allow wp-config.php to be
used without including wp-settings.php
In-Reply-To: <048.87bfd68531c072d8e2ddfa929c5d04ae@lists.automattic.com>
References: <048.87bfd68531c072d8e2ddfa929c5d04ae@lists.automattic.com>
Message-ID: <057.e9734d282391db1d14f02ac69c334151@lists.automattic.com>
#5276: Allow wp-config.php to be used without including wp-settings.php
--------------------------------------+-------------------------------------
Reporter: mastermind | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.4
Severity: normal | Resolution:
Keywords: wp-config.php standalone |
--------------------------------------+-------------------------------------
Comment (by mastermind):
Replying to [comment:10 DD32]:
> What should WP be including to kick-start itself? {{{wp-config.php}}} or
{{{wp-blog-header.php}}} ?
{{{wp-blog-header.php}}} makes much more sense. {{{wp-config.php}}}
suggests that it only contains configuration data, and in cases like the
one outlined in the first note, it's rather unfortunate that one can't
cleanly load *only* the configuration.
DD32, could you possibly tell us what you found out about other parts of
WP breaking without this line?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 11:00:00 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 00:27:26 2007
Subject: [wp-trac] Re: [WordPress Trac] #5309: 'Insert/edit image' dialog
changes empty fields to default values
In-Reply-To: <050.53707c0c3ba758b7438f2e8ad82fbb23@lists.automattic.com>
References: <050.53707c0c3ba758b7438f2e8ad82fbb23@lists.automattic.com>
Message-ID: <059.a62398a2d153b49c997ba70c5b2b40ec@lists.automattic.com>
#5309: 'Insert/edit image' dialog changes empty fields to default values
-------------------------------+--------------------------------------------
Reporter: hermanschaap | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: reporter-feedback |
-------------------------------+--------------------------------------------
Comment (by westi):
Possibly relates to #5087
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 19:09:03 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 00:30:28 2007
Subject: [wp-trac] Re: [WordPress Trac] #4715: Lost of Priority with
Merge_filters and $wp_filters['all']
In-Reply-To: <048.7a211309ca32f4134bc5b190c06364a9@lists.automattic.com>
References: <048.7a211309ca32f4134bc5b190c06364a9@lists.automattic.com>
Message-ID: <057.927a2f3b65141f5d68390c0f0f3bfd8f@lists.automattic.com>
#4715: Lost of Priority with Merge_filters and $wp_filters['all']
------------------------------------------------------------------+---------
Reporter: darkdragon | Owner: anonymous
Type: defect | Status: new
Priority: lowest | Milestone: 2.4
Component: General | Version: 2.3
Severity: trivial | Resolution:
Keywords: has-patch merge_filters filters plugin.php confirmed |
------------------------------------------------------------------+---------
Comment (by ryan):
see #5231
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 14:15:45 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 00:31:17 2007
Subject: [wp-trac] Re: [WordPress Trac] #5312: wp-admin/includes/image.php
overhaul
In-Reply-To: <042.2a6c41c0ab9c94ebab9b68d4ec8ba7f6@lists.automattic.com>
References: <042.2a6c41c0ab9c94ebab9b68d4ec8ba7f6@lists.automattic.com>
Message-ID: <051.cf432068b58ffe05c42b2c2e8f53ab4e@lists.automattic.com>
#5312: wp-admin/includes/image.php overhaul
----------------------------+-----------------------------------------------
Reporter: DD32 | Owner: westi
Type: enhancement | Status: assigned
Priority: normal | Milestone: 2.4
Component: Administration | Version: 2.4
Severity: normal | Resolution:
Keywords: has-patch |
----------------------------+-----------------------------------------------
Changes (by westi):
* owner: anonymous => westi
* status: new => assigned
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 16:20:58 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 00:31:45 2007
Subject: [wp-trac] Re: [WordPress Trac] #5298: https atom service document
doesn't point to https collections
In-Reply-To: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
References: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
Message-ID: <052.02dd309e2910d121f0f65acfa95fe1d4@lists.automattic.com>
#5298: https atom service document doesn't point to https collections
-----------------------+----------------------------------------------------
Reporter: rubys | Owner: westi
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: has-patch |
-----------------------+----------------------------------------------------
Comment (by westi):
Not quite sure this patch is right at the moment.
Is doing the callback https check on every request to xmlrpc.php really a
good idea?
Would we not do better to just make sure if you access via https then you
stay on https by basing the returned urls on the request url?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 19:06:56 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 00:32:15 2007
Subject: [wp-trac] Re: [WordPress Trac] #5253: filter category_description
call too many (2) in category_description() function
In-Reply-To: <046.2ff1ef49f0c79bc3fe4d47d24d083701@lists.automattic.com>
References: <046.2ff1ef49f0c79bc3fe4d47d24d083701@lists.automattic.com>
Message-ID: <055.79557430e5a93bc0283b86304fb1ab08@lists.automattic.com>
#5253: filter category_description call too many (2) in category_description()
function
------------------------------------------------------------+---------------
Reporter: michelwp | Owner: anonymous
Type: defect | Status: new
Priority: high | Milestone: 2.4
Component: General | Version: 2.3
Severity: normal | Resolution:
Keywords: sanitize_term_field get_term_field needs-patch |
------------------------------------------------------------+---------------
Comment (by ryan):
Does that help?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 10:51:22 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 00:33:36 2007
Subject: [wp-trac] Re: [WordPress Trac] #5311: HTTP-header X-Pingback when
pingbacks are turned off
In-Reply-To: <041.283215f2bd5b49f41341a2009770ed88@lists.automattic.com>
References: <041.283215f2bd5b49f41341a2009770ed88@lists.automattic.com>
Message-ID: <050.e9438b0cff9c509bcaf036132ecf1bb4@lists.automattic.com>
#5311: HTTP-header X-Pingback when pingbacks are turned off
------------------------------------+---------------------------------------
Reporter: ose | Owner: anonymous
Type: defect | Status: closed
Priority: low | Milestone:
Component: General | Version: 2.3.1
Severity: minor | Resolution: invalid
Keywords: http pingback security |
------------------------------------+---------------------------------------
Changes (by westi):
* status: new => closed
* resolution: => invalid
* milestone: 2.4 =>
Comment:
The options under options..discussion are not a global option for whether
or not pingbacks are enabled but are just the defaults for new posts.
There is no option to disable pingbacks.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 19:10:17 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 00:34:39 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.bb175c4492d27746104a2cc49f7bf70f@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
------------------------+---------------------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
------------------------+---------------------------------------------------
Comment (by ryan):
Anyone take a crack at this yet? I'll give it a look next week if no one
jumps in.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 17:21:44 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 00:35:02 2007
Subject: [wp-trac] [WordPress Trac] #5313: iframe being injected
Message-ID: <048.ac94f7f48af8279f20a6da93eefc0f87@lists.automattic.com>
#5313: iframe being injected
------------------------+---------------------------------------------------
Reporter: Columcille | Owner: anonymous
Type: defect | Status: new
Priority: high | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: major | Keywords:
------------------------+---------------------------------------------------
I don't know what's causing this but the problem is being reported by a
few people at http://wordpress.org/support/topic/134928. In short, an
iframe is turning up in certain posts, clearly being put there via some
exploit. Problem has been reported across a few versions of WordPress,
including 2.3.1. Note that the iframe wasn't contained in a theme or any
source files, it was in the post itself stored in the database.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 10:59:36 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 00:35:10 2007
Subject: [wp-trac] Re: [WordPress Trac] #5309: 'Insert/edit image' dialog
changes empty fields to default values
In-Reply-To: <050.53707c0c3ba758b7438f2e8ad82fbb23@lists.automattic.com>
References: <050.53707c0c3ba758b7438f2e8ad82fbb23@lists.automattic.com>
Message-ID: <059.6b66c63792f67cd4121e6036770ef2b9@lists.automattic.com>
#5309: 'Insert/edit image' dialog changes empty fields to default values
-------------------------------+--------------------------------------------
Reporter: hermanschaap | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: reporter-feedback |
-------------------------------+--------------------------------------------
Changes (by westi):
* keywords: => reporter-feedback
Comment:
What browser are you using?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 10:02:29 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 00:36:27 2007
Subject: [wp-trac] Re: [WordPress Trac] #5276: Allow wp-config.php to be
used without including wp-settings.php
In-Reply-To: <048.87bfd68531c072d8e2ddfa929c5d04ae@lists.automattic.com>
References: <048.87bfd68531c072d8e2ddfa929c5d04ae@lists.automattic.com>
Message-ID: <057.2abf0911bb0a385d1b6180d07c5c2344@lists.automattic.com>
#5276: Allow wp-config.php to be used without including wp-settings.php
--------------------------------------+-------------------------------------
Reporter: mastermind | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.4
Severity: normal | Resolution:
Keywords: wp-config.php standalone |
--------------------------------------+-------------------------------------
Comment (by DD32):
> DD32, could you possibly tell us what you found out about other parts of
WP breaking without this line?
I removed the line, and the login form broke :)
wp-login.php, wp-app.php, wp-atom.php just to name a few kick start WP by
including wp-config.php. Once i realised others used it i havnt probed
closer as i was after some direction from more seasoned developers.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 18:36:33 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 00:45:29 2007
Subject: [wp-trac] [WordPress Trac] #5314: comments_link ignores parameters
Message-ID: <048.2e509123cfacca78c73e21e9063fe8d0@lists.automattic.com>
#5314: comments_link ignores parameters
------------------------+---------------------------------------------------
Reporter: Columcille | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: normal | Keywords:
------------------------+---------------------------------------------------
The fucntion comments_link in wp-includes/comment-template.php ignores
parameters passed to it. The function has no code to make use of the
parameters defined in the function and explained at codex.wordpress.org.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sat Nov 3 16:07:17 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 00:48:31 2007
Subject: [wp-trac] Re: [WordPress Trac] #5295: wp-links-opml.php will not
display a single link category
In-Reply-To: <044.65c208aa9e0295645685056bc9be0cb6@lists.automattic.com>
References: <044.65c208aa9e0295645685056bc9be0cb6@lists.automattic.com>
Message-ID: <053.472068ae07af0a7dfc99e25fc88e2934@lists.automattic.com>
#5295: wp-links-opml.php will not display a single link category
---------------------+------------------------------------------------------
Reporter: vrypan | Owner: westi
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version: 2.3.1
Severity: major | Resolution:
Keywords: opml |
---------------------+------------------------------------------------------
Changes (by westi):
* milestone: 2.3.2 => 2.4
Comment:
Replying to [comment:1 ryan]:
> I think get_term($link_cat, 'link_category') will work.
That doesn't work with the current code.
The suggest change in the ticket does though.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 01:11:56 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 01:54:23 2007
Subject: [wp-trac] Re: [WordPress Trac] #5313: iframe being injected
In-Reply-To: <048.ac94f7f48af8279f20a6da93eefc0f87@lists.automattic.com>
References: <048.ac94f7f48af8279f20a6da93eefc0f87@lists.automattic.com>
Message-ID: <057.21307d678fa13ee685d7a2561cbf44fe@lists.automattic.com>
#5313: iframe being injected
------------------------+---------------------------------------------------
Reporter: Columcille | Owner: anonymous
Type: defect | Status: new
Priority: high | Milestone: 2.5
Component: Security | Version: 2.3.1
Severity: major | Resolution:
Keywords: |
------------------------+---------------------------------------------------
Comment (by lloydbudd):
Copying DD32's forum comment here:
Can anyone take a read through their webservers access logs and look for
anything suspect accessing the admin pages?
Also check for other users, and change the admin passwords.
It is hard to work out what is happening here without knowing where the
problem is coming from.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 01:27:57 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 01:56:28 2007
Subject: [wp-trac] [WordPress Trac] #5315: Awaiting Moderation (#): # is not
always updated correctly in JS
Message-ID: <046.539053125be12c1f1ff7a12abc118633@lists.automattic.com>
#5315: Awaiting Moderation (#): # is not always updated correctly in JS
----------------------+-----------------------------------------------------
Reporter: mdawaffe | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version: 2.3.1
Severity: normal | Keywords:
----------------------+-----------------------------------------------------
The number in the Comments -> Awaiting Moderation subtab gets updated via
JS when comments are approved, unapproved or deleted.
There are a couple of bugs, though.
When the number is updated to 0, it is removed rather than set to "0" (a
jQuery oddity).
When a comment is deleted from the Comments -> Amaiting Moderation tab
(rather than from the Comments -> Comments tab), the number is not
changed.
Attached fixes both.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 01:34:00 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 01:56:53 2007
Subject: [wp-trac] Re: [WordPress Trac] #2244: Make login error check
case-sensitive
In-Reply-To: <047.2d10cde07bf318c6fcee302a20cb2750@lists.automattic.com>
References: <047.2d10cde07bf318c6fcee302a20cb2750@lists.automattic.com>
Message-ID: <056.37f7b96155e68c2ef21f4f7ddfceb978@lists.automattic.com>
#2244: Make login error check case-sensitive
----------------------------+-----------------------------------------------
Reporter: Spider007 | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: Administration | Version: 2.0
Severity: normal | Resolution:
Keywords: 2nd-opinion |
----------------------------+-----------------------------------------------
Comment (by DD32):
Personally I think it should be case insensitive usernames, which is how
the core WP code currently operates (as the DB layer is case
insensitive).[[BR]]
Passwords are still case sensitive as md5's are case sensitive.
I've attached a patch which cleans up the wp_login function, The empty
password code was removed as thats handled in the login form anyway.
I'll also attach one which has case sensitive user logins, and displays
the correct error.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 01:36:07 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 01:57:05 2007
Subject: [wp-trac] Re: [WordPress Trac] #2244: Make login error check
case-sensitive
In-Reply-To: <047.2d10cde07bf318c6fcee302a20cb2750@lists.automattic.com>
References: <047.2d10cde07bf318c6fcee302a20cb2750@lists.automattic.com>
Message-ID: <056.d32a7a829820e61783df557747bbde5b@lists.automattic.com>
#2244: Make login error check case-sensitive
-----------------------------------+----------------------------------------
Reporter: Spider007 | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: Administration | Version: 2.0
Severity: normal | Resolution:
Keywords: 2nd-opinion has-patch |
-----------------------------------+----------------------------------------
Changes (by DD32):
* keywords: 2nd-opinion => 2nd-opinion has-patch
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 02:09:06 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 02:09:19 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.abd6fb6dba17fb0bd20d45164e560eac@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Changes (by darkdragon):
* keywords: => has-patch needs-testing
Comment:
Yeah, the patch fixes several other bug problems.
Combines bug fixes for #4715, #5261, and fixes a notice based in
_wp_build...().
Has extra @param documentation
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 02:47:32 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 02:47:48 2007
Subject: [wp-trac] [WordPress Trac] #5316: Extend options.php to allow
deletion, Viewing of Serialized, And grouping options
Message-ID: <042.6de2ef824eed92866058fae1e4f273af@lists.automattic.com>
#5316: Extend options.php to allow deletion, Viewing of Serialized, And grouping
options
----------------------------+-----------------------------------------------
Reporter: DD32 | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: Administration | Version: 2.4
Severity: normal | Keywords: has-patch options
----------------------------+-----------------------------------------------
I floated this idea back in September on wp-hackers:
http://comox.textdrive.com/pipermail/wp-
hackers/2007-September/thread.html#14425 ([wp-hackers] adding
delete/autoload to options.php)
Basically this patch allows options to be deleted from the options.php
page(By checking its checkbox - a JS confirmation is done before form
submitting to make sure the user intends to delete them), Viewing of
Serialized data, And also groups the options by name.
Grouping is achieved by taking the first word in the term, Ie. "test" in
"test_plugin_data", If there are more than 2 terms with such a groupname,
then they're promoted into their own section, This makes it easier to
mass-select a particular 'groups' options to delete.
An invert selection option is also available for each group, So if a user
wants to delete all the RSS cache items, They can either select all the
cache items to remove, or, Select the items they wish to keep(in the rss
section) and click Invert.
I've attached a plugin which is identical to the patch for those not
wanting to apply the patch.
The linked wp-hackers thread mentioned also having an option to set
autoload, I have not yet done that (As it'll require modifying/creating
other functions) yet, But would like to include it, Just not sure how in
the UI it could be managed without looking too crowded.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 02:49:49 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 02:50:02 2007
Subject: [wp-trac] Re: [WordPress Trac] #5316: Extend options.php to allow
deletion, Viewing of Serialized, And grouping options
In-Reply-To: <042.6de2ef824eed92866058fae1e4f273af@lists.automattic.com>
References: <042.6de2ef824eed92866058fae1e4f273af@lists.automattic.com>
Message-ID: <051.8157e15492b281f71963c083876f4e5a@lists.automattic.com>
#5316: Extend options.php to allow deletion, Viewing of Serialized, And grouping
options
-------------------------------+--------------------------------------------
Reporter: DD32 | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: Administration | Version: 2.4
Severity: normal | Resolution:
Keywords: has-patch options |
-------------------------------+--------------------------------------------
Changes (by DD32):
* type: defect => enhancement
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 05:45:38 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 05:45:52 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.4cd93f4aa47510275a5ab22263d8b6b4@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by ryan):
Is there any reason to have both filters and actions in $wp_filter? How
about we separate actions into $wp_action with a merge_actions() function.
Also, do_action() looks like it is always calling merge_filters() instead
of checking to see if that tag is already merged.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 05:45:44 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 05:45:55 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.b32fe4317cdd3d185e5ff38d67e938ff@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Changes (by ryan):
* milestone: 2.5 => 2.4
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 13:44:12 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 13:44:25 2007
Subject: [wp-trac] [WordPress Trac] #5317: get_posts returns invalid data
when using category= parameter
Message-ID: <046.22c1c51f46953a96d9ace5b5ef4b9684@lists.automattic.com>
#5317: get_posts returns invalid data when using category= parameter
----------------------+-----------------------------------------------------
Reporter: MichaelH | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version: 2.3.1
Severity: normal | Keywords:
----------------------+-----------------------------------------------------
Take a new 2.3.1 install with this code:
{{{$myposts = get_posts('category=2');}}}
You would expect to get NO results, as an out-of-the-box install has no
posts with category 2, but that code will return the "Hello World!" post.
Guessing this might be caused by get_posts not discerning between post
categories and link categories (e.g. the link with link_id=1 in category 2
causes post with ID=1 to be returned).
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 14:48:45 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 14:49:00 2007
Subject: [wp-trac] Re: [WordPress Trac] #4616: is_email isn't rfc2822
conformant
In-Reply-To: <044.f364717657cdc0423a4a301f8ed20c40@lists.automattic.com>
References: <044.f364717657cdc0423a4a301f8ed20c40@lists.automattic.com>
Message-ID: <053.94137990263253ce1b5b2ea0b9853f29@lists.automattic.com>
#4616: is_email isn't rfc2822 conformant
-----------------------+----------------------------------------------------
Reporter: hendry | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-----------------------+----------------------------------------------------
Comment (by jhodgdon):
Please also consider that the domain part of the address could legally be
"localhost", rather than something.com. This is very useful for test box
set-ups, but is not allowed currently by WordPress.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 15:49:22 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 15:49:35 2007
Subject: [wp-trac] Re: [WordPress Trac] #5298: https atom service document
doesn't point to https collections
In-Reply-To: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
References: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
Message-ID: <052.1432f4313a7394da0daed97e4f6f1b07@lists.automattic.com>
#5298: https atom service document doesn't point to https collections
-----------------------+----------------------------------------------------
Reporter: rubys | Owner: westi
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: has-patch |
-----------------------+----------------------------------------------------
Changes (by rubys):
* cc: rubys (added)
Comment:
Am I misreading line 20 in {{{xmlrpc.php}}} incorrectly? The intent of
this patch is to only do this check when fetching the {{{rsd}}} document.
See [http://intertwingly.net/blog/2007/10/31/WordPress-SSL-TLS-and-AtomPub
this post] for background. Some place in the traversal from
{{{http://foo.wordpress.com/}}} => {{{xmlrpc.php?rsd}}} => {{{/wp-
app.php/service}}} => {{{/wp-app.php/posts}}} or {{{/wp-
app.php/attachments}}} there needs to be an indication that {{{https}}}
should be used. Doing this when rendering the front-page would clearly be
overkill. Doing it on every fetch of the service document would be
better. Doing it only when fetching the discovery document seems (to me
at least) to be better yet.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 16:02:34 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 16:03:49 2007
Subject: [wp-trac] Re: [WordPress Trac] #4207: Pluggable DB Down Page
In-Reply-To: <045.2800dbd9e4c15f1a503da1e1102e8f3d@lists.automattic.com>
References: <045.2800dbd9e4c15f1a503da1e1102e8f3d@lists.automattic.com>
Message-ID: <054.b3baa2eba4925a479361f1187a09f021@lists.automattic.com>
#4207: Pluggable DB Down Page
-------------------------+--------------------------------------------------
Reporter: linickx | Owner: darkfate
Type: enhancement | Status: assigned
Priority: low | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+--------------------------------------------------
Changes (by darkfate):
* keywords: needs-patch => has-patch
Comment:
I'm marking this has-patch. If anyone agrees with westi, I encourage them
to make another patch.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 16:12:55 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 16:13:08 2007
Subject: [wp-trac] Re: [WordPress Trac] #5277: Posts are de-categorized when
upgrading to 2.3.x
In-Reply-To: <041.d363f2f691659ddda48b2cc38ea1e1f9@lists.automattic.com>
References: <041.d363f2f691659ddda48b2cc38ea1e1f9@lists.automattic.com>
Message-ID: <050.6894cae653810109154bd142a3b9ae5d@lists.automattic.com>
#5277: Posts are de-categorized when upgrading to 2.3.x
----------------------+-----------------------------------------------------
Reporter: dtc | Owner: anonymous
Type: defect | Status: new
Priority: high | Milestone: 2.3.2
Component: General | Version: 2.3.1
Severity: critical | Resolution:
Keywords: |
----------------------+-----------------------------------------------------
Comment (by darkfate):
So I guess this is happening when a post is in multiple categories?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 16:15:22 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 16:15:34 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.18208f3cea495c540476c67c2b8d90d5@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by darkdragon):
For the sake of KISS, I just kept it as is. I did not realize that it was
supposed to check to see if it is merged. Well, that would probably fix
your issue.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 16:22:32 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 16:22:45 2007
Subject: [wp-trac] Re: [WordPress Trac] #4570: Comment link cannot contain
IRIs
In-Reply-To: <044.dab38c86deb3dff72fd9c19c860747e4@lists.automattic.com>
References: <044.dab38c86deb3dff72fd9c19c860747e4@lists.automattic.com>
Message-ID: <053.0e5f1dec6348dc6cebb54bfdf9e773de@lists.automattic.com>
#4570: Comment link cannot contain IRIs
----------------------+-----------------------------------------------------
Reporter: link92 | Owner: anonymous
Type: defect | Status: closed
Priority: high | Milestone: 2.4
Component: General | Version: 2.0.10
Severity: critical | Resolution: fixed
Keywords: |
----------------------+-----------------------------------------------------
Changes (by darkfate):
* status: new => closed
* resolution: => fixed
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 16:24:43 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 16:24:55 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.4125705f008bcf4fa24c9bb9eba8133f@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by darkdragon):
I added two more patches that fix the issue ryan bought up. I also
realized that the assignment in remove_filter() would actually decrease
time with creating and allocating memory for what would amount to
temporary variables.
I used if statements instead. If the array portion exist, then it will be
deleted and on then. This is a lot less time allocated towards checking
whether it exists and remove it, then the worse case which is check that
it exists, does not exist, create it, destroy it.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 16:26:01 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 16:26:12 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.06974198dfac0e3e5580708b55c27e81@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by darkdragon):
Not to mention the speed boost from not doing the merging each time for
action. Although, I haven't done any speed benchmarks, I don't think it
would be all that terrible.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 16:28:37 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 16:28:49 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.4ce0e29f01ac327ea61a0d41eaf474b3@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by darkdragon):
Replying to [comment:9 ryan]:
> Is there any reason to have both filters and actions in $wp_filter? How
about we separate actions into $wp_action with a merge_actions() function.
Also, do_action() looks like it is always calling merge_filters() instead
of checking to see if that tag is already merged.
After some thought, it would make sense to separate the two, in order to
keep any overriding nature from happening.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 18:34:36 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 18:34:49 2007
Subject: [wp-trac] Re: [WordPress Trac] #4616: is_email isn't rfc2822
conformant
In-Reply-To: <044.f364717657cdc0423a4a301f8ed20c40@lists.automattic.com>
References: <044.f364717657cdc0423a4a301f8ed20c40@lists.automattic.com>
Message-ID: <053.e986b91566c539a44fc4146086edab0c@lists.automattic.com>
#4616: is_email isn't rfc2822 conformant
-----------------------+----------------------------------------------------
Reporter: hendry | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-----------------------+----------------------------------------------------
Comment (by Bobcat):
Both of the proposed implementations above allow '@localhost'.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 18:46:42 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 18:46:54 2007
Subject: [wp-trac] Re: [WordPress Trac] #4570: Comment link cannot contain
IRIs
In-Reply-To: <044.dab38c86deb3dff72fd9c19c860747e4@lists.automattic.com>
References: <044.dab38c86deb3dff72fd9c19c860747e4@lists.automattic.com>
Message-ID: <053.24fa6ceb4017383f563eacfb6a5c56ff@lists.automattic.com>
#4570: Comment link cannot contain IRIs
----------------------+-----------------------------------------------------
Reporter: link92 | Owner: anonymous
Type: defect | Status: reopened
Priority: high | Milestone: 2.4
Component: General | Version: 2.0.10
Severity: critical | Resolution:
Keywords: |
----------------------+-----------------------------------------------------
Changes (by westi):
* status: closed => reopened
* resolution: fixed =>
Comment:
Not sure this is currently fixed - just filterable leaving open for now.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 18:53:48 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 18:54:00 2007
Subject: [wp-trac] Re: [WordPress Trac] #5287: Setup table names inside wpdb
In-Reply-To: <042.da84756ea2414992e580e5855b8966f4@lists.automattic.com>
References: <042.da84756ea2414992e580e5855b8966f4@lists.automattic.com>
Message-ID: <051.aaf9d37592a63f766d30ae93228f87a1@lists.automattic.com>
#5287: Setup table names inside wpdb
---------------------+------------------------------------------------------
Reporter: ryan | Owner: ryan
Type: defect | Status: closed
Priority: normal | Milestone: 2.4
Component: General | Version: 2.4
Severity: normal | Resolution: fixed
Keywords: wpdb |
---------------------+------------------------------------------------------
Comment (by westi):
Replying to [comment:2 westi]:
> Don't we need to use the function too?
I see this slipped into a previous checkin ;-)
http://trac.wordpress.org/changeset/6299#file6
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 20:23:08 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 20:23:20 2007
Subject: [wp-trac] Re: [WordPress Trac] #5261: Array issues in plugins.php
In-Reply-To: <050.881ca25f5bcc91a94d201933b40a7a86@lists.automattic.com>
References: <050.881ca25f5bcc91a94d201933b40a7a86@lists.automattic.com>
Message-ID: <059.46c4af92146e7730e54f73f2989e75ff@lists.automattic.com>
#5261: Array issues in plugins.php
--------------------------+-------------------------------------------------
Reporter: aroundmyroom | Owner: anonymous
Type: defect | Status: closed
Priority: high | Milestone:
Component: General | Version: 2.3
Severity: normal | Resolution: worksforme
Keywords: has-patch |
--------------------------+-------------------------------------------------
Changes (by Nazgul):
* milestone: 2.3.2 =>
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 22:17:55 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 22:18:09 2007
Subject: [wp-trac] [WordPress Trac] #5318: 'Next page' link broken when
using slug that contains the word 'page'
Message-ID: <046.523b3650b7f27d73afdf09fa19b8b366@lists.automattic.com>
#5318: 'Next page' link broken when using slug that contains the word 'page'
----------------------+-----------------------------------------------------
Reporter: Eminence | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: major | Keywords:
----------------------+-----------------------------------------------------
The 'Next page' and 'Previous page' links are broken when you're are
browsing posts in a category that has 'page' in it's slug. For example:
You are at: http://yourblog.com/index.php/category/frontpage/page/2/
The previous page link incorrectly points to:
http://yourblog/index.php/category/front
The next page link incorrectly points to:
http://yourblog/index.php/category/front/page/3/
(the correct links should be /index.php/category/frontpage/ and
/index.php/category/frontpage/page/3/)
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 22:33:03 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 22:33:19 2007
Subject: [wp-trac] Re: [WordPress Trac] #2959: wp_list_pages does not add
current_page_item class on page_for_posts
In-Reply-To: <046.f1e112f412166f2ae24fc66d92bb4075@lists.automattic.com>
References: <046.f1e112f412166f2ae24fc66d92bb4075@lists.automattic.com>
Message-ID: <055.303a39d8f5f46d809daa8f1b10f1f0d2@lists.automattic.com>
#2959: wp_list_pages does not add current_page_item class on page_for_posts
-------------------------+--------------------------------------------------
Reporter: skeltoac | Owner: ariejan
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: Template | Version: 2.1
Severity: normal | Resolution:
Keywords: needs-patch |
-------------------------+--------------------------------------------------
Changes (by ariejan):
* owner: ryan => ariejan
* status: new => assigned
Comment:
Ping
Does anyone know why this bug hasn't been fixed yet? Are there any
problems in particular that prevent this bug from being fixed?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 23:30:11 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 23:30:26 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.c2a118a49e663f0bcbca83f5bd80743c@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by ryan):
Indeed. Add the separation of filters and actions to your patch and I
think we're good.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Sun Nov 4 23:49:07 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Sun Nov 4 23:49:24 2007
Subject: [wp-trac] Re: [WordPress Trac] #5162: Extract additional image
metadata from EXIF/IPTC
In-Reply-To: <048.167ac8101c240703239b04ac9b19f27f@lists.automattic.com>
References: <048.167ac8101c240703239b04ac9b19f27f@lists.automattic.com>
Message-ID: <057.79bb9b738f222dab137f15e3b6460f71@lists.automattic.com>
#5162: Extract additional image metadata from EXIF/IPTC
-------------------------+--------------------------------------------------
Reporter: tellyworth | Owner: ryan
Type: enhancement | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Changes (by ryan):
* owner: anonymous => ryan
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 00:00:44 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 00:00:55 2007
Subject: [wp-trac] Re: [WordPress Trac] #5162: Extract additional image
metadata from EXIF/IPTC
In-Reply-To: <048.167ac8101c240703239b04ac9b19f27f@lists.automattic.com>
References: <048.167ac8101c240703239b04ac9b19f27f@lists.automattic.com>
Message-ID: <057.b47ef0edf1e3e845db2551b10f5002f3@lists.automattic.com>
#5162: Extract additional image metadata from EXIF/IPTC
-------------------------+--------------------------------------------------
Reporter: tellyworth | Owner: ryan
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Changes (by ryan):
* milestone: 2.5 => 2.4
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 01:05:57 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 01:06:09 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.23db0c7475314128f79adf343e106a59@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by darkdragon):
Well, what you have to realize is that I'm insane and that is a no can do,
unless you want me to rewrite the entire Plugin Library into an Object
Oriented approach. I'll let someone more sane do what you wish.
Unless you just want me to append '_action' to all actions and '_filter'
to all filters for removing, adding, and calling.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 03:20:25 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 03:20:38 2007
Subject: [wp-trac] [WordPress Trac] #5319: Single post feeds
Message-ID: <048.22454d3e8be8884f4c77b4a2e82a9e76@lists.automattic.com>
#5319: Single post feeds
-------------------------+--------------------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Keywords:
-------------------------+--------------------------------------------------
The included patch adds a .../feed/post/ rewrite rule that allows fetching
a single post as an XML feed. Sort of a complementary to the post
comments feed.
http://example.com//2007/09/04/simple-markup-test/feed/ - the post
comments feed
http://example.com//2007/09/04/simple-markup-test/feed/post/ - the single
post content feed
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 03:33:02 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 03:33:13 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.dab2c5ead312216cefb36961051cc73f@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by ryan):
Perhaps I'm insane because I don't see why you can't just separate
add_action from add_filter and use separate arrays for filters and
actions. Full separation of the two. I'll write it, just want to make
sure I'm not missing something.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 03:39:24 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 03:39:35 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.b4a771cf7b2565be3785a567fee8cd46@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by darkdragon):
Duplicate code? Why would you have similar code in two different places
when you have code in one place and called in two different places. I
can't do that, but if you're willing then I think it would work.
Dude, I cringe whenever I look at the similar code branches in do_action,
apply_filters, and do_action_ref_array. About lose my sanity I do.
Although, I have no non-drastic solution. Just purely maddening.
The classes I threw together would require a couple more hours. I just
don't see myself finishing it when your solution would only take about 30
minutes to an hour (testing included), if even that.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 04:12:10 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 04:12:22 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.c08b6cea9060a1fb5abda426a9214cea@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by darkdragon):
Well, to clarify, I did think about separation, but I do rather like
having one function do all of the work. In the class, basically, I had one
method that would take the $tag, $function_to_add, $priority, and
$accepted_args and build the array, and then return it.
Damn it! I just realized that the code I wrote wouldn't work! Damn you
coordinate system! You '''have''' to duplicate the addition code! I was
thinking an assignment from an function would work, but it wouldn't. If
you did that you would overwrite everything that was in the array and
would only store the new tag system.
You also can't easily assign it to a variable and then use it in the array
(tried that, pretty worthless).
An extra three lines in add_action won't hurt anything. It would
completely decouple filters from actions, which would require that the
Plugin API documentation at the codex be updated.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 04:34:25 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 04:34:37 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.56a48db278d240140d6bb6e889e8fcfa@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by darkdragon):
Well, you know, the patch failed. Sigh. Oh well, I'll just let you do it
then.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 05:01:22 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 05:01:37 2007
Subject: [wp-trac] Re: [WordPress Trac] #2959: wp_list_pages does not add
current_page_item class on page_for_posts
In-Reply-To: <046.f1e112f412166f2ae24fc66d92bb4075@lists.automattic.com>
References: <046.f1e112f412166f2ae24fc66d92bb4075@lists.automattic.com>
Message-ID: <055.d368a7fad7b0aa231293d0863b0437c0@lists.automattic.com>
#2959: wp_list_pages does not add current_page_item class on page_for_posts
-------------------------+--------------------------------------------------
Reporter: skeltoac | Owner: ariejan
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: Template | Version: 2.1
Severity: normal | Resolution:
Keywords: needs-patch |
-------------------------+--------------------------------------------------
Comment (by lloydbudd):
ariejan, "needs-patch"
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 05:19:14 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 05:19:27 2007
Subject: [wp-trac] Re: [WordPress Trac] #5319: Single post feeds
In-Reply-To: <048.22454d3e8be8884f4c77b4a2e82a9e76@lists.automattic.com>
References: <048.22454d3e8be8884f4c77b4a2e82a9e76@lists.automattic.com>
Message-ID: <057.a042aaf742c4f3d4beb5995d3b0b7a88@lists.automattic.com>
#5319: Single post feeds
-------------------------+--------------------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by lloydbudd):
This is an interesting idea, but I can't help but wonder if it is dodging
a question ;-) Is a more meaningful experience to define including the
post in the comment feed as well.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 05:31:10 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 05:31:23 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.a3babf96bbbd85f603ffc860cc61c4c5@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by ryan):
Using the array union operators means that duplicated keys won't be
overwritten. I think we should just forget about giving all a priority and
just fire the all hooks either before or after the regular hooks. No
merge needed.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 05:51:35 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 05:51:49 2007
Subject: [wp-trac] Re: [WordPress Trac] #4469: Accept 'open' and 'closed' as
valid values for mt_allow_comments and mt_allow_pings in XML-RPC
In-Reply-To: <049.594049e1c352a680bc0a1ed7b26dc8da@lists.automattic.com>
References: <049.594049e1c352a680bc0a1ed7b26dc8da@lists.automattic.com>
Message-ID: <058.ea7389258f558cc46f350c04f2117d8f@lists.automattic.com>
#4469: Accept 'open' and 'closed' as valid values for mt_allow_comments and
mt_allow_pings in XML-RPC
-------------------------+--------------------------------------------------
Reporter: josephscott | Owner: anonymous
Type: defect | Status: closed
Priority: normal | Milestone: 2.2.1
Component: XML-RPC | Version: 2.2
Severity: normal | Resolution: fixed
Keywords: has-patch |
-------------------------+--------------------------------------------------
Comment (by yatrip):
New patch for the 2.2 branch. [http://www.yatrip.com ????]
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 06:56:24 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 06:56:39 2007
Subject: [wp-trac] Re: [WordPress Trac] #4517: Bundle Sandbox theme,
and also set 'sandbox' as the default template for themes without a
stylesheet
In-Reply-To: <050.c175d069caf74346d426b69b67b5ff3b@lists.automattic.com>
References: <050.c175d069caf74346d426b69b67b5ff3b@lists.automattic.com>
Message-ID: <059.1bd11d0b501a28e3ed024145977db389@lists.automattic.com>
#4517: Bundle Sandbox theme, and also set 'sandbox' as the default template for
themes without a stylesheet
------------------------------+---------------------------------------------
Reporter: JeremyVisser | Owner: anonymous
Type: enhancement | Status: new
Priority: low | Milestone: 2.4
Component: Template | Version:
Severity: minor | Resolution:
Keywords: has-patch commit |
------------------------------+---------------------------------------------
Comment (by Speedboxer):
Patch '''4517-bundle-sandbox-1.0.diff''' adds Sandbox 1.0 as a bundled
theme. It's added in wp-includes/theme.php also.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 06:57:17 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 06:57:32 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.5e9d8aa28ec1958e20162950692139cc@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by ryan):
Patch gets rid of the merge entirely. 'all' filters and actions are done
first, followed by the filter or action being invoked. Filters and
actions are separated completely. The xdebug profiler shows notable
speedup in add_action() and add_filter() with apply_filters() and
do_action() being about the same speed as before.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 07:01:37 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 07:01:49 2007
Subject: [wp-trac] Re: [WordPress Trac] #5319: Single post feeds
In-Reply-To: <048.22454d3e8be8884f4c77b4a2e82a9e76@lists.automattic.com>
References: <048.22454d3e8be8884f4c77b4a2e82a9e76@lists.automattic.com>
Message-ID: <057.c7e921f59039a49fc165f7319dab9380@lists.automattic.com>
#5319: Single post feeds
-------------------------+--------------------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by tellyworth):
Ideally, sure, but the RSS specs in particular don't provide a clean way
to do that.
I went with this solution (to meet an esoteric requirement) because the
only code required was on the rewrite side. I guess the general issue
being solved here is: the query and feed code support this feature, but
it's not exposed as a clean URL.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 08:12:02 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 08:12:15 2007
Subject: [wp-trac] [WordPress Trac] #5320: Improve performance of
seems_utf8() and uf8_uri_encode()
Message-ID: <042.e95d5b14c874885ee2f7f7715ef543a6@lists.automattic.com>
#5320: Improve performance of seems_utf8() and uf8_uri_encode()
---------------------+------------------------------------------------------
Reporter: ryan | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Keywords: performance
---------------------+------------------------------------------------------
seems_utf8() and uf8_uri_encode() call strlen() several times within
loops. strlen() only needs to be called once and its result assigned to a
variable that is tested within the loops.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 08:17:14 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 08:17:26 2007
Subject: [wp-trac] [WordPress Trac] #5321: when post title or content contain
".htaccess", post can't be saved
Message-ID: <045.4031670bd99d7507e4caa89e6506209d@lists.automattic.com>
#5321: when post title or content contain ".htaccess",post can't be saved
---------------------+------------------------------------------------------
Reporter: netrobo | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Keywords:
---------------------+------------------------------------------------------
when post title or content contain ".htaccess",post can't be saved.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 09:18:36 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 09:18:47 2007
Subject: [wp-trac] Re: [WordPress Trac] #5321: when post title or content
contain ".htaccess", post can't be saved
In-Reply-To: <045.4031670bd99d7507e4caa89e6506209d@lists.automattic.com>
References: <045.4031670bd99d7507e4caa89e6506209d@lists.automattic.com>
Message-ID: <054.5bb542a97eec4eb9bcec62b926328ddf@lists.automattic.com>
#5321: when post title or content contain ".htaccess",post can't be saved
---------------------+------------------------------------------------------
Reporter: netrobo | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
---------------------+------------------------------------------------------
Comment (by DD32):
Unable to reproduce on trunk.
My guess is that mod_security or another security package on the server is
blocking it rather than WordPress.
What is the actual error message and what version of WordPress is it?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 11:06:01 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 11:06:14 2007
Subject: [wp-trac] Re: [WordPress Trac] #5321: when post title or content
contain ".htaccess", post can't be saved
In-Reply-To: <045.4031670bd99d7507e4caa89e6506209d@lists.automattic.com>
References: <045.4031670bd99d7507e4caa89e6506209d@lists.automattic.com>
Message-ID: <054.3920929d8958d45c4e73f8fdf1e99990@lists.automattic.com>
#5321: when post title or content contain ".htaccess",post can't be saved
---------------------+------------------------------------------------------
Reporter: netrobo | Owner: anonymous
Type: defect | Status: closed
Priority: normal | Milestone:
Component: General | Version:
Severity: normal | Resolution: invalid
Keywords: |
---------------------+------------------------------------------------------
Changes (by markjaquith):
* status: new => closed
* resolution: => invalid
* milestone: 2.5 =>
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 13:57:04 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 13:57:21 2007
Subject: [wp-trac] Re: [WordPress Trac] #5277: Posts are de-categorized when
upgrading to 2.3.x
In-Reply-To: <041.d363f2f691659ddda48b2cc38ea1e1f9@lists.automattic.com>
References: <041.d363f2f691659ddda48b2cc38ea1e1f9@lists.automattic.com>
Message-ID: <050.841f9cf6113f9c4e97578a7c98f5b355@lists.automattic.com>
#5277: Posts are de-categorized when upgrading to 2.3.x
----------------------+-----------------------------------------------------
Reporter: dtc | Owner: anonymous
Type: defect | Status: new
Priority: high | Milestone: 2.3.2
Component: General | Version: 2.3.1
Severity: critical | Resolution:
Keywords: |
----------------------+-----------------------------------------------------
Comment (by dtc):
No, it happens also when the post is in a single category. The errors
appear on a server powered by WAMP. Increasing memory usage does not solve
the errors (server set to use 64+ MB for script usage).
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 14:01:51 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 14:35:29 2007
Subject: [wp-trac] Re: [WordPress Trac] #5318: 'Next page' link broken when
using slug that contains the word 'page'
In-Reply-To: <046.523b3650b7f27d73afdf09fa19b8b366@lists.automattic.com>
References: <046.523b3650b7f27d73afdf09fa19b8b366@lists.automattic.com>
Message-ID: <055.d0194af423114db401b6007814870a7c@lists.automattic.com>
#5318: 'Next page' link broken when using slug that contains the word 'page'
----------------------+-----------------------------------------------------
Reporter: Eminence | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: major | Resolution:
Keywords: |
----------------------+-----------------------------------------------------
Comment (by xknown):
The attached patch against trunk seems to fix the problem.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 14:49:16 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 15:29:20 2007
Subject: [wp-trac] Re: [WordPress Trac] #1258: Curly quotes mixups
In-Reply-To: <055.a30f0e860d0436f770378729f9ecdbdb@lists.automattic.com>
References: <055.a30f0e860d0436f770378729f9ecdbdb@lists.automattic.com>
Message-ID: <064.c52049d10109c9c81f5518ea377c34cb@lists.automattic.com>
#1258: Curly quotes mixups
-------------------------------+--------------------------------------------
Reporter: Denis de Bernardy | Owner:
Type: defect | Status: closed
Priority: normal | Milestone: 2.4
Component: Template | Version: 2.1
Severity: normal | Resolution: worksforme
Keywords: needs-patch |
-------------------------------+--------------------------------------------
Changes (by pishmishy):
* status: new => closed
* resolution: => worksforme
Comment:
I can't seem to replicate this in the trunk as of today. Posting:
'hello', 'world', 'tis
Appears to balance the quotes correctly.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 15:50:54 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 15:51:06 2007
Subject: [wp-trac] Re: [WordPress Trac] #1748: root-relative links should be
converted to absolute in rss feeds
In-Reply-To: <051.03ffb7e7087e4840dcc92964667f9afb@lists.automattic.com>
References: <051.03ffb7e7087e4840dcc92964667f9afb@lists.automattic.com>
Message-ID: <060.82b3daa636b1de28d53fe20a7908f418@lists.automattic.com>
#1748: root-relative links should be converted to absolute in rss feeds
---------------------------+------------------------------------------------
Reporter: digitalgimpus | Owner: markjaquith
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version: 1.5.2
Severity: normal | Resolution:
Keywords: needs-patch |
---------------------------+------------------------------------------------
Changes (by pishmishy):
* summary: relative links should be converted to absolute in rss feeds
=> root-relative links should be converted to
absolute in rss feeds
Comment:
I don't believe that there's a full solution to this ticket. The intended
destination of a relative link inside a post is ambiguous. A relative link
to foo/bar.html can link to http://myblog.com/foo/bar.html on the main
page, http://myblog.com/category/uncategorized/foo/bar.html in the
archives and http://myblog.com/2007/11/05/8/foo/bar.html when viewing a
single post.
What we can do is attempt to fix "root-relative" links (those starting in
/). I'm not sure this is worth fixing. Can someone point to the place
where relative links are not allowed?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 16:44:16 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 16:44:30 2007
Subject: [wp-trac] Re: [WordPress Trac] #5307: Partially back out changeset
5273, ticket 5181
In-Reply-To: <043.b9d3324220a43283ac4f7575844c9189@lists.automattic.com>
References: <043.b9d3324220a43283ac4f7575844c9189@lists.automattic.com>
Message-ID: <052.a853f3d8d62ce61cefda9811b19ad68d@lists.automattic.com>
#5307: Partially back out changeset 5273, ticket 5181
-----------------------+----------------------------------------------------
Reporter: rubys | Owner: westi
Type: defect | Status: new
Priority: high | Milestone: 2.4
Component: General | Version: 2.4
Severity: major | Resolution:
Keywords: has-patch |
-----------------------+----------------------------------------------------
Changes (by josephscott):
* cc: josephscott (added)
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 16:50:35 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 16:50:52 2007
Subject: [wp-trac] Re: [WordPress Trac] #1258: Curly quotes mixups
In-Reply-To: <055.a30f0e860d0436f770378729f9ecdbdb@lists.automattic.com>
References: <055.a30f0e860d0436f770378729f9ecdbdb@lists.automattic.com>
Message-ID: <064.9350cea14e1b59b75b2c03bc5558f5c5@lists.automattic.com>
#1258: Curly quotes mixups
-------------------------------+--------------------------------------------
Reporter: Denis de Bernardy | Owner:
Type: defect | Status: closed
Priority: normal | Milestone:
Component: Template | Version: 2.1
Severity: normal | Resolution: worksforme
Keywords: needs-patch |
-------------------------------+--------------------------------------------
Changes (by lloydbudd):
* milestone: 2.4 =>
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 17:03:16 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 18:30:29 2007
Subject: [wp-trac] Re: [WordPress Trac] #5235: Add Pre-flight checks to
install
In-Reply-To: <043.6b0b82bc5f7a4f58b82fdc1066a79dd2@lists.automattic.com>
References: <043.6b0b82bc5f7a4f58b82fdc1066a79dd2@lists.automattic.com>
Message-ID: <052.6c3082269704bd455184e15020b0d4a6@lists.automattic.com>
#5235: Add Pre-flight checks to install
-------------------------+--------------------------------------------------
Reporter: westi | Owner: pishmishy
Type: enhancement | Status: assigned
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: needs-patch |
-------------------------+--------------------------------------------------
Changes (by pishmishy):
* owner: anonymous => pishmishy
* status: new => assigned
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 18:53:58 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 18:54:10 2007
Subject: [wp-trac] Re: [WordPress Trac] #5277: Posts are de-categorized when
upgrading to 2.3.x
In-Reply-To: <041.d363f2f691659ddda48b2cc38ea1e1f9@lists.automattic.com>
References: <041.d363f2f691659ddda48b2cc38ea1e1f9@lists.automattic.com>
Message-ID: <050.3f8a4e448e0dd7267f832007c9058519@lists.automattic.com>
#5277: Posts are de-categorized when upgrading to 2.3.x
----------------------+-----------------------------------------------------
Reporter: dtc | Owner: anonymous
Type: defect | Status: new
Priority: high | Milestone: 2.3.2
Component: General | Version: 2.3.1
Severity: critical | Resolution:
Keywords: |
----------------------+-----------------------------------------------------
Comment (by darkfate):
Well I guess it might have something to do with tagging.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 18:56:59 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 18:57:12 2007
Subject: [wp-trac] [WordPress Trac] #5322: RSS feed managemenet
Message-ID: <046.b051d42917554c6626431a079be1f6c8@lists.automattic.com>
#5322: RSS feed managemenet
----------------------------+-----------------------------------------------
Reporter: jdingman | Owner: anonymous
Type: enhancement | Status: new
Priority: low | Milestone: 2.5
Component: Administration | Version:
Severity: minor | Keywords: rss feed
----------------------------+-----------------------------------------------
There's presently no way to manage what the RSS feed outputs.
I'm suggesting that there be a way to manage which categories are either
included or excluded from all feeds.
being able to select particular categories to NOT be fed to subscribers
would be a huge help.
let me know if you need clarification beyond what I wrote.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 19:11:00 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 19:11:14 2007
Subject: [wp-trac] Re: [WordPress Trac] #5322: RSS feed managemenet
In-Reply-To: <046.b051d42917554c6626431a079be1f6c8@lists.automattic.com>
References: <046.b051d42917554c6626431a079be1f6c8@lists.automattic.com>
Message-ID: <055.3eed7d63225dea822f0b9aee4f0dc245@lists.automattic.com>
#5322: RSS feed managemenet
----------------------------+-----------------------------------------------
Reporter: jdingman | Owner: anonymous
Type: enhancement | Status: new
Priority: low | Milestone: 2.5
Component: Administration | Version:
Severity: minor | Resolution:
Keywords: rss feed |
----------------------------+-----------------------------------------------
Comment (by jdingman):
Update,
http://zeo.unic.net.my/notes/exclude-category-in-wordpress/
this does the same thing for excluding particular categories, but it would
be great if there was a user-friendly way to do it rather than having to
search Google, then implement a function.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Mon Nov 5 19:52:14 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Mon Nov 5 19:52:25 2007
Subject: [wp-trac] Re: [WordPress Trac] #5007: Email notifications fail on
hosted sites that check sender address
In-Reply-To: <046.09634736e941d3d69c41a4793e947266@lists.automattic.com>
References: <046.09634736e941d3d69c41a4793e947266@lists.automattic.com>
Message-ID: <055.175f6455749dc979318d62416e3aa7eb@lists.automattic.com>
#5007: Email notifications fail on hosted sites that check sender address
------------------------+---------------------------------------------------
Reporter: jlwarlow | Owner: anonymous
Type: defect | Status: reopened
Priority: low | Milestone: 2.3.2
Component: General | Version: 2.2.2
Severity: minor | Resolution:
Keywords: regression |
------------------------+---------------------------------------------------
Comment (by mattyrob):
Replying to [comment:13 westi]:
> > I'm pretty sure we used to use the admin address at one point - I
can't remember exactly why it changed to the current method.
My plugin tries to pull the admin details including the address - I often
run into support issues because users have deleted the admin entry (ID =
1) from the database. This may be why that method is no longer used. It
may also be because the supplied email could be on a different domain than
the blog.
I think future work on using a valid email would be good. In the meantime
I guess we'll have to reverse this change. :-(
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 00:48:28 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 00:48:42 2007
Subject: [wp-trac] Re: [WordPress Trac] #5322: RSS feed managemenet
In-Reply-To: <046.b051d42917554c6626431a079be1f6c8@lists.automattic.com>
References: <046.b051d42917554c6626431a079be1f6c8@lists.automattic.com>
Message-ID: <055.e58b76a7edf43063c811fda8a1bf8841@lists.automattic.com>
#5322: RSS feed managemenet
----------------------------+-----------------------------------------------
Reporter: jdingman | Owner: anonymous
Type: enhancement | Status: new
Priority: low | Milestone: 2.5
Component: Administration | Version:
Severity: minor | Resolution:
Keywords: rss feed |
----------------------------+-----------------------------------------------
Comment (by Viper007Bond):
Plugin territory IMO 'cause as that link shows, it's super easy to do.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 00:57:56 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 00:58:10 2007
Subject: [wp-trac] Re: [WordPress Trac] #4857: More issues with wpautop()
In-Reply-To: <050.edcf1e5c35f85246856f317f877f1a56@lists.automattic.com>
References: <050.edcf1e5c35f85246856f317f877f1a56@lists.automattic.com>
Message-ID: <059.bf9e2cdfc6f1b27aaaa1d96ec40a6b93@lists.automattic.com>
#4857: More issues with wpautop()
---------------------------------+------------------------------------------
Reporter: Viper007Bond | Owner: mdawaffe
Type: defect | Status: assigned
Priority: low | Milestone: 2.4
Component: Template | Version: 2.3
Severity: normal | Resolution:
Keywords: wpautop needs-patch |
---------------------------------+------------------------------------------
Changes (by mdawaffe):
* keywords: needs-patch => wpautop needs-patch
* owner: anonymous => mdawaffe
* status: new => assigned
Comment:
I look at your first (and second) example and expect the paragraph to only
wrap around "Foo":
{{{
Foo
Bar
}}}
since paragraph elements can only contain inline content*. For that
reason, I do not expect the paragraph to wrap the whole thing:
{{{
mdawaffe thinks this is wrong
Foo
Bar
}}}
* http://www.w3.org/TR/xhtml1/dtds.html#dtdentry_xhtml1-strict.dtd_p
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 05:47:41 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 05:47:54 2007
Subject: [wp-trac] Re: [WordPress Trac] #5309: 'Insert/edit image' dialog
changes empty fields to default values
In-Reply-To: <050.53707c0c3ba758b7438f2e8ad82fbb23@lists.automattic.com>
References: <050.53707c0c3ba758b7438f2e8ad82fbb23@lists.automattic.com>
Message-ID: <059.67405f1fc70eb10322afc8093d98598e@lists.automattic.com>
#5309: 'Insert/edit image' dialog changes empty fields to default values
-------------------------------+--------------------------------------------
Reporter: hermanschaap | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: reporter-feedback |
-------------------------------+--------------------------------------------
Comment (by hermanschaap):
I am using Internet Explorer and Windows Vista. And yes, it looks like it
is related to #5087.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 12:06:53 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 12:07:06 2007
Subject: [wp-trac] Re: [WordPress Trac] #5235: Add Pre-flight checks to
install
In-Reply-To: <043.6b0b82bc5f7a4f58b82fdc1066a79dd2@lists.automattic.com>
References: <043.6b0b82bc5f7a4f58b82fdc1066a79dd2@lists.automattic.com>
Message-ID: <052.3e7cccd102b920d817f130ed15e80984@lists.automattic.com>
#5235: Add Pre-flight checks to install
-------------------------+--------------------------------------------------
Reporter: westi | Owner: pishmishy
Type: enhancement | Status: assigned
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: needs-patch |
-------------------------+--------------------------------------------------
Comment (by pishmishy):
I've added a rough draft of a potential preflight check. I don't know if
this is the sort of direction people would like to see it take, so I'd
appreciate any feedback.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 14:35:46 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 14:35:58 2007
Subject: [wp-trac] Re: [WordPress Trac] #5322: RSS feed management
In-Reply-To: <046.b051d42917554c6626431a079be1f6c8@lists.automattic.com>
References: <046.b051d42917554c6626431a079be1f6c8@lists.automattic.com>
Message-ID: <055.30db4f63de7e683b45be15252279a205@lists.automattic.com>
#5322: RSS feed management
----------------------------+-----------------------------------------------
Reporter: jdingman | Owner: anonymous
Type: enhancement | Status: new
Priority: low | Milestone: 2.5
Component: Administration | Version:
Severity: minor | Resolution:
Keywords: rss feed |
----------------------------+-----------------------------------------------
Changes (by santosj):
* summary: RSS feed managemenet => RSS feed management
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 14:51:41 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 14:51:54 2007
Subject: [wp-trac] [WordPress Trac] #5323: Write Post / Page inadvertently
redirects when adding a custom field without first saving the post
Message-ID: <047.aa89e65bf7b76cfb8c869e797bc9bf67@lists.automattic.com>
#5323: Write Post / Page inadvertently redirects when adding a custom field
without first saving the post
-----------------------+----------------------------------------------------
Reporter: minusfive | Owner: anonymous
Type: defect | Status: new
Priority: high | Milestone: 2.3.2
Component: General | Version: 2.3.1
Severity: normal | Keywords: write post page custom field save redirect
-----------------------+----------------------------------------------------
If you try to add a custom field to a new post / page, without first
saving it (i.e. "Save and continue editing", "Save" or "Publish"),
WordPress will kick you out / redirect you away from the write screen
without giving you an option to save the post, and will arbitrarily save
the post as an unpublished, title-less POST even if it was originally
being created from the Write Page screen.
Hope I explained myself correctly :)
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 14:56:00 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 14:56:11 2007
Subject: [wp-trac] Re: [WordPress Trac] #5323: Write Post / Page
inadvertently
redirects when adding a custom field without first saving the post
In-Reply-To: <047.aa89e65bf7b76cfb8c869e797bc9bf67@lists.automattic.com>
References: <047.aa89e65bf7b76cfb8c869e797bc9bf67@lists.automattic.com>
Message-ID: <056.e8bd529728e103aa22ff03b146639a69@lists.automattic.com>
#5323: Write Post / Page inadvertently redirects when adding a custom field
without first saving the post
--------------------------------------------------------+-------------------
Reporter: minusfive | Owner: anonymous
Type: defect | Status: new
Priority: high | Milestone: 2.3.2
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: write post page custom field save redirect |
--------------------------------------------------------+-------------------
Comment (by pishmishy):
This doesn't happen with me and the development code.
Is there anything odd about your environment?
Could it be your browser doing something odd?
James
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 15:13:20 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 15:13:32 2007
Subject: [wp-trac] Re: [WordPress Trac] #5308: continued cookie error after
upgrade to 2.3.1
In-Reply-To: <052.3fcc8555e8279abfcbc42cd6050736c0@lists.automattic.com>
References: <052.3fcc8555e8279abfcbc42cd6050736c0@lists.automattic.com>
Message-ID: <061.d2e3a4dc0b954f2ae7f6735d8e979899@lists.automattic.com>
#5308: continued cookie error after upgrade to 2.3.1
----------------------------+-----------------------------------------------
Reporter: openlycreative | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: cookie error |
----------------------------+-----------------------------------------------
Comment (by openlycreative):
I am really not happy with the lack of support on this issue. I have been
using WordPress for quite a while now and have had several issues with
lack of response to issues on the message boards in the past and
(apparently) here as well.
I don't want to have to sink several hundred dollars into a CMS if I don't
have to, but the lack of support is a big problem for me. This "cookie
error" is causing problems for my clients and I just can't have that.
Opensource is great, but only if there is a dedicated staff to debug these
kinds of issues.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 15:17:42 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 15:17:54 2007
Subject: [wp-trac] Re: [WordPress Trac] #5308: continued cookie error after
upgrade to 2.3.1
In-Reply-To: <052.3fcc8555e8279abfcbc42cd6050736c0@lists.automattic.com>
References: <052.3fcc8555e8279abfcbc42cd6050736c0@lists.automattic.com>
Message-ID: <061.4acb134b4d46690153d61f25bd949298@lists.automattic.com>
#5308: continued cookie error after upgrade to 2.3.1
----------------------------+-----------------------------------------------
Reporter: openlycreative | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: cookie error |
----------------------------+-----------------------------------------------
Comment (by pishmishy):
Please can you precisely describe how to replicate the "cookie error", we
can then work on fixing the problem.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 16:18:53 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 16:19:06 2007
Subject: [wp-trac] Re: [WordPress Trac] #5322: No options to manage what
categories the RSS feed includes
In-Reply-To: <046.b051d42917554c6626431a079be1f6c8@lists.automattic.com>
References: <046.b051d42917554c6626431a079be1f6c8@lists.automattic.com>
Message-ID: <055.59e714f60c3a0f56da11d2a2679fe461@lists.automattic.com>
#5322: No options to manage what categories the RSS feed includes
----------------------------+-----------------------------------------------
Reporter: jdingman | Owner: anonymous
Type: enhancement | Status: closed
Priority: low | Milestone:
Component: Administration | Version:
Severity: minor | Resolution: wontfix
Keywords: rss feed |
----------------------------+-----------------------------------------------
Changes (by foolswisdom):
* status: new => closed
* summary: RSS feed management => No options to manage what categories
the RSS feed includes
* resolution: => wontfix
* milestone: 2.5 =>
Comment:
I agree with Viper007Bond, plugin territory, closing as won't fixed for
now, pending a compelling experience.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 16:20:05 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 16:20:17 2007
Subject: [wp-trac] Re: [WordPress Trac] #5323: Write Post / Page
inadvertently
redirects when adding a custom field without first saving the post
In-Reply-To: <047.aa89e65bf7b76cfb8c869e797bc9bf67@lists.automattic.com>
References: <047.aa89e65bf7b76cfb8c869e797bc9bf67@lists.automattic.com>
Message-ID: <056.f2c4c8da3ed106da2b54cf7943230d85@lists.automattic.com>
#5323: Write Post / Page inadvertently redirects when adding a custom field
without first saving the post
--------------------------------------------------------+-------------------
Reporter: minusfive | Owner: anonymous
Type: defect | Status: closed
Priority: high | Milestone:
Component: General | Version: 2.3.1
Severity: normal | Resolution: duplicate
Keywords: write post page custom field save redirect |
--------------------------------------------------------+-------------------
Changes (by foolswisdom):
* status: new => closed
* resolution: => duplicate
* milestone: 2.3.2 =>
Comment:
Duplicate of #3700 I think.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 16:20:38 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 16:20:52 2007
Subject: [wp-trac] Re: [WordPress Trac] #3700: Adding a custom field to an
unsaved Page before publishing causes weirdness
In-Reply-To: <049.7b65847c64c66ed3e90fa481e139ade9@lists.automattic.com>
References: <049.7b65847c64c66ed3e90fa481e139ade9@lists.automattic.com>
Message-ID: <058.ba4da13dfaa92fc92aef3127b58c4aa4@lists.automattic.com>
#3700: Adding a custom field to an unsaved Page before publishing causes weirdness
----------------------------+-----------------------------------------------
Reporter: markjaquith | Owner: Andy
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: Administration | Version: 2.1.3
Severity: normal | Resolution:
Keywords: needs-patch |
----------------------------+-----------------------------------------------
Comment (by foolswisdom):
Also reported in #5323
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 16:27:32 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 16:27:45 2007
Subject: [wp-trac] Re: [WordPress Trac] #5308: continued cookie error after
upgrade to 2.3.1
In-Reply-To: <052.3fcc8555e8279abfcbc42cd6050736c0@lists.automattic.com>
References: <052.3fcc8555e8279abfcbc42cd6050736c0@lists.automattic.com>
Message-ID: <061.f0ea8bba1c9270273d8f41643f9209a8@lists.automattic.com>
#5308: continued cookie error after upgrade to 2.3.1
----------------------------+-----------------------------------------------
Reporter: openlycreative | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: cookie error |
----------------------------+-----------------------------------------------
Comment (by foolswisdom):
openlycreative, I understand your frustration. People tend to prioritize
their work based on their own needs and interests. Your note reads a
little bit like you are looking for something for nothing -- I imagine in
reality you have contributed a lot to WordPress through promoting and
deploying to your clients.
if it is costing you money than I suggest you spend money on a solution
and give the solution back to the community. Email the wp-pro list with a
request for quote.
Otherwise as pishmishy suggests, we will need a reproducable scenario. If
you can duplicate the issue with a fresh install from multiple browsers
from multiple computers than it suggests it might be specific to the
server environment -- one of the cookie issues was just that, where
installing to a subdirectory was a factor.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 16:33:53 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 16:34:05 2007
Subject: [wp-trac] Re: [WordPress Trac] #5308: continued cookie error after
upgrade to 2.3.1
In-Reply-To: <052.3fcc8555e8279abfcbc42cd6050736c0@lists.automattic.com>
References: <052.3fcc8555e8279abfcbc42cd6050736c0@lists.automattic.com>
Message-ID: <061.b3b20f5fab0380ba301e5e1922d7a822@lists.automattic.com>
#5308: continued cookie error after upgrade to 2.3.1
----------------------------+-----------------------------------------------
Reporter: openlycreative | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: cookie error |
----------------------------+-----------------------------------------------
Comment (by Michaelh):
Links to related forum topics:
http://wordpress.org/support/topic/141338
http://wordpress.org/support/topic/142244
http://wordpress.org/support/topic/142244
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 16:57:32 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 16:57:45 2007
Subject: [wp-trac] Re: [WordPress Trac] #5308: continued cookie error after
upgrade to 2.3.1
In-Reply-To: <052.3fcc8555e8279abfcbc42cd6050736c0@lists.automattic.com>
References: <052.3fcc8555e8279abfcbc42cd6050736c0@lists.automattic.com>
Message-ID: <061.e34dc0d765264ad5850349f43fabe560@lists.automattic.com>
#5308: continued cookie error after upgrade to 2.3.1
----------------------------+-----------------------------------------------
Reporter: openlycreative | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: cookie error |
----------------------------+-----------------------------------------------
Comment (by pishmishy):
Replying to [comment:4 Michaelh]:
> Links to related forum topics:
Thank you for the links. Unfortunately your posts to the forum don't
contain information on how we can replicate the issue so we can work on
fixing it. Once I can replicate your problem I'd be happy to work on
fixing it.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 17:09:24 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 17:09:36 2007
Subject: [wp-trac] Re: [WordPress Trac] #5308: continued cookie error after
upgrade to 2.3.1
In-Reply-To: <052.3fcc8555e8279abfcbc42cd6050736c0@lists.automattic.com>
References: <052.3fcc8555e8279abfcbc42cd6050736c0@lists.automattic.com>
Message-ID: <061.bf03b12bbbd727a76aeb148835b635fa@lists.automattic.com>
#5308: continued cookie error after upgrade to 2.3.1
----------------------------+-----------------------------------------------
Reporter: openlycreative | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: cookie error |
----------------------------+-----------------------------------------------
Comment (by pishmishy):
Problem may be related to #5076 ?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 18:31:09 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 18:31:21 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.e675946022bddeb26331f771aa02b019@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by ryan):
tellyworth ran unit tests and said it looks alright. Committing.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 18:31:56 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 18:32:08 2007
Subject: [wp-trac] Re: [WordPress Trac] #5181: Refactoring Atom support;
baby step #1
In-Reply-To: <043.0362d55465f275b28bf1b7199dd3e14c@lists.automattic.com>
References: <043.0362d55465f275b28bf1b7199dd3e14c@lists.automattic.com>
Message-ID: <052.72718225e8eae2fb2721425b65ef0efd@lists.automattic.com>
#5181: Refactoring Atom support; baby step #1
--------------------------------+-------------------------------------------
Reporter: rubys | Owner: westi
Type: enhancement | Status: closed
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch has-docs |
--------------------------------+-------------------------------------------
Comment (by foolswisdom):
(In [6315]) Back out some of changeset [5273] from #5181. Props rubys.
fixes #5307
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 18:32:06 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 18:32:18 2007
Subject: [wp-trac] Re: [WordPress Trac] #5232: Get the current action and
current filter name
In-Reply-To: <048.e39d6f1c2954664065e0f72a8fa2351b@lists.automattic.com>
References: <048.e39d6f1c2954664065e0f72a8fa2351b@lists.automattic.com>
Message-ID: <057.19d535f4d68c37cc07ada38d38eab298@lists.automattic.com>
#5232: Get the current action and current filter name
-------------------------+--------------------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+--------------------------------------------------
Comment (by ryan):
Needs update now that #5231 went in.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 19:12:22 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 19:12:34 2007
Subject: [wp-trac] Re: [WordPress Trac] #5298: https atom service document
doesn't point to https collections
In-Reply-To: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
References: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
Message-ID: <052.85456cfdfc86a3fafd1a36d31ea8e28f@lists.automattic.com>
#5298: https atom service document doesn't point to https collections
-----------------------+----------------------------------------------------
Reporter: rubys | Owner: westi
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: has-patch |
-----------------------+----------------------------------------------------
Comment (by westi):
Replying to [comment:5 rubys]:
> Am I misreading line 20 in {{{xmlrpc.php}}} incorrectly? The intent of
this patch is to only do this check when fetching the {{{rsd}}} document.
>
> See [http://intertwingly.net/blog/2007/10/31/WordPress-SSL-TLS-and-
AtomPub this post] for background. Some place in the traversal from
{{{http://foo.wordpress.com/}}} => {{{xmlrpc.php?rsd}}} => {{{/wp-
app.php/service}}} => {{{/wp-app.php/posts}}} or {{{/wp-
app.php/attachments}}} there needs to be an indication that {{{https}}}
should be used. Doing this when rendering the front-page would clearly be
overkill. Doing it on every fetch of the service document would be
better. Doing it only when fetching the discovery document seems (to me
at least) to be better yet.
Sorry - I read the patch too quick :-( Indeed this does only apply when we
are returning the rsd.
I think i would be happier if we moved the check for https availablity out
to a generic function and then just had an apply_filter call in xmlrpc.php
so that a plugin could force a https url without the run-time cost of the
check if the admin knows that https is available for accessing the blog.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 19:30:49 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 19:31:01 2007
Subject: [wp-trac] Re: [WordPress Trac] #5298: https atom service document
doesn't point to https collections
In-Reply-To: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
References: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
Message-ID: <052.3ec650b7d6b5dbd0584009e0c9d6b759@lists.automattic.com>
#5298: https atom service document doesn't point to https collections
-----------------------+----------------------------------------------------
Reporter: rubys | Owner: westi
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: has-patch |
-----------------------+----------------------------------------------------
Comment (by westi):
Could you try that new untested patch on for size?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 20:06:00 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 20:06:11 2007
Subject: [wp-trac] Re: [WordPress Trac] #5298: https atom service document
doesn't point to https collections
In-Reply-To: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
References: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
Message-ID: <052.fe7e66ef54a7b1055e5d6496f06def31@lists.automattic.com>
#5298: https atom service document doesn't point to https collections
-----------------------+----------------------------------------------------
Reporter: rubys | Owner: westi
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: has-patch |
-----------------------+----------------------------------------------------
Comment (by rubys):
Replying to [comment:7 westi]:
> Could you try that new untested patch on for size?
A number of minor issues fixed (unmatched parens in xmlrpc.php,
get_bloginfo does an implicit echo, apply_filters does not do an implicit
echo).
One substantive change: blog_is_accessable_via_ssl() =>
url_is_accessable_via_ssl($url). Two reasons for this (1) on my test site
https://rubix.home/wordpress (note no trailing slash) returns a 404, and
(2) this given the potential plugin the full url and complete freedom to
modify any or all of it.
P.S. s/accessable/accessible/ ?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 20:22:46 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 20:22:56 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.a45072378e01cd3d5a5eed0e15adc869@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: reopened
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Changes (by mdawaffe):
* status: closed => reopened
* resolution: fixed =>
Comment:
With separation of $wp_filter from $wp_action, we need to change some of
the hardcoded references to $wp_filter.
Attached adds $wp_action to unsets in wp-settings.php (necessary?) and
fixes get_plugin_page_hook().
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 20:28:32 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 20:28:44 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.8b17e96ece84f55e66b513dfc828a340@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: reopened
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by ryan):
mdawaffe suggested wrapping these checks in some API. has_filter() and
has_action().
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 20:30:41 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 20:30:52 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.a80a6ffe69739e9ea1436962d33cafd8@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: reopened
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by santosj):
Could it be combined with the functionality to get current hook executed?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 21:07:30 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 21:07:41 2007
Subject: [wp-trac] Re: [WordPress Trac] #5232: Get the current action and
current filter name
In-Reply-To: <048.e39d6f1c2954664065e0f72a8fa2351b@lists.automattic.com>
References: <048.e39d6f1c2954664065e0f72a8fa2351b@lists.automattic.com>
Message-ID: <057.9111c56337b0564bf549e9babd21a359@lists.automattic.com>
#5232: Get the current action and current filter name
-------------------------+--------------------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+--------------------------------------------------
Comment (by tellyworth):
the revised-r6317 patch is a quick update to work with #5231.
It still uses a single $wp_current_filter global to store the current
filter or action name. Perhaps it's worth improving it to store the
filter and action separately.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 21:10:50 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 21:11:01 2007
Subject: [wp-trac] Re: [WordPress Trac] #5232: Get the current action and
current filter name
In-Reply-To: <048.e39d6f1c2954664065e0f72a8fa2351b@lists.automattic.com>
References: <048.e39d6f1c2954664065e0f72a8fa2351b@lists.automattic.com>
Message-ID: <057.432649a1d595d18dad999d60ee8bc398@lists.automattic.com>
#5232: Get the current action and current filter name
-------------------------+--------------------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+--------------------------------------------------
Comment (by santosj):
Given the execution of PHP and the pushing and popping, I don't think it
is worth it. You could put some metadata in along with the tag to say
whether it is an action or a filter. However, creating a separate global
doesn't seem logical.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 21:25:40 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 21:25:55 2007
Subject: [wp-trac] Re: [WordPress Trac] #5298: https atom service document
doesn't point to https collections
In-Reply-To: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
References: <043.116cf70217b5b603829b72ec7fa2a8dd@lists.automattic.com>
Message-ID: <052.ef1f9ee1baee73b8c834df645132768b@lists.automattic.com>
#5298: https atom service document doesn't point to https collections
-----------------------+----------------------------------------------------
Reporter: rubys | Owner: westi
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version: 2.3.1
Severity: normal | Resolution:
Keywords: has-patch |
-----------------------+----------------------------------------------------
Comment (by westi):
Replying to [comment:8 rubys]:
> Replying to [comment:7 westi]:
> > Could you try that new untested patch on for size?
>
> A number of minor issues fixed (unmatched parens in xmlrpc.php,
get_bloginfo does an implicit echo, apply_filters does not do an implicit
echo).
>
> One substantive change: blog_is_accessable_via_ssl() =>
url_is_accessable_via_ssl($url). Two reasons for this (1) on my test site
https://rubix.home/wordpress (note no trailing slash) returns a 404, and
(2) this given the potential plugin the full url and complete freedom to
modify any or all of it.
>
> P.S. s/accessable/accessible/ ?
Thanks for the test and update - I had to run and have dinner so I chucked
up my in progress code!
I'll have a look at getting this checked in tomorrow
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 21:59:12 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 21:59:24 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.1c8d1046d382752ec6868756ff579047@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: reopened
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by ryan):
Patch implements has_filter and has_action and uses them where needed.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Tue Nov 6 23:09:39 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Tue Nov 6 23:13:32 2007
Subject: [wp-trac] [WordPress Trac] #5324: 404 error on empty category page
Message-ID: <050.538ea420ae5db09f3b3a05473e42510b@lists.automattic.com>
#5324: 404 error on empty category page
--------------------------+-------------------------------------------------
Reporter: othellobloke | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Keywords:
--------------------------+-------------------------------------------------
spoken to many people who believe this isn't good functionality and
probably a bug. i'm not a coder so I might be wrong, but i hope not.
wordpress returns a 404 error when a category page is viewed that's empty.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 00:04:18 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 00:04:29 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.d35ab39fb71cf907cd289cd6e7bf72d6@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: reopened
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by mdawaffe):
has_filter_with_arg.diff = has_filter.diff plus the following.
1. {{{has_filter( $tag )}}} improved to return false if
{{{$wp_filter[$tag]}}} is empty (not just if not set).
2. {{{remove_filter( $tag, $func, $priority )}}} improved to unset
{{{$wp_filter[$tag][$priority]}}} as necessary (so that {{{has_filter()}}}
can work).
3. new {{{has_filter( $tag, $function )}}} syntax. Returns
{{{$priority}}} if {{{$function}}} is attached to {{{$tag}}}, {{{false}}}
otherwise.
4. tweak to internally used {{{_wp_filter_build_unique_id()}}} to make
{{{has_filter( $tag, $function )}}} work.
5. same for {{{*_action}}}.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 00:31:13 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 00:31:31 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.4d18a1d46e62d9c83ee20d0f6561e1ef@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: reopened
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by ryan):
{{{
if ( !count($GLOBALS['wp_filter'][$tag][$priority]) )
}}}
Could that be:
{{{
if ( empty($GLOBALS['wp_filter'][$tag][$priority]) )
}}}
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 00:32:19 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 00:32:30 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.60a12683314bc08506c46d905528145f@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: reopened
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by mdawaffe):
Yes, should do.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 03:54:05 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 03:54:22 2007
Subject: [wp-trac] [WordPress Trac] #5325: sanitize_post and
sanitize_post_field are very expensive no-ops
Message-ID: <046.06cd79e4cc702d7e71a8151c9f68b9b5@lists.automattic.com>
#5325: sanitize_post and sanitize_post_field are very expensive no-ops
--------------------------+-------------------------------------------------
Reporter: Quandary | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.3.2
Component: Optimization | Version: 2.3.1
Severity: major | Keywords:
--------------------------+-------------------------------------------------
Simple, commonly-called template functions (the_title, get_permalink,
etc.) are all channeled through the get_post function. While get_post
implements caching, it caches content before it's been filtered, ''not''
after. This means that sanitize_post is called for each and every call to
get_post.
I loaded a test page 5 times in a test configuration that had 86 calls to
get_post (mostly via get_the_title and get_permalink). Instrumentation
results from APD indicate that fully 8-15% (~9.5% avg.) of the page
generation time was spent in sanitize_post and sanitize_post_field, even
though nearly all of the calls were for "raw" data, and no filtering was
actually taking place. I added a simple early bail-out to bypass the no-op
actions, and this reduced the hit to .1-.2% across another 5 page loads
(no, that's not a typo ;).
I'm attaching a patch to fix this bug, but this is only the immediate
problem (get_post appears to be called with "raw" ''way'' more frequently
then with "display"). Opening another bug on the filtering implementation
''may'' be warranted.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 03:59:05 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 03:59:19 2007
Subject: [wp-trac] Re: [WordPress Trac] #5325: sanitize_post and
sanitize_post_field are very expensive no-ops
In-Reply-To: <046.06cd79e4cc702d7e71a8151c9f68b9b5@lists.automattic.com>
References: <046.06cd79e4cc702d7e71a8151c9f68b9b5@lists.automattic.com>
Message-ID: <055.edad62de62def6f0650c049d6e13115d@lists.automattic.com>
#5325: sanitize_post and sanitize_post_field are very expensive no-ops
--------------------------+-------------------------------------------------
Reporter: Quandary | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.3.2
Component: Optimization | Version: 2.3.1
Severity: major | Resolution:
Keywords: has-patch |
--------------------------+-------------------------------------------------
Changes (by Quandary):
* keywords: => has-patch
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 06:21:02 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 06:21:13 2007
Subject: [wp-trac] Re: [WordPress Trac] #5325: sanitize_post and
sanitize_post_field are very expensive no-ops
In-Reply-To: <046.06cd79e4cc702d7e71a8151c9f68b9b5@lists.automattic.com>
References: <046.06cd79e4cc702d7e71a8151c9f68b9b5@lists.automattic.com>
Message-ID: <055.08e7e79d81a19e0d7dfd926fbc9e1c90@lists.automattic.com>
#5325: sanitize_post and sanitize_post_field are very expensive no-ops
--------------------------+-------------------------------------------------
Reporter: Quandary | Owner: anonymous
Type: defect | Status: reopened
Priority: normal | Milestone: 2.3.2
Component: Optimization | Version: 2.3.1
Severity: major | Resolution:
Keywords: has-patch |
--------------------------+-------------------------------------------------
Changes (by ryan):
* status: closed => reopened
* resolution: fixed =>
Comment:
Thanks. Applied to trunk. I also did this for sanitize_term. Nominating
for 2.3 inclusion.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 09:48:58 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 09:49:12 2007
Subject: [wp-trac] Re: [WordPress Trac] #5235: Add Pre-flight checks to
install
In-Reply-To: <043.6b0b82bc5f7a4f58b82fdc1066a79dd2@lists.automattic.com>
References: <043.6b0b82bc5f7a4f58b82fdc1066a79dd2@lists.automattic.com>
Message-ID: <052.f0c33511dad4dd0e3c954673f06035b0@lists.automattic.com>
#5235: Add Pre-flight checks to install
-------------------------+--------------------------------------------------
Reporter: westi | Owner: pishmishy
Type: enhancement | Status: assigned
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+--------------------------------------------------
Changes (by pishmishy):
* keywords: needs-patch => has-patch
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 10:10:34 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 10:10:49 2007
Subject: [wp-trac] Re: [WordPress Trac] #5272: WordPress allows anonymous
user to see slug for private post by guessing post number
In-Reply-To: <045.2ee8ebcf130603e00b7e2e5f88cba146@lists.automattic.com>
References: <045.2ee8ebcf130603e00b7e2e5f88cba146@lists.automattic.com>
Message-ID: <054.275302f5217ec08c4c0421489b55011e@lists.automattic.com>
#5272: WordPress allows anonymous user to see slug for private post by guessing
post number
-------------------------+--------------------------------------------------
Reporter: tzafrir | Owner: pishmishy
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version: 2.3.1
Severity: major | Resolution:
Keywords: needs-patch |
-------------------------+--------------------------------------------------
Changes (by pishmishy):
* owner: anonymous => pishmishy
* status: new => assigned
Comment:
Confirming that the bug exists in trunk. Worth fixing as the slug may have
been automatically derived from post data that the user didn't want to
disclose.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 10:34:20 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 10:34:33 2007
Subject: [wp-trac] Re: [WordPress Trac] #5324: 404 error on empty category
page
In-Reply-To: <050.538ea420ae5db09f3b3a05473e42510b@lists.automattic.com>
References: <050.538ea420ae5db09f3b3a05473e42510b@lists.automattic.com>
Message-ID: <059.03cf9626b60b87b86da3bf20b7588b44@lists.automattic.com>
#5324: 404 error on empty category page
--------------------------+-------------------------------------------------
Reporter: othellobloke | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version: 2.4
Severity: normal | Resolution:
Keywords: needs-patch |
--------------------------+-------------------------------------------------
Changes (by Viper007Bond):
* keywords: => needs-patch
* version: => 2.4
* milestone: 2.5 => 2.4
Comment:
Confirmed on trunk. Displays the error 404 page and sends a 404 header for
the archive view of an empty but existing category.
It should display as normal and when the template check for `have_posts()`
or whatever fails, the "no matching posts" error will be shown.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 10:47:23 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 10:47:37 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.abe103491538ac71382f1eaa6a4db8c0@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: reopened
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by tellyworth):
all_action_fix_r6322.patch fixes a bug where the all action only ran once.
Unit tests are here:
http://svn.automattic.com/wordpress-tests/wp-testcase/test_actions.php
http://svn.automattic.com/wordpress-tests/wp-testcase/test_filters.php
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 11:02:28 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 11:02:44 2007
Subject: [wp-trac] Re: [WordPress Trac] #5272: WordPress allows anonymous
user to see slug for private post by guessing post number
In-Reply-To: <045.2ee8ebcf130603e00b7e2e5f88cba146@lists.automattic.com>
References: <045.2ee8ebcf130603e00b7e2e5f88cba146@lists.automattic.com>
Message-ID: <054.1210e4d891cecf65a7f4f50024c6d6b0@lists.automattic.com>
#5272: WordPress allows anonymous user to see slug for private post by guessing
post number
-----------------------------------------------------+----------------------
Reporter: tzafrir | Owner: pishmishy
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version: 2.3.1
Severity: major | Resolution:
Keywords: has-patch canonical redirection private |
-----------------------------------------------------+----------------------
Changes (by pishmishy):
* keywords: needs-patch => has-patch canonical redirection private
Comment:
Fix is to add an additional condition to be satisfied before canonical
redirection can take place.
Not entirely happy with my patch but it does fix the problem. Someone more
familiar with query.php can probably come up with an is_private()
function. is_empty works just as well though.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 11:04:09 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 11:04:24 2007
Subject: [wp-trac] Re: [WordPress Trac] #5324: 404 error on empty category
page
In-Reply-To: <050.538ea420ae5db09f3b3a05473e42510b@lists.automattic.com>
References: <050.538ea420ae5db09f3b3a05473e42510b@lists.automattic.com>
Message-ID: <059.cafb7d0872fff149207d22e4964bed01@lists.automattic.com>
#5324: 404 error on empty category page
--------------------------+-------------------------------------------------
Reporter: othellobloke | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version: 2.4
Severity: normal | Resolution:
Keywords: needs-patch |
--------------------------+-------------------------------------------------
Comment (by pishmishy):
Question...
Does this occur only when you manually construct the URL itself, or is
WordPress automatically generating a link to the page for the empty
category which results in a 404?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 13:25:22 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 13:25:35 2007
Subject: [wp-trac] Re: [WordPress Trac] #5324: 404 error on empty category
page
In-Reply-To: <050.538ea420ae5db09f3b3a05473e42510b@lists.automattic.com>
References: <050.538ea420ae5db09f3b3a05473e42510b@lists.automattic.com>
Message-ID: <059.23266d7ed24bd15f5645a6e7a972d083@lists.automattic.com>
#5324: 404 error on empty category page
--------------------------+-------------------------------------------------
Reporter: othellobloke | Owner: pishmishy
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version: 2.4
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+-------------------------------------------------
Changes (by pishmishy):
* keywords: needs-patch => has-patch
* owner: anonymous => pishmishy
* status: new => assigned
Comment:
Sorry, ignore that file. It's not complete.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 13:40:09 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 13:40:28 2007
Subject: [wp-trac] Re: [WordPress Trac] #3780: gettext fails to determine
byteorder on 64bit systems with php5.2.1
In-Reply-To: <044.273f33c6918120e95a3edfe616584dd1@lists.automattic.com>
References: <044.273f33c6918120e95a3edfe616584dd1@lists.automattic.com>
Message-ID: <053.abcf926ffb4dc0acf53045b21b95d832@lists.automattic.com>
#3780: gettext fails to determine byteorder on 64bit systems with php5.2.1
---------------------------------------------+------------------------------
Reporter: abtime | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: i18n | Version: 2.2
Severity: critical | Resolution:
Keywords: i18n has-patch 2nd-opition test |
---------------------------------------------+------------------------------
Comment (by thenlich):
This bug is still present in Wordpress 2.3 on Linux/amd64/PHP 5.2.3
It worked for me to remove the & 0xFFFFFFFF's. Solution is described here:
http://faq.wordpress-deutschland.org/wieso-zeigt-wordpress-trotz-
sprachdatei-englischen-text-an/
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 13:40:59 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 13:41:12 2007
Subject: [wp-trac] Re: [WordPress Trac] #3780: gettext fails to determine
byteorder on 64bit systems with php5.2.1
In-Reply-To: <044.273f33c6918120e95a3edfe616584dd1@lists.automattic.com>
References: <044.273f33c6918120e95a3edfe616584dd1@lists.automattic.com>
Message-ID: <053.c5c0977436ccca751b089f33300e74d7@lists.automattic.com>
#3780: gettext fails to determine byteorder on 64bit systems with php5.2.1
---------------------------------------------+------------------------------
Reporter: abtime | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: i18n | Version: 2.2
Severity: critical | Resolution:
Keywords: i18n has-patch 2nd-opition test |
---------------------------------------------+------------------------------
Comment (by thenlich):
Addition: Bug still present in 2.3.1 also.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 13:45:17 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 14:22:03 2007
Subject: [wp-trac] Re: [WordPress Trac] #5324: 404 error on empty category
page
In-Reply-To: <050.538ea420ae5db09f3b3a05473e42510b@lists.automattic.com>
References: <050.538ea420ae5db09f3b3a05473e42510b@lists.automattic.com>
Message-ID: <059.e77c0a8300971ef02fe31fc752826182@lists.automattic.com>
#5324: 404 error on empty category page
--------------------------+-------------------------------------------------
Reporter: othellobloke | Owner: pishmishy
Type: defect | Status: assigned
Priority: normal | Milestone: 2.4
Component: General | Version: 2.4
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+-------------------------------------------------
Comment (by Viper007Bond):
Replying to [comment:2 pishmishy]:
> Question...
>
> Does this occur only when you manually construct the URL itself, or is
WordPress automatically generating a link to the page for the empty
category which results in a 404?
Well, it's the same URL, so... ;)
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 15:11:08 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 15:11:22 2007
Subject: [wp-trac] Re: [WordPress Trac] #5324: 404 error on empty category
page
In-Reply-To: <050.538ea420ae5db09f3b3a05473e42510b@lists.automattic.com>
References: <050.538ea420ae5db09f3b3a05473e42510b@lists.automattic.com>
Message-ID: <059.beaa0ebb0629da6c6db6577db572ea56@lists.automattic.com>
#5324: 404 error on empty category page
--------------------------+-------------------------------------------------
Reporter: othellobloke | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version: 2.4
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+-------------------------------------------------
Changes (by pishmishy):
* owner: pishmishy => anonymous
* status: assigned => new
Comment:
Actually I think this one is beyond me to fix cleanly.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 15:27:03 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 15:27:17 2007
Subject: [wp-trac] Re: [WordPress Trac] #5235: Add Pre-flight checks to
install
In-Reply-To: <043.6b0b82bc5f7a4f58b82fdc1066a79dd2@lists.automattic.com>
References: <043.6b0b82bc5f7a4f58b82fdc1066a79dd2@lists.automattic.com>
Message-ID: <052.877ac35c6e05b534975e959b23311f29@lists.automattic.com>
#5235: Add Pre-flight checks to install
-------------------------+--------------------------------------------------
Reporter: westi | Owner: pishmishy
Type: enhancement | Status: assigned
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+--------------------------------------------------
Comment (by santosj):
There should be more logic to make sure they have {{{Allow_Fopen_URL}}} or
the PHP configuration to get URLs. That is important, but not required.
I was thinking about perhaps having levels (green, yellow, red) that the
other installers have (OpenAds). Instead of displaying all of them, just
display the yellow and halt on red (ask to continue with message saying
"Hey, yo some parts of WordPress won't function correctly. Get bettre
[intentionally misspelled] host."
Since I don't have any involvement, I would rather like anything that is
done. The above just suggestion, if I had a chance to do something.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 17:02:46 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 17:02:57 2007
Subject: [wp-trac] [WordPress Trac] #5326: Don't use sanitize_title in
widgets API
Message-ID: <042.a66ff198e8f797cdc62d204910626f2a@lists.automattic.com>
#5326: Don't use sanitize_title in widgets API
---------------------+------------------------------------------------------
Reporter: ryan | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version: 2.4
Severity: normal | Keywords: performance
---------------------+------------------------------------------------------
widgets.php calls sanitize_title() on widget IDs. For the new API
(functions starting with wp_), this isn't necessary. sanitize_title() is
a slow function that does lots of stuff we don't need to do when
sanitizing an ID. Let's just drop the sanitization and take the ID as is.
For the old widgets API (functions without wp_), the sanitization can stay
for maximum back-compat.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 17:06:57 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 17:07:11 2007
Subject: [wp-trac] Re: [WordPress Trac] #5326: Don't use sanitize_title in
widgets API
In-Reply-To: <042.a66ff198e8f797cdc62d204910626f2a@lists.automattic.com>
References: <042.a66ff198e8f797cdc62d204910626f2a@lists.automattic.com>
Message-ID: <051.519ec748bdb9914558d506050b954b34@lists.automattic.com>
#5326: Don't use sanitize_title in widgets API
-------------------------+--------------------------------------------------
Reporter: ryan | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version: 2.4
Severity: normal | Resolution:
Keywords: performance |
-------------------------+--------------------------------------------------
Comment (by ryan):
This patch reduced the number of calls to sanitize_title() from 103 to 2
on my testbed. The amount of time spent in sanitize_title() dropped from
almost 10% to a fraction of a percent.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 19:24:53 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 19:25:06 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.0d7d7c5497e01f974e0604d158f82895@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: reopened
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by mdawaffe):
Replying to [comment:34 tellyworth]:
> all_action_fix_r6322.patch fixes a bug where the all action only ran
once.
Does do_action_ref_array need a similar fix?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 19:33:03 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 19:33:13 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.df48860b08d827050f92331436618772@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: reopened
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by ryan):
I'm finding that several plugins are doing add_action where they mean
add_filter, and vice versa. Now that we've split filters and plugins,
these plugins break.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 19:59:19 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 19:59:31 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.8ea35e8a4a5201ddd604c9536e2f4ad5@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: reopened
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by ryan):
I think we need to revert back to one array for both filters and actions.
'all' support can be simplified to pass the name of the hook and an array
of all the args to functions hooked to 'all'. An 'all' function would not
be expected to return a value. 'all' functions won't filter anything.
They just get notification of the hook being processed and the args passed
to that hook and that's it.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 21:21:11 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 21:21:24 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.864e5847efd1e3e24978593acfcfbab7@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: reopened
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by santosj):
Can you add type of hook (filter|action) or is that what you mean?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 22:06:28 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 22:06:40 2007
Subject: [wp-trac] [WordPress Trac] #5327: Possible stupid bug of the plugin
system
Message-ID: <042.35eb7700e4e33e81a5b2ffaa596b0a2a@lists.automattic.com>
#5327: Possible stupid bug of the plugin system
---------------------+------------------------------------------------------
Reporter: gnot | Owner: anonymous
Type: defect | Status: new
Priority: high | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: blocker | Keywords:
---------------------+------------------------------------------------------
I have just wasted 4+ hours because WP '''breaks horribly''' without any
warning or error message when there is '''more than one empty line'''
under the last {{{?>}}} tag in the source code of a plugin. I found out
about this accidentally while trying desperately to fix a problem with a
plugin of mine.
Can anybody confirm this?
The only thing I do not want to read is that it is a feature or a
necessary evil or anything similar... Thanks
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 22:08:16 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 22:08:44 2007
Subject: [wp-trac] Re: [WordPress Trac] #5327: Possible stupid bug of the
plugin system
In-Reply-To: <042.35eb7700e4e33e81a5b2ffaa596b0a2a@lists.automattic.com>
References: <042.35eb7700e4e33e81a5b2ffaa596b0a2a@lists.automattic.com>
Message-ID: <051.8d6b00b4f741e8c113c260124de54b79@lists.automattic.com>
#5327: Possible stupid bug of the plugin system
---------------------+------------------------------------------------------
Reporter: gnot | Owner: anonymous
Type: defect | Status: new
Priority: high | Milestone:
Component: General | Version: 2.3.1
Severity: blocker | Resolution:
Keywords: |
---------------------+------------------------------------------------------
Changes (by gnot):
* milestone: 2.5 =>
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 22:11:33 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 22:11:44 2007
Subject: [wp-trac] Re: [WordPress Trac] #5327: Possible stupid bug of the
plugin system
In-Reply-To: <042.35eb7700e4e33e81a5b2ffaa596b0a2a@lists.automattic.com>
References: <042.35eb7700e4e33e81a5b2ffaa596b0a2a@lists.automattic.com>
Message-ID: <051.a654aa651a037e27987ce87d7be2c74a@lists.automattic.com>
#5327: Possible stupid bug of the plugin system
---------------------+------------------------------------------------------
Reporter: gnot | Owner: anonymous
Type: defect | Status: closed
Priority: high | Milestone:
Component: General | Version: 2.3.1
Severity: blocker | Resolution: invalid
Keywords: |
---------------------+------------------------------------------------------
Changes (by santosj):
* status: new => closed
* resolution: => invalid
Comment:
This isn't a WordPress issue. It is a PHP issue. It is a common problem
with a known solution. All WordPress files must not have more than one
empty line (none would be better).
If you remove the {{{?>}}} from PHP only files, it would prevent this from
happening again.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 22:17:07 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 22:17:19 2007
Subject: [wp-trac] Re: [WordPress Trac] #5327: Possible stupid bug of the
plugin system
In-Reply-To: <042.35eb7700e4e33e81a5b2ffaa596b0a2a@lists.automattic.com>
References: <042.35eb7700e4e33e81a5b2ffaa596b0a2a@lists.automattic.com>
Message-ID: <051.bcad3a728695a3399911c812c06832ed@lists.automattic.com>
#5327: Possible stupid bug of the plugin system
---------------------+------------------------------------------------------
Reporter: gnot | Owner: anonymous
Type: defect | Status: closed
Priority: high | Milestone:
Component: General | Version: 2.3.1
Severity: blocker | Resolution: invalid
Keywords: |
---------------------+------------------------------------------------------
Comment (by gnot):
Damn, I do not want to write anything in PHP again...
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 22:21:15 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 22:21:26 2007
Subject: [wp-trac] Re: [WordPress Trac] #5327: Possible stupid bug of the
plugin system
In-Reply-To: <042.35eb7700e4e33e81a5b2ffaa596b0a2a@lists.automattic.com>
References: <042.35eb7700e4e33e81a5b2ffaa596b0a2a@lists.automattic.com>
Message-ID: <051.537810d92dddce6b4e037cffbeb2757c@lists.automattic.com>
#5327: Possible stupid bug of the plugin system
---------------------+------------------------------------------------------
Reporter: gnot | Owner: anonymous
Type: defect | Status: closed
Priority: high | Milestone:
Component: General | Version: 2.3.1
Severity: blocker | Resolution: invalid
Keywords: |
---------------------+------------------------------------------------------
Comment (by santosj):
Why?
Most likely what happened was that you have display_errors set to '0',
which is why no errors or warnings came up. If you had turned it on, you
most likely would have received an error about trying to send headers
after they were already sent (Most common cause of this happening).
All languages are going to have little "gotchas" that you have to figure
out. It technically isn't a PHP issue either, since it is the expected
behavior and documented.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 22:22:30 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 22:22:41 2007
Subject: [wp-trac] Re: [WordPress Trac] #5327: Possible stupid bug of the
plugin system
In-Reply-To: <042.35eb7700e4e33e81a5b2ffaa596b0a2a@lists.automattic.com>
References: <042.35eb7700e4e33e81a5b2ffaa596b0a2a@lists.automattic.com>
Message-ID: <051.8109a66ee53a9f7b05cbe6166ac8bfcf@lists.automattic.com>
#5327: Possible stupid bug of the plugin system
---------------------+------------------------------------------------------
Reporter: gnot | Owner: anonymous
Type: defect | Status: closed
Priority: high | Milestone:
Component: General | Version: 2.3.1
Severity: blocker | Resolution: invalid
Keywords: |
---------------------+------------------------------------------------------
Comment (by santosj):
Well, at least now you know and knowing is half the battle. The other half
is fixing or preventing it from happening again. That and turning on
Display Errors on your development server (if not already on).
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 22:26:21 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 22:26:32 2007
Subject: [wp-trac] Re: [WordPress Trac] #5327: Possible stupid bug of the
plugin system
In-Reply-To: <042.35eb7700e4e33e81a5b2ffaa596b0a2a@lists.automattic.com>
References: <042.35eb7700e4e33e81a5b2ffaa596b0a2a@lists.automattic.com>
Message-ID: <051.8c41772d7281d44df3804b87d43f4c39@lists.automattic.com>
#5327: Possible stupid bug of the plugin system
---------------------+------------------------------------------------------
Reporter: gnot | Owner: anonymous
Type: defect | Status: closed
Priority: high | Milestone:
Component: General | Version: 2.3.1
Severity: blocker | Resolution: invalid
Keywords: |
---------------------+------------------------------------------------------
Comment (by gnot):
Problem is that I was trying to fix the plugin on my live blog :)
Anyway, despite my anger about the wasted time, I'd like to thank you for
the information. I am not a professional.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 23:53:14 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 23:53:26 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.332bd71c0999d0c7476f7c7d902c1f1f@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: reopened
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by ryan):
Patch brings actions and filters back together in $wp_filter. 'all'
functions are passed the name of the action/filter and all arguments.
This means that 'all' hooks don't need to use current_filter() to get the
current action/filter. We could also pass the hook type (filter or
action), although I don't know how practically useful that is to the
plugins that would be using 'all' hooks.
Functions attached to 'all' are not expected to return anything. This
avoids needing a filter versus action distinction, allowing us to use one
array to store both.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Wed Nov 7 23:55:46 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Wed Nov 7 23:55:58 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.70391727ab4279b1970849876165827a@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: reopened
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by ryan):
I also incorporated tellyworth's fix and moved the argument processing in
do_action() down below the check to see if the action is set. This avoids
unnecessary func_get_arg() calls.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 8 00:16:20 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 8 00:16:34 2007
Subject: [wp-trac] Re: [WordPress Trac] #3907: WP reverts to default theme
on file access collision
In-Reply-To: <042.b028703ad64185af71d8606815310c02@lists.automattic.com>
References: <042.b028703ad64185af71d8606815310c02@lists.automattic.com>
Message-ID: <051.a17d8db4816415f1afcc9feed658a3e0@lists.automattic.com>
#3907: WP reverts to default theme on file access collision
-------------------------+--------------------------------------------------
Reporter: _ck_ | Owner: anonymous
Type: defect | Status: new
Priority: low | Milestone: 2.5
Component: Template | Version: 2.2
Severity: major | Resolution:
Keywords: needs-patch |
-------------------------+--------------------------------------------------
Comment (by ryan):
How about we just lose this? We reset broken themes when visiting the
Presentation admin page. Let's call that good enough.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 8 00:33:38 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 8 00:33:51 2007
Subject: [wp-trac] Re: [WordPress Trac] #3907: WP reverts to default theme
on file access collision
In-Reply-To: <042.b028703ad64185af71d8606815310c02@lists.automattic.com>
References: <042.b028703ad64185af71d8606815310c02@lists.automattic.com>
Message-ID: <051.86303e064e014fe5a898ed7d0fac26a5@lists.automattic.com>
#3907: WP reverts to default theme on file access collision
-------------------------+--------------------------------------------------
Reporter: _ck_ | Owner: anonymous
Type: defect | Status: new
Priority: low | Milestone: 2.5
Component: Template | Version: 2.2
Severity: major | Resolution:
Keywords: needs-patch |
-------------------------+--------------------------------------------------
Comment (by lloydbudd):
+1 to removing the call validate_current_theme() from wp-settings.php
file_exists can fails (returns false) when there is file contention. I've
been working with a friend who supports a number of busy blogs and on two
different hosting environments he has issue with regular resets -- and by
regular, I don't mean I can see a pattern to the time interval, sometimes
it can be a few minutes a part, sometimes a few hours.
validate_current_theme with its 2 file checks is useful for basic sanity
when going to the Presentation tab, and it would be great if it did more
checking, but a synchronous wp_file_exists on every load of WP seems
awkward, and won't detect most problems with a theme.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 8 00:35:40 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 8 00:35:52 2007
Subject: [wp-trac] Re: [WordPress Trac] #3907: WP reverts to default theme
on file access collision
In-Reply-To: <042.b028703ad64185af71d8606815310c02@lists.automattic.com>
References: <042.b028703ad64185af71d8606815310c02@lists.automattic.com>
Message-ID: <051.bce1856c4fc6dd9da63d836d1a3ca6e1@lists.automattic.com>
#3907: WP reverts to default theme on file access collision
-----------------------+----------------------------------------------------
Reporter: _ck_ | Owner: anonymous
Type: defect | Status: new
Priority: low | Milestone: 2.4
Component: Template | Version: 2.2
Severity: major | Resolution:
Keywords: has-patch |
-----------------------+----------------------------------------------------
Changes (by lloydbudd):
* keywords: needs-patch => has-patch
* milestone: 2.5 => 2.4
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 8 01:28:44 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 8 01:28:56 2007
Subject: [wp-trac] Re: [WordPress Trac] #5231: add_action('all',
...) causes unexpected behaviour
In-Reply-To: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
References: <048.79c9cb0b973f423a432edcebd7bd7185@lists.automattic.com>
Message-ID: <057.95946c7a29130e66343ad003939fa3b0@lists.automattic.com>
#5231: add_action('all', ...) causes unexpected behaviour
-------------------------------------+--------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: reopened
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by tellyworth):
Unit tests pass against [6324]. There are no tests for
has_filter/has_action yet though.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 8 02:01:07 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 8 02:01:19 2007
Subject: [wp-trac] Re: [WordPress Trac] #4715: Lost of Priority with
Merge_filters and $wp_filters['all']
In-Reply-To: <048.7a211309ca32f4134bc5b190c06364a9@lists.automattic.com>
References: <048.7a211309ca32f4134bc5b190c06364a9@lists.automattic.com>
Message-ID: <057.b150981f63d6302b722b0f11892622db@lists.automattic.com>
#4715: Lost of Priority with Merge_filters and $wp_filters['all']
------------------------------------------------------------------+---------
Reporter: darkdragon | Owner: anonymous
Type: defect | Status: closed
Priority: lowest | Milestone: 2.4
Component: General | Version: 2.3
Severity: trivial | Resolution: fixed
Keywords: has-patch merge_filters filters plugin.php confirmed |
------------------------------------------------------------------+---------
Changes (by darkdragon):
* status: new => closed
* resolution: => fixed
Comment:
No longer relevant to WordPress 2.4. Closing as fixed, since merge_filters
no longer exists or used.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 8 02:28:59 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 8 02:29:12 2007
Subject: [wp-trac] Re: [WordPress Trac] #5324: 404 error on empty category
page
In-Reply-To: <050.538ea420ae5db09f3b3a05473e42510b@lists.automattic.com>
References: <050.538ea420ae5db09f3b3a05473e42510b@lists.automattic.com>
Message-ID: <059.1d10a49bf5152af1091d2dcae53db9ec@lists.automattic.com>
#5324: 404 error on empty category page
--------------------------+-------------------------------------------------
Reporter: othellobloke | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version: 2.4
Severity: normal | Resolution:
Keywords: needs-patch |
--------------------------+-------------------------------------------------
Changes (by Viper007Bond):
* keywords: has-patch => needs-patch
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 8 12:09:04 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 8 12:09:16 2007
Subject: [wp-trac] [WordPress Trac] #5328: Make default feed format pluggable
Message-ID: <043.40242ba56ae7d3e8fca582ab27d94486@lists.automattic.com>
#5328: Make default feed format pluggable
---------------------+------------------------------------------------------
Reporter: rubys | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Keywords: has-patch
---------------------+------------------------------------------------------
Provide a filter hook that a plugin could replace that would allow the
plugin to control the default feed format. Additionally, the filter could
provide the mime_type, display_name, short_name, and long_name to themes
so that they could adjust, if they so desire.
The provided patch adjusts the default theme to make use of this new
filter. Simply drop in [http://intertwingly.net/stories/2007/11/08/atom-
feed-format.phps this plugin] and activate it, and the pages automatically
adapt. Deactivate the plugin, and the pages revert back to RSS 2.0.
Additional plugins could be defined for RSS 0.92 or RSS 1.0.
This patch does *not* change the default feed format from RSS 2.0.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 8 12:15:29 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 8 12:15:43 2007
Subject: [wp-trac] Re: [WordPress Trac] #5328: Make default feed format
pluggable
In-Reply-To: <043.40242ba56ae7d3e8fca582ab27d94486@lists.automattic.com>
References: <043.40242ba56ae7d3e8fca582ab27d94486@lists.automattic.com>
Message-ID: <052.132b949948ec02668e737d41905d1a75@lists.automattic.com>
#5328: Make default feed format pluggable
-------------------------+--------------------------------------------------
Reporter: rubys | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+--------------------------------------------------
Changes (by rubys):
* type: defect => enhancement
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 8 14:55:08 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 8 14:55:20 2007
Subject: [wp-trac] [WordPress Trac] #5329: "submit for review" feature
checks wrong permission and publishes
Message-ID: <050.55ad130767d738b1bdae2a3de0e6c291@lists.automattic.com>
#5329: "submit for review" feature checks wrong permission and publishes
----------------------------+-----------------------------------------------
Reporter: jeremyclarke | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: Administration | Version: 2.3.1
Severity: normal | Keywords: has-patch
----------------------------+-----------------------------------------------
The bug relates to the new post submission feature where users who can't
publish their own posts can submit them for review rather than just saving
them as draft and informing the site admin that they want it published.
The worst case scenario has users clicking on a button that says "submit
for review" but actually publishing the articles to the blog.
in /wp-admin/edit-form-advanced.php on line 172 the logic checks to see if
a user has the publish_posts capability/role and if they do not, it labels
the "publish" button as "submit for review" instead.
172
173
174
175
176
This is linked with line 69 of /wp-admin/includes/post.php which processes
the post status and sets it to pending based on user capabilities:
69 if ('publish' == $_POST['post_status'] && !current_user_can(
'edit_published_posts' ))
70 $_POST['post_status'] = 'pending';
71 }
As far as I can tell, there is no reason why the processing check should
use the "edit_published_posts" role rather than the publish_posts role,
especially considering that the publish_posts role was the one originally
used to determine the text on the button. In the case of our site, or any
where authors need help initially editing their posts but are trusted to
make changes once the post is approved (and thus have edit_published_posts
but not publish_posts), this results in people seeing the text "submit for
review" but actually having their posts published to the blog, which of
course can have terrible results.
Any reason why this is this way? Seems like it should be fast-tracked into
core and anyone using this functionality should probably patch it for
themselves.
NOTE: the edit_published_posts role I think is only available to authors
through the role manager plugin, so if you aren't using it you probably
aren't at risk, i think that's why this wasn't noticed when it was first
implemented, for most installs publish_posts and edit_published_posts are
available/unnavailable to the same user types).
This is my first patch, so if there's a problem with the diff please let
me know.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 8 16:42:19 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 8 16:42:31 2007
Subject: [wp-trac] Re: [WordPress Trac] #3780: gettext fails to determine
byteorder on 64bit systems with php5.2.1
In-Reply-To: <044.273f33c6918120e95a3edfe616584dd1@lists.automattic.com>
References: <044.273f33c6918120e95a3edfe616584dd1@lists.automattic.com>
Message-ID: <053.b17143ff01dd0a3649276763250a47bb@lists.automattic.com>
#3780: gettext fails to determine byteorder on 64bit systems with php5.2.1
---------------------------------------------+------------------------------
Reporter: abtime | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: i18n | Version: 2.2
Severity: critical | Resolution:
Keywords: i18n has-patch 2nd-opition test |
---------------------------------------------+------------------------------
Comment (by nbachiyski):
Could everybody, please, try the both patches and report if any is
working.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 8 17:37:38 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 8 17:37:55 2007
Subject: [wp-trac] Re: [WordPress Trac] #4852: Incorrect grammar when author
ends with an s
In-Reply-To: <044.a2d2ad5dcb35902e98a687cec37c5a3e@lists.automattic.com>
References: <044.a2d2ad5dcb35902e98a687cec37c5a3e@lists.automattic.com>
Message-ID: <053.529b164ba1dc1dc79744124e1d01c46f@lists.automattic.com>
#4852: Incorrect grammar when author ends with an s
---------------------+------------------------------------------------------
Reporter: Nazgul | Owner: anonymous
Type: defect | Status: new
Priority: low | Milestone: 2.4
Component: i18n | Version: 2.3
Severity: trivial | Resolution:
Keywords: |
---------------------+------------------------------------------------------
Comment (by regulatethis):
The grammar is actually correct, as filosofo indicates above. Shouldn't
this be set to invalid?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 8 18:05:47 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 8 18:05:59 2007
Subject: [wp-trac] Re: [WordPress Trac] #3492: Visual Rich Editor wipes out
various CSS class or style attributes
In-Reply-To: <044.3e6ecb85cee9f819d3e123e5cd897191@lists.automattic.com>
References: <044.3e6ecb85cee9f819d3e123e5cd897191@lists.automattic.com>
Message-ID: <053.10ebed9fdd35548642cf1c9acc3fdf5f@lists.automattic.com>
#3492: Visual Rich Editor wipes out various CSS class or style attributes
---------------------+------------------------------------------------------
Reporter: figcar | Owner: anonymous
Type: defect | Status: reopened
Priority: high | Milestone: 2.4
Component: TinyMCE | Version: 2.3
Severity: major | Resolution:
Keywords: |
---------------------+------------------------------------------------------
Comment (by derjohng):
I had the same problems as flurischt.
So, I tried to modify the editor_plugin.js. I thought I have solved
and foolswisdom's table tags problem.
And
problem, according to ticket:4667, it's not allowed.
benchmark20071109.txt is the file that I had tested. But, I am not sure
this can "address all types of attribute loss" :p
Please try it and let me known whether this works well or not.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 8 18:14:46 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 8 18:14:57 2007
Subject: [wp-trac] Re: [WordPress Trac] #3720: Problems with permission
In-Reply-To: <049.60c5e4dc0397045b01e2c0c0d010fa23@lists.automattic.com>
References: <049.60c5e4dc0397045b01e2c0c0d010fa23@lists.automattic.com>
Message-ID: <058.acf405acf2734156caea83cbe76c0f71@lists.automattic.com>
#3720: Problems with permission
-------------------------------+--------------------------------------------
Reporter: kanishigami | Owner: anonymous
Type: defect | Status: new
Priority: high | Milestone: 2.4
Component: Administration | Version: 2.1
Severity: normal | Resolution:
Keywords: permission delete |
-------------------------------+--------------------------------------------
Comment (by regulatethis):
Can't reproduce this in 2.4-bleeding (as of r6325). Are there any more
details?
Does this happen all the time?
Any details about the posts you are trying to delete?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 8 18:28:54 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 8 18:29:06 2007
Subject: [wp-trac] Re: [WordPress Trac] #3566: Request for new function
get_page_parents
In-Reply-To: <047.6a7135c4982cd5875893dc678bf91481@lists.automattic.com>
References: <047.6a7135c4982cd5875893dc678bf91481@lists.automattic.com>
Message-ID: <056.daca9e9d4ab65b2524d3401f88f58b8b@lists.automattic.com>
#3566: Request for new function get_page_parents
-------------------------+--------------------------------------------------
Reporter: snakefoot | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version: 2.1
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+--------------------------------------------------
Comment (by Huskey):
Your solution has a bug and returns the page title for $nicename = TRUE
and vice-versa, which is wrong. Also, it lacks the check for a valid page
object returned. Here's the updated code:
{{{
function get_page_parents($id, $link = FALSE, $separator = '/', $nicename
= FALSE) {
$chain = '';
$parent = &get_page($id);
if ( is_wp_error( $parent ) )
return $parent;
if ( $nicename )
$name = $parent->post_name;
else
$name = $parent->post_title;
if ( $parent->post_parent )
$chain .= get_page_parents($parent->post_parent, $link,
$separator, $nicename);
if ( $link )
$chain .= ''.$name.'' . $separator;
else
$chain .= $name.$separator;
return $chain;
}
}}}
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 8 19:30:11 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Thu Nov 8 19:30:24 2007
Subject: [wp-trac] Re: [WordPress Trac] #4852: Incorrect grammar when author
ends with an s
In-Reply-To: <044.a2d2ad5dcb35902e98a687cec37c5a3e@lists.automattic.com>
References: <044.a2d2ad5dcb35902e98a687cec37c5a3e@lists.automattic.com>
Message-ID: <053.fb3eafe2a2a4719e6284e8c4b81fb625@lists.automattic.com>
#4852: Incorrect grammar when author ends with an s
---------------------+------------------------------------------------------
Reporter: Nazgul | Owner: anonymous
Type: defect | Status: closed
Priority: low | Milestone:
Component: i18n | Version: 2.3
Severity: trivial | Resolution: invalid
Keywords: |
---------------------+------------------------------------------------------
Changes (by Nazgul):
* status: new => closed
* resolution: => invalid
* milestone: 2.4 =>
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Thu Nov 8 23:59:57 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 00:00:07 2007
Subject: [wp-trac] Re: [WordPress Trac] #4599: XMLRPC should implement a
method for deleting categories
In-Reply-To: <048.7e5a5da5dfbbfcabd1acf5c87dd6abe0@lists.automattic.com>
References: <048.7e5a5da5dfbbfcabd1acf5c87dd6abe0@lists.automattic.com>
Message-ID: <057.fd1e066a07376b6c449e8e9f76f3a643@lists.automattic.com>
#4599: XMLRPC should implement a method for deleting categories
-------------------------+--------------------------------------------------
Reporter: redsweater | Owner: josephscott
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: XML-RPC | Version: 2.2.1
Severity: normal | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by josephscott):
The attached diff adds a new method, wp.deleteCategory(blog_id, username,
password, category_id). Will return a 0 (zero) or a 1.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 00:00:55 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 00:01:06 2007
Subject: [wp-trac] Re: [WordPress Trac] #4599: XMLRPC should implement a
method for deleting categories
In-Reply-To: <048.7e5a5da5dfbbfcabd1acf5c87dd6abe0@lists.automattic.com>
References: <048.7e5a5da5dfbbfcabd1acf5c87dd6abe0@lists.automattic.com>
Message-ID: <057.7424c4e30390169a9f9e91937a77027c@lists.automattic.com>
#4599: XMLRPC should implement a method for deleting categories
-------------------------+--------------------------------------------------
Reporter: redsweater | Owner: josephscott
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: XML-RPC | Version: 2.2.1
Severity: normal | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by josephscott):
Forgot the mention, this contains a small clean up item for wp.newCategory
as well.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 00:02:57 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 00:03:08 2007
Subject: [wp-trac] Re: [WordPress Trac] #4599: XMLRPC should implement a
method for deleting categories
In-Reply-To: <048.7e5a5da5dfbbfcabd1acf5c87dd6abe0@lists.automattic.com>
References: <048.7e5a5da5dfbbfcabd1acf5c87dd6abe0@lists.automattic.com>
Message-ID: <057.7b5d576444fc7ef5a26759a079c94ba3@lists.automattic.com>
#4599: XMLRPC should implement a method for deleting categories
-------------------------+--------------------------------------------------
Reporter: redsweater | Owner: josephscott
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: XML-RPC | Version: 2.2.1
Severity: normal | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Changes (by josephscott):
* cc: josephscott (added)
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 00:17:11 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 00:17:23 2007
Subject: [wp-trac] Re: [WordPress Trac] #4982: XMLRPC should expose draft
status of entries
In-Reply-To: <048.f4cf3ae2edbe2d3c6465d3fee29665da@lists.automattic.com>
References: <048.f4cf3ae2edbe2d3c6465d3fee29665da@lists.automattic.com>
Message-ID: <057.eab9099937fedbd0101268ed0d7ba86f@lists.automattic.com>
#4982: XMLRPC should expose draft status of entries
------------------------+---------------------------------------------------
Reporter: redsweater | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: XML-RPC | Version: 2.3
Severity: normal | Resolution:
Keywords: |
------------------------+---------------------------------------------------
Comment (by josephscott):
The diff adds the 'post_status' field to data returned from
metaWeblog.getPost and metaWeblog.getRecentPosts. Just as a note,
wp.getPage already provides this for pages in the 'page_status' field.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 00:31:44 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 00:31:56 2007
Subject: [wp-trac] Re: [WordPress Trac] #4599: XMLRPC should implement a
method for deleting categories
In-Reply-To: <048.7e5a5da5dfbbfcabd1acf5c87dd6abe0@lists.automattic.com>
References: <048.7e5a5da5dfbbfcabd1acf5c87dd6abe0@lists.automattic.com>
Message-ID: <057.0a95dbbe2f34ee35c4696aa2b3d7881b@lists.automattic.com>
#4599: XMLRPC should implement a method for deleting categories
-------------------------+--------------------------------------------------
Reporter: redsweater | Owner: josephscott
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: XML-RPC | Version: 2.2.1
Severity: normal | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by josephscott):
Joe Cheng brought up a good point, when a category that is deleted has
children be aware that all of the children will be bumped up a level.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 00:33:15 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 00:33:27 2007
Subject: [wp-trac] Re: [WordPress Trac] #4982: XMLRPC should expose draft
status of entries
In-Reply-To: <048.f4cf3ae2edbe2d3c6465d3fee29665da@lists.automattic.com>
References: <048.f4cf3ae2edbe2d3c6465d3fee29665da@lists.automattic.com>
Message-ID: <057.fa197e5cf024badf3a46a9a334fd0743@lists.automattic.com>
#4982: XMLRPC should expose draft status of entries
------------------------+---------------------------------------------------
Reporter: redsweater | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: XML-RPC | Version: 2.3
Severity: normal | Resolution:
Keywords: has-patch |
------------------------+---------------------------------------------------
Changes (by josephscott):
* keywords: => has-patch
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 00:33:39 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 00:33:51 2007
Subject: [wp-trac] Re: [WordPress Trac] #4599: XMLRPC should implement a
method for deleting categories
In-Reply-To: <048.7e5a5da5dfbbfcabd1acf5c87dd6abe0@lists.automattic.com>
References: <048.7e5a5da5dfbbfcabd1acf5c87dd6abe0@lists.automattic.com>
Message-ID: <057.fa05561686eb937ca1e6ad7621f298df@lists.automattic.com>
#4599: XMLRPC should implement a method for deleting categories
-------------------------+--------------------------------------------------
Reporter: redsweater | Owner: josephscott
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: XML-RPC | Version: 2.2.1
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+--------------------------------------------------
Changes (by josephscott):
* keywords: => has-patch
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 02:42:57 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 02:43:09 2007
Subject: [wp-trac] [WordPress Trac] #5330: wxr import inserts tags with
numbers instead of names
Message-ID: <048.3f00c32426c72beddd02ae67f8a6e6d3@lists.automattic.com>
#5330: wxr import inserts tags with numbers instead of names
------------------------+---------------------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Keywords:
------------------------+---------------------------------------------------
The wp importer incorrectly inserts tags with the term ID number in place
of its name. The first post with that tag works fine, but subsequent
posts get bogus numeric tags instead.
It seems to be a simple type issue, numeric string vs int. The enclosed
patch fixes it in the importer, but the same issue might affect other code
also. Perhaps the fix belongs at a lower level, in wp_set_object_terms()
or is_term() (I think the is_int() check in is_term() is the root cause).
Reproduced in unit testing:
http://svn.automattic.com/wordpress-tests/wp-testcase/test_import_wp.php
{{{
There was 1 failure:
1) test_all_posts(TestImportWP)
Failed asserting that two strings are equal.
expected string
difference
got string <11>
/home/zem/projects/wordpress/wordpress-tests/wp-
testcase/test_import_wp.php:82
/home/zem/projects/wordpress/wordpress-tests/wp-testlib/base.php:330
/home/zem/projects/wordpress/wordpress-tests/wp-test.php:91
}}}
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 03:37:23 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 03:37:35 2007
Subject: [wp-trac] Re: [WordPress Trac] #5330: wxr import inserts tags with
numbers instead of names
In-Reply-To: <048.3f00c32426c72beddd02ae67f8a6e6d3@lists.automattic.com>
References: <048.3f00c32426c72beddd02ae67f8a6e6d3@lists.automattic.com>
Message-ID: <057.5c949082555cbb0f30656c4e234dae44@lists.automattic.com>
#5330: wxr import inserts tags with numbers instead of names
------------------------+---------------------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
------------------------+---------------------------------------------------
Comment (by tellyworth):
Here's the import file used by the unit test:
http://svn.automattic.com/wordpress-tests/wp-
testdata/export/asdftestblog1.2007-11-09.xml
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 03:46:22 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 03:46:34 2007
Subject: [wp-trac] Re: [WordPress Trac] #4115: getCategoryList should not
include Blogroll in list of categories
In-Reply-To: <048.abd5b8c8ab2922fb2e6fb99f1bc39b3d@lists.automattic.com>
References: <048.abd5b8c8ab2922fb2e6fb99f1bc39b3d@lists.automattic.com>
Message-ID: <057.9b143e04b138fefa7d6e572e3e0e5207@lists.automattic.com>
#4115: getCategoryList should not include Blogroll in list of categories
-------------------------+--------------------------------------------------
Reporter: redsweater | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: XML-RPC | Version: 2.2
Severity: normal | Resolution:
Keywords: needs-patch |
-------------------------+--------------------------------------------------
Comment (by josephscott):
I've been trying to reproduce this with no luck. I suspect that r5758
fixed this for us back in June.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 03:48:00 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 03:48:11 2007
Subject: [wp-trac] Re: [WordPress Trac] #5330: wxr import inserts tags with
numbers instead of names
In-Reply-To: <048.3f00c32426c72beddd02ae67f8a6e6d3@lists.automattic.com>
References: <048.3f00c32426c72beddd02ae67f8a6e6d3@lists.automattic.com>
Message-ID: <057.23ff2931b8b4956bbdda2c77ceaacd14@lists.automattic.com>
#5330: wxr import inserts tags with numbers instead of names
------------------------+---------------------------------------------------
Reporter: tellyworth | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
------------------------+---------------------------------------------------
Comment (by tellyworth):
The problem starts around here:
http://trac.wordpress.org/browser/trunk/wp-admin/import/wordpress.php#L390
{{{
390 $tag_obj = get_term_by('slug', $slug,
'post_tag');
391 $tag_id = 0;
392 if ( ! empty($tag_obj) )
393 $tag_id = $tag_obj->term_id;
}}}
$tag_obj->term_id is a numeric string, not an int. It gets passed through
as a string to wp_set_post_tags(), wp_set_object_terms() and is_term().
is_term() sees that it's not an int, and assumes it's a tag name rather
than an ID.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 06:51:17 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 06:51:30 2007
Subject: [wp-trac] Re: [WordPress Trac] #4115: getCategoryList should not
include Blogroll in list of categories
In-Reply-To: <048.abd5b8c8ab2922fb2e6fb99f1bc39b3d@lists.automattic.com>
References: <048.abd5b8c8ab2922fb2e6fb99f1bc39b3d@lists.automattic.com>
Message-ID: <057.b5f4b5d795c642f227d4426813b82d00@lists.automattic.com>
#4115: getCategoryList should not include Blogroll in list of categories
-------------------------+--------------------------------------------------
Reporter: redsweater | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: XML-RPC | Version: 2.2
Severity: normal | Resolution:
Keywords: needs-patch |
-------------------------+--------------------------------------------------
Comment (by redsweater):
When I do a getCategoryList against my test blog on Wordpress.com, I still
get the Blogroll item:
categoryId1356categoryNameBlogroll
Wouldn't the Wordpress.com install have the fix from June that is alleged
to have fixed it?
(My test wordpress.com blog: http://sweatertest.wordpress.com/)
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wordpress at dd32.id.au Fri Nov 9 10:38:52 2007
From: wordpress at dd32.id.au (DD32)
Date: Fri Nov 9 10:39:10 2007
Subject: [wp-trac] Extend options.php to allow deletion,
Viewing of Serialized, And
grouping options (was: [wp-hackers] adding delete/autoload to options.php)
Message-ID:
Hi List,
I just thought i'd float this here again and see what peoples thoughts are on this.
In short:
This ticket is designed to allow the options.php page be used to delete items, as well as viewing serialized data, And it groups options together into their own section if they share a common prefix.
The ticket also includes the patch in plugin form, so if you would like to take a look, you can simply install the plugin instead of applying the diff.
I havn't added the autoload param. yet, i'm after UI feedback and unsure of how to present it.
Heres the ticket:
http://trac.wordpress.org/ticket/5316
Heres the original floatation:
http://comox.textdrive.com/pipermail/wp-hackers/2007-September/thread.html#14425 ([wp-hackers] adding delete/autoload to options.php)
D
From wordpress at dd32.id.au Fri Nov 9 10:42:31 2007
From: wordpress at dd32.id.au (DD32)
Date: Fri Nov 9 10:42:36 2007
Subject: [wp-trac] Extend options.php to allow deletion, Viewing of
Serialized,
And grouping options (was: [wp-hackers] adding delete/autoload to
options.php)
In-Reply-To:
References:
Message-ID:
Apologies.. Should've read the email address closer!
Maybe this list should be setup so people cant acedentally send emails to it..
On Fri, 09 Nov 2007 21:38:52 +1100, DD32 wrote:
From wp-trac at lists.automattic.com Fri Nov 9 11:32:09 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 11:32:21 2007
Subject: [wp-trac] [WordPress Trac] #5331: Category pagination permalinks
broken
Message-ID: <050.ada8b4cb202ee8f5019bde79860a9079@lists.automattic.com>
#5331: Category pagination permalinks broken
--------------------------+-------------------------------------------------
Reporter: AnkurKothari | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.3.2
Component: General | Version:
Severity: major | Keywords: pagination category permalink
--------------------------+-------------------------------------------------
Using pretty permalinks (such as http://exampleblog.com/catname/post-
slug), category pages can be reached via http://exampleblog.com/catname,
but the pagination links point to http://exampleblog.com/catname/page/x,
instead of http://exampleblog.com/category/catname/page/x.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 13:46:34 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 13:46:50 2007
Subject: [wp-trac] [WordPress Trac] #5332: Previous Entries / Next Entries
link broken when using widget search
Message-ID: <042.aa3c2b9a4967ffccc31ae3c296c54173@lists.automattic.com>
#5332: Previous Entries / Next Entries link broken when using widget search
---------------------+------------------------------------------------------
Reporter: Vimm | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version: 2.2.3
Severity: normal | Keywords:
---------------------+------------------------------------------------------
I've noticed that (for example) on the default template when searching a
blog using the search widget the Previous Entries and Next Entries links
have the wrong path. However, if I do a bad search and then run a search
using the search bar that shows up on the error page it works fine. When
comparing the two I noticed that the widget form's action element is
missing the trailing "/" which causes the links to be generated
incorrectly if the blog is in a subdirectory of the domain.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 15:56:25 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 15:56:39 2007
Subject: [wp-trac] Re: [WordPress Trac] #3994: MetaWeblog
metaWeblog.getCategories problem
In-Reply-To: <043.4268be9da45a946a6d9d552179984877@lists.automattic.com>
References: <043.4268be9da45a946a6d9d552179984877@lists.automattic.com>
Message-ID: <052.fb02a0adc7fcb83a145633a41f1719b1@lists.automattic.com>
#3994: MetaWeblog metaWeblog.getCategories problem
------------------------------------------------------------------------+---
Reporter: whilo | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: XML-RPC | Version: 2.2
Severity: normal | Resolution:
Keywords: xmlrpc, compliance, specs, clients, metaweblog, categories |
------------------------------------------------------------------------+---
Changes (by dougal):
* keywords: => xmlrpc, compliance, specs, clients, metaweblog,
categories
Comment:
This mis-implementation has been out there for several years now, so the
major clients are either explicitly or implicitly working around it. We
need to test the clients against a 'fixed' version of the method and make
sure nothing breaks. If the major clients don't break with the change, we
can get a fix committed. Otherwise, we might need to coordinate with the
client authors to see how we can smooth out a more gradual migration to
spec compliance.
The spec is vague. One must assume that the category name is what should
be used as the 'name' portion of the parent struct, though the category
slug might be a good candidate, as well. The use of an array probably
stemmed from the fact that the category portion of a post struct is
implemented as an array in the spec.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 16:11:01 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 16:11:15 2007
Subject: [wp-trac] Re: [WordPress Trac] #5331: Category pagination
permalinks broken
In-Reply-To: <050.ada8b4cb202ee8f5019bde79860a9079@lists.automattic.com>
References: <050.ada8b4cb202ee8f5019bde79860a9079@lists.automattic.com>
Message-ID: <059.928f2143de36c8e82accf11e0a44e7a2@lists.automattic.com>
#5331: Category pagination permalinks broken
-------------------------------------------+--------------------------------
Reporter: AnkurKothari | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3.1
Severity: major | Resolution:
Keywords: pagination category permalink |
-------------------------------------------+--------------------------------
Changes (by foolswisdom):
* version: => 2.3.1
* milestone: 2.3.2 => 2.5
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 16:18:10 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 16:18:22 2007
Subject: [wp-trac] Re: [WordPress Trac] #3780: gettext fails to determine
byteorder on 64bit systems with php5.2.1
In-Reply-To: <044.273f33c6918120e95a3edfe616584dd1@lists.automattic.com>
References: <044.273f33c6918120e95a3edfe616584dd1@lists.automattic.com>
Message-ID: <053.a8d30b3f34cb652b89b44a2bde214c8e@lists.automattic.com>
#3780: gettext fails to determine byteorder on 64bit systems with php5.2.1
---------------------------------------------+------------------------------
Reporter: abtime | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: i18n | Version: 2.2
Severity: critical | Resolution:
Keywords: i18n has-patch 2nd-opition test |
---------------------------------------------+------------------------------
Comment (by qb):
Replying to [comment:21 nbachiyski]:
> Could everybody, please, try the both patches and report if any is
working.
Both patches not working for me on Wordpress 2.3.1 / Linux 64 / PHP 5.2.4
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 16:32:43 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 16:32:56 2007
Subject: [wp-trac] Re: [WordPress Trac] #3566: Request for new function
get_page_parents
In-Reply-To: <047.6a7135c4982cd5875893dc678bf91481@lists.automattic.com>
References: <047.6a7135c4982cd5875893dc678bf91481@lists.automattic.com>
Message-ID: <056.7e5ba0feb45957f2f5d88b5aaa8e8027@lists.automattic.com>
#3566: Request for new function get_page_parents
-------------------------+--------------------------------------------------
Reporter: snakefoot | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version: 2.1
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+--------------------------------------------------
Changes (by Huskey):
* cc: Huskey (added)
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 17:25:10 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 17:25:23 2007
Subject: [wp-trac] Re: [WordPress Trac] #3994: MetaWeblog
metaWeblog.getCategories problem
In-Reply-To: <043.4268be9da45a946a6d9d552179984877@lists.automattic.com>
References: <043.4268be9da45a946a6d9d552179984877@lists.automattic.com>
Message-ID: <052.0877a7799c1343d2a50a85735a764952@lists.automattic.com>
#3994: MetaWeblog metaWeblog.getCategories problem
------------------------------------------------------------------------+---
Reporter: whilo | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: XML-RPC | Version: 2.2
Severity: normal | Resolution:
Keywords: xmlrpc, compliance, specs, clients, metaweblog, categories |
------------------------------------------------------------------------+---
Comment (by josephscott):
Just as a note to whilo and others who might be following this, there is
discussion on the http://lists.automattic.com/mailman/listinfo/wp-xmlrpc
list about this issue.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 18:06:33 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 18:06:44 2007
Subject: [wp-trac] Re: [WordPress Trac] #3994: MetaWeblog
metaWeblog.getCategories problem
In-Reply-To: <043.4268be9da45a946a6d9d552179984877@lists.automattic.com>
References: <043.4268be9da45a946a6d9d552179984877@lists.automattic.com>
Message-ID: <052.5eb728a0a9e7a3445f5fd35a69de8882@lists.automattic.com>
#3994: MetaWeblog metaWeblog.getCategories problem
------------------------------------------------------------------------+---
Reporter: whilo | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: XML-RPC | Version: 2.2
Severity: normal | Resolution:
Keywords: xmlrpc, compliance, specs, clients, metaweblog, categories |
------------------------------------------------------------------------+---
Comment (by redsweater):
foolswisdom said it best at the outset. Unless there's a clear scenario
where not fixing this is causing harm, it shouldn't be considered. The
MetaWeblog spec is not clear enough or widely enough followed to have
fixes done "just to be in compliance."
Also, MetaWeblog API per se is rather uncommonly used these days as most
clients will prefer the MovableType or WordPress supersets, in which case
the mt.getCategoryList method would be used instead.
I don't think you guys should waste your time trying to fix or compromise
for this issue. It would be change for change's sake, and a waste of time
when real problems need fixing.
Daniel
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 18:45:55 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 18:46:09 2007
Subject: [wp-trac] Re: [WordPress Trac] #4115: getCategoryList should not
include Blogroll in list of categories
In-Reply-To: <048.abd5b8c8ab2922fb2e6fb99f1bc39b3d@lists.automattic.com>
References: <048.abd5b8c8ab2922fb2e6fb99f1bc39b3d@lists.automattic.com>
Message-ID: <057.4c48e7f4ebd69e1f0e032af4be21f163@lists.automattic.com>
#4115: getCategoryList should not include Blogroll in list of categories
-------------------------+--------------------------------------------------
Reporter: redsweater | Owner: anonymous
Type: defect | Status: closed
Priority: normal | Milestone: 2.4
Component: XML-RPC | Version: 2.2
Severity: normal | Resolution: fixed
Keywords: needs-patch |
-------------------------+--------------------------------------------------
Changes (by redsweater):
* status: new => closed
* resolution: => fixed
Comment:
It looks like the Blogroll item I described above was a fluke. Somehow in
my testing I must have selected that Blogroll item from the list and thus
caused a real Blogroll category to get created on my Wordpress.com test
account.
I tested against a clean 2.3.1 install and the bug does appear to be
fixed! Nice.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 20:32:04 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 20:32:16 2007
Subject: [wp-trac] Re: [WordPress Trac] #5328: Make default feed format
pluggable
In-Reply-To: <043.40242ba56ae7d3e8fca582ab27d94486@lists.automattic.com>
References: <043.40242ba56ae7d3e8fca582ab27d94486@lists.automattic.com>
Message-ID: <052.5de1ea46abca154c81b159138b1e1cf0@lists.automattic.com>
#5328: Make default feed format pluggable
-------------------------+--------------------------------------------------
Reporter: rubys | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+--------------------------------------------------
Comment (by ryan):
How about a get_default_feed() function that applies a default_feed filter
and a get_feed_info($feed) for getting details for that feed?
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 21:43:38 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 21:43:51 2007
Subject: [wp-trac] Re: [WordPress Trac] #5328: Make default feed format
pluggable
In-Reply-To: <043.40242ba56ae7d3e8fca582ab27d94486@lists.automattic.com>
References: <043.40242ba56ae7d3e8fca582ab27d94486@lists.automattic.com>
Message-ID: <052.07ac3df2304d91296f46de6446851ea3@lists.automattic.com>
#5328: Make default feed format pluggable
-------------------------+--------------------------------------------------
Reporter: rubys | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+--------------------------------------------------
Comment (by ryan):
I'm still seeing the old patch, I think. Attached is what I had in mind.
It's not complete.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 21:44:34 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 21:44:47 2007
Subject: [wp-trac] Re: [WordPress Trac] #4115: getCategoryList should not
include Blogroll in list of categories
In-Reply-To: <048.abd5b8c8ab2922fb2e6fb99f1bc39b3d@lists.automattic.com>
References: <048.abd5b8c8ab2922fb2e6fb99f1bc39b3d@lists.automattic.com>
Message-ID: <057.6f71ac5c54bbe123a51e8dcfae63d3a7@lists.automattic.com>
#4115: getCategoryList should not include Blogroll in list of categories
-------------------------+--------------------------------------------------
Reporter: redsweater | Owner: anonymous
Type: defect | Status: closed
Priority: normal | Milestone: 2.3
Component: XML-RPC | Version: 2.2
Severity: normal | Resolution: fixed
Keywords: needs-patch |
-------------------------+--------------------------------------------------
Changes (by lloydbudd):
* milestone: 2.4 => 2.3
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 21:45:53 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 21:46:05 2007
Subject: [wp-trac] Re: [WordPress Trac] #5328: Make default feed format
pluggable
In-Reply-To: <043.40242ba56ae7d3e8fca582ab27d94486@lists.automattic.com>
References: <043.40242ba56ae7d3e8fca582ab27d94486@lists.automattic.com>
Message-ID: <052.e614a89e717e7d22bc331094814810d0@lists.automattic.com>
#5328: Make default feed format pluggable
-------------------------+--------------------------------------------------
Reporter: rubys | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+--------------------------------------------------
Comment (by ryan):
Notes about the patch. We could go ahead and add info for all the feeds
we ship with to get_feed_inf(). I added some checks need to make sure we
correctly create links when permalinks are not enabled. Category feed
links generated by wp_list_categories() follow the default. The same can
be done for authors.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 23:18:03 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 23:18:15 2007
Subject: [wp-trac] [WordPress Trac] #5333: Adding custom fields before
saving a page transforms the page into a post
Message-ID: <049.fcda32173edf5616a0dbe1d9c40a94b5@lists.automattic.com>
#5333: Adding custom fields before saving a page transforms the page into a post
-------------------------+--------------------------------------------------
Reporter: josephscott | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version: 2.4
Severity: normal | Keywords:
-------------------------+--------------------------------------------------
- Go to the write page screen
- add a custom field
- write and save/publish your page
- go to the manage pages screen, notice your page isn't there
- go to the manage posts screen, you'll find that your page was saved as a
draft post
I believe that when the custom fields are added an auto-save is done so
that they can be associated with an id. Unfortunately it seems to always
do the save as a post even when one the page screen.
--
Ticket URL:
WordPress Trac
WordPress blogging software
From wp-trac at lists.automattic.com Fri Nov 9 23:23:42 2007
From: wp-trac at lists.automattic.com (WordPress Trac)
Date: Fri Nov 9 23:23:53 2007
Subject: [wp-trac] [WordPress Trac] #5334: Inconsistent errors when trying
to add a custom field
Message-ID: <049.d66e8407dbd1f1d8105db9a9c063ac0e@lists.automattic.com>
#5334: Inconsistent errors when trying to add a custom field
-------------------------+--------------------------------------------------
Reporter: josephscott | Owner: anonymous
Type: defect | Status: new
Priority: normal | Milestone: 2.4
Component: General | Version: 2.4
Severity: normal | Keywords:
-------------------------+--------------------------------------------------
If you try to add a custom field with a key but no value then the
following error is displayed: "AJAX is teh b0rked."
If you try to add a custom field with a value but no key then you don't
get any sort of response at all. The custom field isn't added and you
don't get any sort of error message.
--
Ticket URL:
WordPress Trac