[wp-trac] Re: [WordPress Trac] #4784: robot meta tag needs beautification

[WordPress Trac]

#4784: robot meta tag needs beautification
-------------------------------------+--------------------------------------
 Reporter:  hakre                    |        Owner:  anonymous
     Type:  defect                   |       Status:  closed   
 Priority:  normal                   |    Milestone:           
Component:  Template                 |      Version:  2.2.2    
 Severity:  normal                   |   Resolution:  invalid  
 Keywords:  has-patch needs-testing  |  
-------------------------------------+--------------------------------------
Changes (by foolswisdom):

  * status:  reopened => closed
  * resolution:  => invalid
  * milestone:  2.2.3 =>

Comment:

 Reclosing as invalid for now.

 hakre, you say so what? But if it was a W3C issue, it would have been a
 very serious issue and one that we needed to share the education about.

 I feel like this is a like the color of the paint shed, and normally would
 approve of people just getting the painting done, but it feels a little
 like you are trying to paint a few paint sheds all at the same, and your
 skills could be applied to clear bugs.

 1. Milestone should not be for a maintenance release. The first gate for
 changes on a maint. release is severity of the problem. [[br]]
 2. The switching b/w quotes and using concat, is probably a false
 optimization and harder to read -- not part of the coding style guidelines
 anyway http://wordpress.org/docs/developer/coding-style/ . [[br]]
 *. Having replaced the previously attachment is a bit awkward.

 My personal bias also are: [[br]]
 a. Lining up assignments is definitely harder to read [[br]]
 b. A tab before the robot line is theme to theme whether they are
 indented. The default is not, but many are. Aside, a tab in that context
 you would want to put \t .

 I think if you want to paint these bike sheds, you should put them in
 separate tickets referencing this one. The phpdocs seems part like an easy
 sell.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4784#comment:24>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software