[wp-trac] Re: [WordPress Trac] #2551: Redirected enclosures not quite there yet

WordPress Trac wp-trac at lists.automattic.com
Fri Mar 10 00:16:57 GMT 2006


#2551: Redirected enclosures not quite there yet
-----------------------+----------------------------------------------------
       Id:  2551       |      Status:  new                     
Component:  General    |    Modified:  Fri Mar 10 00:16:57 2006
 Severity:  normal     |   Milestone:                          
 Priority:  normal     |     Version:  2.0.1                   
    Owner:  anonymous  |    Reporter:  aegrumet                
-----------------------+----------------------------------------------------
Comment (by aegrumet):

 Comments on the patchfile:

 1. No need to store $headers['status_code'], a few lines down the same
 data is computed and stored in $headers['response'].  A quick grep of the
 tree didn't reveal any other instances of the string 'status_code', so
 presumably there are no side effects to stomping it back out (unless of
 course you like that name and want to get rid of 'response' everywhere ;)
 ).

 2. The preg_replace for $code wasn't returning sane results for me in any
 case.  Not worth digging into if you agree with 1 above.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/2551>
WordPress Trac <http://wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list