[wp-hackers] Switching from SVN

[Curtis McHale]

> ------------------------------------------------------------------------
>
> 	Paul <mailto:paul at codehooligans.com>
> December 10, 2010 7:15 AM
>
>
> +1 in agreement with Travis. What a treat to read through this 
> discussion over some morning coffee.
>
> P-

I would thinks it's a few pots of coffee with this discussion.
>
>
> _______________________________________________
> wp-hackers mailing list
> wp-hackers at lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-hackers
> ------------------------------------------------------------------------
>
> 	Travis Northcutt <mailto:travis at travisnorthcutt.com>
> December 10, 2010 6:44 AM
>
>
>
>
> Just a quick note from someone who's been following this discussion, but
> doesn't know enough to contribute to it - I'd encourage you to keep
> discussions like this on-list. I've learned a lot just by reading this
> discussion, and would miss out on a lot if the default were to take
> discussions private as soon as they started to ramble a bit.
>
> It's entirely possible that what I'm suggesting is either against the 
> rules
> of the list or simply not agreeable to most people, and if that is the 
> case,
> please accept my humble apology.
>
> --
> Travis Northcutt
> _______________________________________________
> wp-hackers mailing list
> wp-hackers at lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-hackers
> ------------------------------------------------------------------------
>
> 	Ryan McCue <mailto:lists at rotorised.com>
> December 10, 2010 2:32 AM
>
>
> Otto wrote:
>> Okay, but is that a function of git or a function of github?
>
> GitHub is really just a nice UI on top of Git. That's really just doing
> a `git diff reddit/master...rmccue/master`
>
>> I guess my confusion here stems from the fact that you seem to be
>> mixing up a lot of things that should be separate. Trac is not SVN,
>> for example. And while yes, given a couple of URLs I can use a command
>> line of SVN to make a diff of two separate repositories and such, it's
>> not something I would want to do often. Basically, it sounds like a
>> pain in the ass.
>
> Sure, but currently, you get patches via Trac, and you can view them
> through the UI on there. GitHub (as a tool) can do that same thing, but
> also give you the context of the commits.
>
> If someone had just a Git repository, you could do it through the git
> command line itself, or a multitude of other ways.
>
>> (Note, not talking WP process here now, just general thoughts)
>>
>> When somebody sends me changes, I expect them to send me a file full
>> of their changes. I expect to read that file to see their changes. If
>> they send me a URL, then that's more burden on me. Now I have to go
>> and get their changes from somewhere. Now I have to go and do merges
>> to get their changes. Now I have to craft annoying command lines or
>> use online web tools just to see their changes.
>
> The majority of patches for WordPress come via Trac, and I'd assume
> that's where most people would get the patches from. If you're already
> using that web interface, why not integrate it into your web interface?
>
> I'd love to answer any other questions, and discuss this further with
> you, but I feel we're probably getting a bit off topic here. Feel free
> to email me off-list if you'd like to discuss this further.
>
> ------------------------------------------------------------------------
>
> 	Otto <mailto:otto at ottodestruct.com>
> December 10, 2010 2:11 AM
>
>
>
> Okay, but is that a function of git or a function of github?
>
> I guess my confusion here stems from the fact that you seem to be
> mixing up a lot of things that should be separate. Trac is not SVN,
> for example. And while yes, given a couple of URLs I can use a command
> line of SVN to make a diff of two separate repositories and such, it's
> not something I would want to do often. Basically, it sounds like a
> pain in the ass.
>
> (Note, not talking WP process here now, just general thoughts)
>
> When somebody sends me changes, I expect them to send me a file full
> of their changes. I expect to read that file to see their changes. If
> they send me a URL, then that's more burden on me. Now I have to go
> and get their changes from somewhere. Now I have to go and do merges
> to get their changes. Now I have to craft annoying command lines or
> use online web tools just to see their changes.
>
> Why can't they just send me their changes directly? Seems a whole hell
> of a lot simpler to me than to rely on a bunch of tools and web sites
> and management systems... Just send me the damn changes and let me
> look at them. Then I can decide whether to merge them or not. Then I
> can tell you what I think and give feedback. Making me jump through a
> bunch of hoops just to even SEE your changes is ridiculous.
>
> -Otto
> _______________________________________________
> wp-hackers mailing list
> wp-hackers at lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-hackers
> ------------------------------------------------------------------------
>
> 	Ryan McCue <mailto:lists at rotorised.com>
> December 10, 2010 2:03 AM
>
>
> Otto wrote:
>> I think you're missing the point. I almost never actually apply other
>> people's patches. I don't have to. I simply read them. You know, with
>> my eyes.
>>
>> If you give me a URL or whatever link to your branch, how do I see it?
>> How can I see what your code changes are?
>
> I do the same, and you can use the same workflow of patches if you'd
> prefer. If you'd prefer not to use patches, and use Git's, the web
> interfaces work extremely well for this.
>
> Take, for example, the changes I've been making to reddit's iPhone
> application. This works well as an example, since it's the same workflow
> as (I expect) people would use with WP. I forked their repository, and
> have been working on it on my own repository. You can check my changes
> at any time through something like:
>
> https://github.com/rmccue/iReddit/compare/master
>
> GitHub also makes merging this easy, with pull requests. Take for
> example, this one:
>
> https://github.com/reddit/iReddit/pull/1
>
> You can see the discussion (not unlike a Trac ticket), the commits, and
> you can get a diff view on the Files Changed tab.
>
> I'm not saying that we necessarily need to use GitHub (in fact, running
> our own would probably be better), but their interface is fantastic.
>
>> Also, keep in mind that I am not a core committer. I'm not pushing
>> changes into core. I submit my changes to trac like everybody else.
>
> I'm aware of this, but my point was that merging in code from others is
> not necessarily any harder than SVN. Specifically, refuting "As opposed
> to the dirt simple process of *applying* a patch file." (Emphasis mine)
>

-- 
Curtis McHale
SFNdesign
604.751.3482
http://curtismchale.ca
http://twitter.com/curtismchale
http://ca.linkedin.com/in/curtismchale