[wp-hackers] LEFT JOIN in 2.7 to JOIN in 2.8; Why?

[Peter Westwood]

On 17 Jun 2009, at 07:01, Lynne Pope wrote:

> Thanks for posting this Mike. I had a similar problem and hadn't  
> isolated
> it.
>
> My question (note - "question" not criticism) is why this wasn't in  
> 2.8
> final? The change was reverted on 25th May but this does not appear  
> in RC1
> or final. Just confused over the build process so would appreciate  
> it if
> anyone can explain please. Was this revision not committed to the  
> trunk by
> mistake?

Not sure what you mean here.

The original change in [11259] changed 4 instanced of LEFT JOIN to  
just JOIN.

On the 25th of May in [11452] one of the changes was reverted but the  
rest were kept.

The change that was reverted was because of the issue it caused with  
custom taxonomies - #9851

The packages that are made available for download are built from svn  
so this change would have been included.

Looking at the RC1 zipfile I can see this single LEFT JOIN in wp- 
includes/query.php:

			if ( $post_status_join ) {
				$join .= " LEFT JOIN $wpdb->posts AS p2 ON ($wpdb- 
 >posts.post_parent = p2.ID) ";
				foreach ( $statuswheres as $index => $statuswhere )
					$statuswheres[$index] = "($statuswhere OR ($wpdb- 
 >posts.post_status = 'inherit' AND " . str_replace($wpdb->posts,  
'p2', $statuswhere) . "))";
			}

westi
-- 
Peter Westwood
http://blog.ftwr.co.uk | http://westi.wordpress.com
C53C F8FC 8796 8508 88D6 C950 54F4 5DCD A834 01C5